[RESOLVED] Delete a Row

houston08

Ok, for some reason, I just can't seem to delete a row from MySQL using PHP. I've tried to alter my code several ways, but I must just be missing something simple. :bemused:


<?

require '../db_connect.php';

if ($logged_in == 1) {

include ("../../header.php");

$id=$_GET['query'];
$confirm=$_GET['confirm'];

$query = "SELECT `auto_id`, `name_first`, `name_last`, `email`, `city`, `state`, `country`, `zip_postal`, `phone_1`, `phone_2`, `phone_3`, `AskingPrice`, `type`, `phone_forgeign`, `contact_email`, `contact_phone`, `mostrecentcheck`, `mostrecentdate`, `priorcheck1`, `priorcheckdate1`, `priorcheck2`, `priorcheckdate2`, `priorcheck3`, `priorcheckdate3`, `priorcheck4`, `priorcheckdate4`, `priorcheck5`, `priorcheckdate5`, `LeaseName`, `LocationCity`, `LocationState`, `DecInterest`, `OpName`, `LegalDiscription` FROM `entries` WHERE auto_id = $id"; 
$result = mysql_query($query) or die("Query failed");
$row = mysql_fetch_array($result);

if ($confirm == "yes") {

$sql = "DELETE FROM entries WHERE auto_id=$id";
$removeWid = mysql_query($sql);

$title = "Deleted";
$redirect = "<meta HTTP-EQUIV=\"REFRESH\" content=\"5; url=../index.php\">";
$delete = "<b>Entry Deleted. Redirection to Main Page will occur in five seconds, or click You will automatically be re-directed to the frontpage in <u>5</u> seconds.</b><br>
(If re-direction doesn't occur, click <a href=\"../index.php\">here.</a>)";

} else {

$title = "Are you sure?";
$redirect = "";
$delete = "Make sure you want to delete this entry. <br>If you accidently delete it, <br>you won't be able to get it back.
<br><br><br><br><font size=\"16\"><a href=\"delete.php?id=$id&confirm=yes\">Delete</a></font>";

}
;

$print = "
<html>
<head>
$redirect
<title>$title</title>
</head>
<body>
<center>
<br><br><br><br><br><br><br><br><br><br><br>
$delete
</center>
</body>
</html>
"
;

print $print;

} else {

header( 'Location: ../login.php' ) 

;
}

?>

Also, I don't need to have

$query = "SELECT `auto_id`, `name_first`, `name_last`, `email`, `city`, `state`, `country`, `zip_postal`, `phone_1`, `phone_2`, `phone_3`, `AskingPrice`, `type`, `phone_forgeign`, `contact_email`, `contact_phone`, `mostrecentcheck`, `mostrecentdate`, `priorcheck1`, `priorcheckdate1`, `priorcheck2`, `priorcheckdate2`, `priorcheck3`, `priorcheckdate3`, `priorcheck4`, `priorcheckdate4`, `priorcheck5`, `priorcheckdate5`, `LeaseName`, `LocationCity`, `LocationState`, `DecInterest`, `OpName`, `LegalDiscription` FROM `entries` WHERE auto_id = $id";

couldn't I just have

$query = "SELECT `auto_id` FROM `entries` WHERE auto_id = $id";

and have the same effect?
Thanks.

NogDog

Do you get the "Entry deleted...." output prior to the meta redirect? If not, then you'll need to look at whether you're even reaching the if ($confirm == "yes") statement, and if so if the value of $confirm is actually "yes".

If you are getting there, but the data is not actually being deleted, then you might want to add some debug code to the mysql_query:

$removeWid = mysql_query($sql) or die("Delete query failed: $sql - ".mysql_error());
if(mysql_affected_rows() == 0)
{
   die("Query processed but no records deleted: $sql");
}

(Eventually you'll want to make more user-friendly error-handling than just die()-ing, but for now it will give you a quick way to figure out what's actually happening.)

houston08

no, I don't even get there, I forgot to mention that, sorry.

I get a "Query failed," which is on line 13, right under the query. That's where I got lost.

NogDog

In that case, do the same thing I suggested, above, to get a bit more debug info:

$result = mysql_query($query) or die("Query failed: $query - ".mysql_error());

Actually, I'm wondering if you even need to do that query at all?

houston08

I have the query for later on if I wish to give more info about what I'm deleting. I currently have this in the result...

$result = mysql_query($query) or die("Query failed: " . mysql_error());

and on the final page, where the file references itself to delete a file, I get this

Query failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

any ideas?

Weedpacket

You don't need the SELECT statement at all (seeing as you never use anything it returns).

Just send the DELETE statement. If you want to what what if anything was deleted, that can be done with [man]mysql_affected_rows[/man].

houston08 wrote:
any ideas?

Output the value of $query as well as the error message (as in NogDog's example).

houston08

Fixed. I had the wrong URL. I had it as $id when it was supposed to be $query.
Thanks.