[RESOLVED] code review anyone?

[chrisj8221]

can someone look at this code below and troubleshoot it

$query="select count(*) as re,sum(rating)/count(*) as rt,review_item_id,item_name,item_price,item_dspace,item_bwidth,item_affiliate_code FROM review,review_items WHERE (review.review_item_id=review_items.item_id group) AND (review_items.category = 'shared%') by review_item_id order by rt desc Limit $show_num";

I'm sure it is a simple syntax error - but I can't find it.

Thanks

Chris

[bradgrafelman]

1. What is the error message from MySQL?

2. What's the purpose of 'by review_item_id' towards the end?

3. If 'shared%' is supposed to have a wildcard in it, you need to use the LIKE 'shared%' syntax instead of = 'shared%'.

[chrisj8221]

error simply says...

mysql_error

the by item id is to sort it

and yep - I've added the LIKE and still have the same old error expression...

mysql_error

[bradgrafelman]

1. That may be what your custom error message says, but what we need is the output from [man]mysql_error/man.

2. 'by review_item_id' means nothing. "ORDER BY review_item_id", on the other hand, means to sort the data by this field. Now, seeing as how you already have an ORDER BY, you'd add this field to the list of ORDER BY fields in a comma-delimited fashion. If you're not sure what I mean, lookup the syntax for ORDER BY in the MySQL manual.

[chrisj8221]

thanks for the insights - i have fixed it and it was as you suggested!