[RESOLVED] Pagination problem

[Mythotical]

EDIT: Ok got my first problem taken care of, next problem is if you view the link below you will see that [1] displays, but there should be [1] [2] so I can't figure out why the second page link isn't showing.

EDIT2: I also need to change ?num=$page to ?page=$page, from below I"m afraid to touch anything as I don't wanna break it.

EDIT3: Once I had enough inserted for 1 full row on the second page it started showing the page numbers properly so now that is the fix.

//Get the numeration of the page
$num = $_GET['num'];

//if the numeration is empty
if(empty($num)){
//the numeration is 1
$num = 1;
};
//Sets the limit of results to display in each page, change if you want.
$limit = 12;
/*
The query will start selecting the numeration, for example 2, less 1, that would be 1
* the limits of results to show per page, 2 in this case so it would be 1*2 = 2, it will
start from 2 ;) if the limit would be 5 and the numeration would be 3 if would be (3-1)*5 = 10
*/
$start = ($num-1)*$limit;
//rounds the result
$start = round($start,0);
/*
This query will select the contrene FROM the start and with a limit of 2, in this case,
because the variable $limit is 2
You can add a WHERE something= '$something' for example, or delete the ORDER by `id`, or change it,
etc
*/
$sql = "SELECT imgid,imgtype FROM tblimage ORDER BY imgid LIMIT $start, $limit";
//now it makes the query and names it as result2
$result2 = mysql_query($sql);
/*
While will repeat this query and mysql_fect_array allow me array the content
*/
while ($r = mysql_query($result2)){
echo "$r[title]<br>";//Echoes the content
};
//Get the total number of results
$totalpages = mysql_num_rows(mysql_query("SELECT * from `tblimage`"));
/*
Total resutls/ the limit, in this example is 2, so if there are 10 total result and the limit is 2
there will be 5 pages.
*/
$totalpages = $totalpages / $limit;
$totalpages = round($totalpages,0);
//The variable c is 0
$c = 0;
//while c is < than the total pages
while($c<$totalpages){
//sets the variable $page as 0 + 1 = 1
$page = $c + 1;
//Gets the number of the page and if its the same that the page
if($_GET['num']==$page){
//its only echoes the page, not the url to this page
echo "[$page] ";
}else{
//it echoes the url to the page
echo "<a href=?num=$page>[$page]</a> ";
}
$c = $c+1;
}

Gallery: http://unleashed.farimynn.com/gallery/index.php

Thanks in advance

[bradgrafelman]

Mythotical wrote:

I"m afraid to touch anything as I don't wanna break it.

Then we're afraid to offer suggestions. C'mon, be brave! You only need to change the 'num' reference in two places!

Also, as to your problem with a second page, try changing this line:

$totalpages = round($totalpages,0);

to use the [man]ceil/man function instead. Why? You always want to round up. Think about it: if you have enough images for exactly 3 pages, then you should display three pages, right? Well, let's say you uploaded 3 more images, now you have enough for exactly 3.25 pages. Now, if you round() that number, it's going to round down to 3, naturally. What we want, though, is 4 - otherwise we're missing a few images.

EDIT: Oh yeah, almost forgot. As an optimization, you can get rid of this line:

$totalpages = mysql_num_rows(mysql_query("SELECT * from `tblimage`")); 

in favor of something like:

$totalpages = mysql_result(mysql_query("SELECT COUNT(*) FROM `tblimage`"), 0);

EDIT2: Then again, if we're dealing with optimization, it might just be better to include the COUNT(*) in your other query, eliminating the second query altogether. This is my best guess, but I'm still looking into it.

[Mythotical]

I don't understand ceil function at all.

I just switched to a domain and now I broke the gallery so I gotta figure out how to fix the issue. If you have any suggestions on what I should check then please throw them at me.

[bradgrafelman]

Mythotical wrote:

I don't understand ceil function at all.

You mean you don't understand what the [man]ceil/man function itself does, or you don't understand why I suggested using it?

Mythotical wrote:

If you have any suggestions on what I should check then please throw them at me.

If you can provide a new link and (most importantly) the error messages/behaviors you're getting, I'm sure I/everyone can try.

[Mythotical]

I don't understand the ceil() function itself and even how to use it properly. Never heard of it till now.

I got the problem fixed, didn't edit every DB file like I should have.

EDIT: Also what num do I need to edit?

[bradgrafelman]

Mythotical wrote:

EDIT: Also what num do I need to edit?

1.

//Get the numeration of the page 
$num = $_GET['num']; 

Obviously, you're going to have a different $_GET variable to grab from the query string...

2. echo "<a href=?num=$page>[$page]</a> "; 

   Again, you'll obviously want to change the variable name in the query string here.

Also, note that your "href=" value should have quotes around it (just like any other attribute's value in HTML).

[Mythotical]

Resolved

[madwormer2]

Use [man]ceil[/man] as has been said already.

Click that link if you don't understand how to use it / what it does. The manual is your friend, if you've never used it before, you're going to want to bookmark it 😉

[Mythotical]

LOL, reading doesn't help me, I go off of examples alot better. I had a friend of mine who thankfully was online show me how to implement ceil function and it works great now.

[madwormer2]

The manual HAS examples. It requires no reading, you can even copy and paste it...

The manual is the friend that's always there, and doesn't get annoyed if you keep asking it stuff.

[Mythotical]

Well the manual doesn't have easily understandable examples. My point is, I understand things better off of examples that are simple to look at it and understand.

So are you trying to say people are getting annoyed here with me asking for help?

[bradgrafelman]

Mythotical wrote:

So are you trying to say people are getting annoyed here with me asking for help?

Certainly not... although, he might be saying people are getting annoyed with false statements.

Mythotical wrote:

Well the manual doesn't have easily understandable examples.

Returns the next highest integer value by rounding up value if necessary. The return value of ceil() is still of type [man]float[/man] as the value range of [man]float[/man] is usually bigger than that of [man]integer[/man].

Example 1. ceil() example

<?php
echo ceil(4.3);    // 5
echo ceil(9.999);  // 10
echo ceil(-3.14);  // -3
?>

How much "easier" could that example have been made?

[madwormer2]

I was actually referring to his friend that helped him out. If you go to him every time, I'm pretty sure he'll start getting annoyed at some point.

The manual on the other hand... 😛