[RESOLVED] One long line?

IBMJohn

I was wondering, when I view my source in the browser my PHP code shows
as one long line. Any ideas why this is?

John

laserlight

You probably did not include HTML line breaks when printing out HTML code from PHP. It does not really matter, unless you are trying to fix your HTML by looking at the output from PHP.

IBMJohn

I am not sure what you are talking about but I do have "<BR>" in the code.

Do you have an example?

The STYLE section shows properly but the PHP section does not.

Houdini

Are you talking about viewing the page source of the file? If so then you need to use the newline \n at places where you wish a line break. Or are you talking about the actual HTML that is dispalyed perhaps a link to this page would help.

IBMJohn

I am talking about using the view source function of the browser.

<?php
    if(!mysql_connect("localhost","root",""))
    {
        echo "<h2>".$TEXT['cds-error']."</h2>";
        die();
    }

mysql_select_db("cdcol");
$result=mysql_query("SELECT id,titel,interpret,jahr FROM cds ORDER BY interpret;");

$d1="dynamically";
Print "<pg-hdr>Hello John</pg-hdr>";
Print "<BR>";

echo "This is a cool way to write web pages <b>" . $d1 . "</b>";
print "<BR>";

$d1="statically";
echo "This is a cool way to write web pages <addrtxt>" . $d1 . "</addrtxt>";
print "<BR><BR>";

/* Create the table header */
print ("<table width=\"100%\" cellpadding=\"0\" cellspacing=\"0\" align=\"left\" border=\"2\">");  
print ("<tr>");
print ("<td align=center>");
    print "<t-hdr>&nbsp Line #</t-hdr>";
print ("</td>");
print ("<td align=center>");
    print "<t-hdr>&nbsp Artist</t-hdr>";
print ("</td>");
print ("<td align=center>");
    print "<t-hdr>&nbsp Title</t-hdr>";
print ("</td>");
print ("<td align=center>");
    print "<t-hdr>&nbsp Year</t-hdr>";
print ("</td>");
print ("</tr>");

/* Init counter */
$lineno = 1;
while( $row=mysql_fetch_array($result) )
{
    echo   ("<tr><addrtxt>");
    echo ("<td>");
    echo "<t-row>&nbsp  $lineno </t-row>";
    echo ("</td>");
    echo "<td><t-row>&nbsp " . $row['interpret'] . "&nbsp<br>";
    echo "<td><t-row>&nbsp " . $row['titel'] . "&nbsp<br>";
echo "<td align=center><t-row>&nbsp " . $row['jahr'] . "&nbsp;</td>";
    echo ("</addrtxt></tr>");
    $lineno++;
}

print ("</table>");
?>

Browser View Code shows

<HTML>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
    <title>Testing PHP</title>
</head>
<body>
<STYLE TYPE="text/css">
<!--
pg-hdr
    {
        font-family: Tahoma, Helvetica, sans-serif;
        color:blue;
        font-size:30pt;
        font-style:italic;
        font-variant: small-caps;
    }

t-hdr
    {
        font-family: Tahoma, Helvetica, sans-serif;
        color: blue;
        font-size: 12pt;
        font-style: bold italic;
        font-variant: small-caps;
        letter-spacing: 6px;
        text-align: center;
        text-valign: center;
    }
t-row
    {
	font-family: Tahoma, Helvetica, sans-serif;
	font-size: 8pt;
	letter-spacing: 2.5px;
	text-align: center;
	text-valign: center;

}
-->
</STYLE>

<pg-hdr>Hello John</pg-hdr><BR>This is a cool way to write web pages <b>dynamically</b><BR>This is a cool way to write web pages <addrtxt>statically</addrtxt><BR><BR><table width="100%" cellpadding="0" cellspacing="0" align="left" border="2"><tr><td align=center><t-hdr>&nbsp Line #</t-hdr></td><td align=center><t-hdr>&nbsp Artist</t-hdr></td><td align=center><t-hdr>&nbsp Title</t-hdr></td><td align=center><t-hdr>&nbsp Year</t-hdr></td></tr><tr><addrtxt><td><t-row>&nbsp  1 </t-row></td><td><t-row>&nbsp Bran Van 3000&nbsp<br><td><t-row>&nbsp Glee&nbsp<br><td align=center><t-row>&nbsp 1997&nbsp;</td></addrtxt></tr><tr><addrtxt><td><t-row>&nbsp  2 </t-row></td><td><t-row>&nbsp Groove Armada&nbsp<br><td><t-row>&nbsp Goodbye Country (Hello Nightclub)&nbsp<br><td align=center><t-row>&nbsp 2001&nbsp;</td></addrtxt></tr><tr><addrtxt><td><t-row>&nbsp  3 </t-row></td><td><t-row>&nbsp Jeremy Camp&nbsp<br><td><t-row>&nbsp Forgiven&nbsp<br><td align=center><t-row>&nbsp 2005&nbsp;</td></addrtxt></tr><tr><addrtxt><td><t-row>&nbsp  4 </t-row></td><td><t-row>&nbsp Ryuichi Sakamoto&nbsp<br><td><t-row>&nbsp Beauty&nbsp<br><td align=center><t-row>&nbsp 1990&nbsp;</td></addrtxt></tr></table></body>

</html>

and yes I know that I suck right now but I have only been learning for a few days so give me a little break please. :rolleyes:

IBMJohn

By the way any constructive comments that you have or links to docs you have would be truely appreciated.

I have a couple of books that I am reading:

PHP and MySQL from O'Reilly

Any cookbook or style guide links would be really great.

thanks

Houdini

The source you are viewing will not have line breaks or returns unless you add them, and this is not usually a problem but if you really want to add line breaks to the source then add \n or \r\n right after the <br> (which should actually be <br /> for XHTML) the <br />is an html command where the newline or return is a Linux or Unix command and will be seen in the source so for example change the following lines

Print "<pg-hdr>Hello John</pg-hdr>";
Print "<BR>";

Print "<pg-hdr>Hello John</pg-hdr>";
Print "<BR>\n";

then run the file and look at the resulting source and you will see the line breaks wherever you pace the \n or \r\n characters.

BTW Looking at the source the <style> was closed but the <body> was not you might want to amend your code for proper tag closing.

IBMJohn

Thanks

bradgrafelman

Or stop using so many echo's ...

   Print "<pg-hdr>Hello John</pg-hdr> 
<BR>     

This is a cool way to write web pages <b>$d1</b>
<BR>";
// etc.

EPJS

I never really understood why people use \r when \n works just fine. I've always just used \n when wanting new lines in the source code.

Houdini

Mac uses \r unix uses \n MS-DOS uses \r\n and using certain functions PHP like addslashes PHP automatically adds \r\n. So to sum it up \r\n is the same as using <?php instead of the <? short tag with PHP where <?php use will always work and <? may not especially if using XML...so using\r\n is the best method because any system will understand that you want a newline where just \n may or may not. So the code you write might work fine on your machine but not necessarily on someone elses Mac or Linux or Unix.

Also when sending email with PHP note this from the manual

String to be inserted at the end of the email header.

This is typically used to add extra headers (From, Cc, and Bcc). Multiple extra headers should be separated with a CRLF (\r\n).

Why because it will work with all systems.