Problem with &quot;if&quot;

Problem with "if"

Jazzy_Girl

Hi, I have an "if" statement that says pop up these forms if such and such field is empty.

if ($POST['text']==""){echo "<form method="post" action="<?php $SERVER['PHP_SELF'] ;?>">
<input type='text' name='text' size=20>and other input fields with other names below this. Then the submit.
<input type='submit' name='submit' value='Submit Form' /></form>

Thing is, if the text fields is filled in but other fields aren't, none of it will send to my email. Is there some other If I can use so that no matter what fields are filled the email will still send?
I can't use
if ($_POST), I have it elsewhere on my page and it conflicts with the other.

I am not listing all my code because its too big and this is the only part causing the problem. I can tell its the problem because when I put one of the other input fields in here instead if ($_POST['anotherformfield']=="") and then fill in the field and send the form, it sends to my email. If I leave 'anotherformfield' empty and fill in any of the other input fields, it won't send to my email.

Anything I can do for a fix? Thank you very much.

sid

i'm not 100% sure if i understood your problem properly, but you are showing an if, that is responsible for a form being displayed; however, the problem you outline is a formhandler/email problem. it would be easier to help, if you actually did post more of that code.

Jazzy_Girl

Thank you very much, here it is. Row field taken from database and inserted into $row[email] all works fine. Just if any other form field is filled but 'text' form field is empty, email won't send. If 'text' form field is filled, email sends.

while ($row = mysql_fetch_array($result)){
if ($POST['text']==""){?>
<form method="post" action="<?php $SERVER['PHP_SELF'] ;?>">
<input type='text' size=20 name='sendingto' value="<?php echo $row[email];?>" />
<input type='text' name='text' size=20><br /><br />
<input type='text' name='comments' size=20><br /><br />
<input type='submit' name='submit' value='Submit Form' /></form>
<br /><br />
<?php
}
else{
$mailto = $POST['sendingto'] ;
$subject = 'Email Subject' ;
$text = $POST['text'] ;
$comments= $_POST['comments'] ;
$uself = 0;
$sep = (!isset( $uself ) || ($uself == 0)) ? "\r\n" : "\n" ;
$messageproper = "Email body.\n";
mail($mailto, $subject, $messageproper, "From: \"$text\" <$text>" . $sep . "Reply-To: \"$text\" <$text>" . $sep);
echo "email sent";
}
}
}
?>

sid

<?php
while ($row = mysql_fetch_array($result)){
    if ($_POST['text']==""){
?>

<form method="post" action="<?php $_SERVER['PHP_SELF'] ;?>">
<input type='text' size=20 name='sendingto' value="<?php echo $row[email];?>" />
<input type='text' name='text' size=20><br /><br />
<input type='text' name='comments' size=20><br /><br />
<input type='submit' name='submit' value='Submit Form' /></form>
<br /><br />

<?php
}
else{
    $mailto = $_POST['sendingto'] ;
    $subject = 'Email Subject' ;
    $text = $_POST['text'] ;
    $comments= $_POST['comments'] ;
    $uself = 0;
    $sep = (!isset( $uself ) || ($uself == 0)) ? "\r\n" : "\n" ;
    $messageproper = "Email body.\n";

mail($mailto, $subject, $messageproper, "From: \"$text\" <$text>" . $sep . "Reply-To: \"$text\" <$text>" . $sep);
echo "email sent";
}
?>

i took out the trailing "}}", as i think it was a copied by accident.
first off an html issue: you mix no, single and double quotes in tags. use double quotes! i.e.

<input type="text" size="20" name="sendingto" value="<?php echo $row[email];?>" />

instead of

<input type='text' size=20 name='sendingto' value="<?php echo $row[email];?>" />

there is a similar inconsistency in the PHP code. i would use

mail($mailto, $subject, $messageproper, "From: " . $text . " <" . $text . ">" . $sep . "Reply-To: " . $text . " <" . $text . ">" . $sep);

instead of

mail($mailto, $subject, $messageproper, "From: \"$text\" <$text>" . $sep . "Reply-To: \"$text\" <$text>" . $sep);

that is, in case that $text is an email address! otherwise it will cause an error, when it's between the "<" and ">".

i'm really just taking a wild stab at it, but this is how i would write the code (though i personally would not mix html and php; but this - just like the above issues - is mostly personal preference and style). hopefully the changes in the form values address the problem you meant!

<?php
//stuff here

while ($row = mysql_fetch_array($result)){
    if (!$_POST['text']){
?>

<form method="post" action="<?=$_SERVER['PHP_SELF']; ?>">
    <input type="text" size="20" name="sendingto" value="<?=$row[email]; ?>" />
    <input type="text" name="text" size="20" value="<?=htmlspecialchars(trim($_POST['text'])); ?>" /><br /><br />
    <input type="text" name="comments" size="20" value="<?=htmlspecialchars(trim($_POST['comments'])); ?>" /><br /><br />
    <input type="submit" name="submit" value="Submit Form" />
</form>
<br /><br />

<?php
}
else{
    $uself = false;
    $sep = (!isset($uself) || ($uself == 0) ? 
        "\r\n" : 
        "\n");

if (mail(
    $_POST['sendingto'], 
    "Email Subject", 
    "Email body.\n" . $_POST['comments'], 
    "From: " . $_POST['text'] . $sep . "Reply-To: " . $_POST['text'] . $sep
    )
) {
    echo "email sent";
}
else {
    echo "ERROR!";
}
}

//stuff here
?>

to prevent errors in the mail() execution, i would advise a regex-check for the validity of the email address!

Jazzy_Girl

Thanks, for all that, I'll it that for later. Right now I can't redo everything its too much work. First, can someone at least tell me what this is saying? If I understand what its asking for then I'll know, how to change it to ask for something else. Thank you very much.
if ($_POST['text']=="")

laserlight

If $_POST['text'] is equal to a blank string....

I suggest that you read the PHP Manual on control structures.