Problems with quotes within quotes

cupboy

Here is the code:

$outputline .= "<Input Type='text' name='cdtitle' size=35 maxlength=80 value='" . $title . "'>";

It's probably pretty hard to read the quotes in the sample above but if $title contains an item with a quote it interferes with the quote after the word value. What function would help me with this? I've already tried several but the results still are not correct.

pcthug

You must escape them with a \ (backslash):

outputline .= "<Input Type=\"text\" name=\"cdtitle\" size=35 maxlength=80 value=\"$title\">";

rvdavid

I use single quotes for my strings.

example:

$title = 'rvdavid\'s demo';
$outputline = '<Input Type="text" name="cdtitle" size=35 maxlength=80 value="' .$title. '">';

Go here to learn more about strings in PHP.

If you are set in your ways and really don't feel like changing your string literals, you could fix your problem using htmlspecialchars() with the ENT_QUOTES flag. However, it does transform the input data.

So you should put some thoughts into it if you are planning on using the data for other things besides displaying on html.

example:

$title = "rvdavid's demo";
$outputline = "<Input Type='text' name='cdtitle' size=35 maxlength=80 value='" . htmlspecialchars($title, ENT_QUOTES) . "'>";

HTH 🙂

regards,

NogDog

EDIT: Oops, I didn't scroll down quite far enough to see that the previous reply already suggested this.

$outputline .= "<Input Type='text' name='cdtitle' size=35 maxlength=80 value='" . 
        htmlspecialchars($title, ENT_QUOTES) . "'>";

rvdavid

NogDog wrote:
EDIT: Oops, I didn't scroll down quite far enough to see that the previous reply already suggested this.

🙂 do that all the time as well.