[RESOLVED] move_uploaded_file() issue with permissions

joshmpratt

Here is the code:

//Upload Files
		$target_path = "uploads/";
		for ($i=1; $i<=3; $i++) {
			if ($_FILES['file'.$i]['size'] > 0) {
				$uploadfile = $target_path . basename($_FILES['file'.$i]['name']);
				if(move_uploaded_file($_FILES['file'.$i]['tmp_name'], $uploadfile)) {

			} else{
				$error[] = "There was an error uploading file ".$i;
			} 
		}
	}

Permissions are set to 777 on the directory that it uploads the files to. Any ideas?

dalecosp

The parent directory's permissions?

joshmpratt

777 on it's parent directories

dalecosp

Well, it gets kinda complex then. Perhaps the best thing at this point is to point you here and see if anything rings a bell.

Could be a server configuration issue in any of several flavors.

ClarkF1

do var_dump($FILES); to check the contents of the $FILES array

If you are uploading more than one file at a time it might be to do with array referencing.

joshmpratt

Well.. The var_dump gave me this... Don't really understand it...

array(3) { ["file1"]=> array(5) { ["name"]=> string(10) "hcnup2.jpg" ["type"]=> string(10) "image/jpeg" ["tmp_name"]=> string(14) "/tmp/phpQHISj4" ["error"]=> int(0) ["size"]=> int(65453) } ["file2"]=> array(5) { ["name"]=> string(0) "" ["type"]=> string(0) "" ["tmp_name"]=> string(0) "" ["error"]=> int(4) ["size"]=> int(0) } ["file3"]=> array(5) { ["name"]=> string(0) "" ["type"]=> string(0) "" ["tmp_name"]=> string(0) "" ["error"]=> int(4) ["size"]=> int(0) } }

dalecosp

What operating system is this server?

fean0r

does the file upload or not?

joshmpratt

It is a Linux OS, run on Apache.

No, the file does not upload...

bradgrafelman

Can you show us some error messages?

Roger_Ramjet

Yes the file does upload, it just gets renamed in the process. That is what ["tmp_name"]=> string(14) "/tmp/phpQHISj4" means, you will find your file in the tmp dir under the name phpQHISj4. Not quite sure why this random name rename takes place; probably to do with ensuring names are unique in a shared hosting environment. Anyway, you have to move the file from the tmp dir to your upload dir and rename it to what you want.

Weedpacket

Roger Ramjet wrote:
probably to do with ensuring names are unique in a shared hosting environment.

That's exactly why; or perhaps two instances of the uploader receiving files at the same time, or someone uploading two files with the same name 🙂

Roger_Ramjet

Yep, but it would just be easier if we could upload the file to our target dir in the first place.

Weedpacket

Perhaps, but dealing with collisions might get messy.

joshmpratt

I just don't get it... Permissions are all set to 777... Here is the new code and the error I'm getting:

$uploaddir = '/home/eaglebro/public_html/cad_uploads/';
if ($_FILES['file1']['size'] > 0) {
			$uploadfile1 = $uploaddir.basename($_FILES['file1']['name']);
			if(move_uploaded_file($_FILES['file1']['tmp_name'],$uploadfile1)) {
				echo "It worked I guess...";
			} else {
				$error[] = "There was an error";
			}
		}

Here is the form code:

<input type="hidden" name="MAX_FILE_SIZE" value="10000000" />
File 1: <input id="f_file1" name="file1" type="file" /><p>

Here is the error:

Warning: move_uploaded_file(/home/eaglebro/public_html/cad_uploads/great_minds.jpg): failed to open stream: Permission denied in /home/eaglebro/public_html/cad/index.html on line 97

Warning: move_uploaded_file(): Unable to move '/tmp/phpBduniO' to '/home/eaglebro/public_html/cad_uploads/great_minds.jpg' in /home/eaglebro/public_html/cad/index.html on line 97

ClarkF1

I had a multiple file upload script which I just found.

The form was the same as yours but the name of the field was different (note the [], you can use anything before that, but the [] is important:

File 1: <input id="f_file1" name="upfile[]" type="file" />

Then the processing code (adapting it to suit yours) would be:

$uploaddir = './cad_uploads/';
for ($i = 0;$i < 3; $i++)
{
if ($_FILES['upfile']['size'][$i] > 0) {
      if(move_uploaded_file($_FILES['upfile']['tmp_name'][$i],$uploaddir.basename($_FILES['upfile']['name'][$i])) {
                echo "It worked I guess...";
            } else {
                $error[] = "There was an error";
            }
        }
}

That might work

Also to expand on my last suggestion:

echo "<pre>";
var_dump($_FILES);
echo "</pre>";

should provide a nicely formatted layout of the $_FILES array so you can see its makeup

joshmpratt

Ok, PROBLEM SOLVED!

Through cPanel, it was telling me that the upload directory was set to 777 for permissions. But, just to get a second opinion, I opened it up through an FTP client which told me that permissions were set to 755. So, I changed it to 777 through that and now it works. Stupid cPanel...

dalecosp

:rolleyes:

CPanel ... we don't need no steenking GUI.

I never trust 'em.... 😃