[RESOLVED] Error in my Upload Script?

[brendan2b]

I have a page that lets you upload a picture for your profile. It takes this picture and puts it into a folder which is titled by corresponding usernames. For example for the username brendan it would go in the folder photos/brendan/imagegoeshere.

I created this code, which might not be totally secure, but I worked a few bugs out of it. I was wondering why when I try uploading a picture, it always tells me the last else in the code, even if I meet all the requirements, and if it is just a server upload issue, what could be some of the problems I am having.

 <?
  $target = 'photos/'.$username;
$target = $target . basename( $_FILES['upload']['name']) ;





if (($_FILES["upload"]["type"] == "image/gif")
  || ($_FILES["upload"]["type"] == "image/jpeg")
  || ($_FILES["upload"]["type"] == "image/jpg")
  || ($_FILES["upload"]["type"] == "image/png" )
  && ($_FILES["upload"]["size"] < 2000))
{
 if(move_uploaded_file($_FILES['upload']['tmp_name'], $target))
{
?>
<span class="style22">Your file has been uploaded sucessfully.  To return to My Album click here.</span>

<?

}
else
{
?>
<span class="style22"><br><center>Sorry your file was not uploaded. Please hit the back button and try again. </center></span>
<?
}

  }
else
  {
  ?>
  <span class="style22">Sorry, but the file must be less than 2 megabytes, and it must also be a .jpeg .jpg .gif or a .png. Please go back and upload another photo.</span>

  <?

  }



?>

O yea, $username is defined on the top of that same page, so it is a declared variable.

[schajee]

U need to separate the || and the &&... ((JPG||PNG||GIF||JPEG)&&(SIZE))

[brendan2b]

I tried that schajee but that was not the problem, because it still give me that error.

[schajee]

Its happening in size... file sizes are maintained in bytes not kilobytes

<?php

$target = 'photos/'.$POST['username'];
$target = $target ."/". basename($FILES['upload']['name']) ;

if (($FILES['upload']['type'] == "image/png") || ($FILES['upload']['type'] == "image/gif") || ($FILES['upload']['type'] == "image/jpg"))
if ($FILES['upload']['size'] < 2000000)
if(move_uploaded_file($_FILES['upload']['tmp_name'], $target))
print "Done!";
else print "Could not upload";
else print "Invalid File Size";
else print "Invalid File type";

?>

[brendan2b]

Man i duno what im doing wrong because it will not work for me, and i check and i do have full permissions to the folder im uploading to.

[schajee]

if you're getting "could not upload" then u need to fix the move_uploaded_file part. Otherwise make sure u have the size set to 2MB (2000000) not 2K (2000)

[brendan2b]

Ye i broke i down and its the move_uploaded_file function that is not working properly. Could it be a path error? Am I not allowed to put the $_SESSION['username']; at the end of the $target/path variable?

[schajee]

The filename is being made properly, just print it out to make sure u added the slash (/). You didn't have it earlier.

And as a rule always print before you do something with a variable. Helps reduce our quality time together 🙂

[brendan2b]

Wait now all of the sudden im getting invalid file type when its a .jpg files im uploading... This is driving me nuts im so lost.

[brendan2b]

Sry man im so bad at this. Ill just get it somehow, you dont need to keep trying to help me.

[schajee]

I removed the "jpeg" part, you can add that.... other than that its working fine

[schajee]

For me the issue is another one... sometimes it happens sometimes it doesn't 🙂

[brendan2b]

Maybe my host blocked something I need to upload. Im calling them now.