[RESOLVED] Error when link clicked

[Ronny]

Hello. I have an osCommerce shop with a link to a "tell a friend page".
I have tryed the osCommerce forums but with no responce.

When clikcking the link I get the following message:

Parse error: syntax error, unexpected T_ECHO, expecting ',' or ';' in /hsphere/local/home/webtask/eterya.com/tell_a_friend.php on line 123

Here´s the link:

<?php echo '<a class="ml7" href="' . tep_href_link(FILENAME_TELL_A_FRIEND, 
'products_id=' . $HTTP_GET_VARS['products_id'], 'NONSSL') . '">' 
. BOX_TELL_A_FRIEND_TEXT . '</a>'; ?>

And here´s line 123 in tell_a_friend.php:

<td class="bg6 ab" width="496" height="26"> &nbsp; &nbsp;
<?=tep_image(DIR_WS_IMAGES.'m29.gif')?> &nbsp;<span class="tx2">
<?=echo sprintf(HEADING_TITLE, $product_info['products_name'])?>
</span></td>

Attaching the to files.

Anyone have any ideas?

[madwormer2]

You need a ; just before the ?> tag.

The error is pretty self explanatory, it even tells you it's expecting a ;

[leatherback]

Madwormer: Great help, especially since for the person asking it is NOT self explanatory,

Try replacing:

<?=echo sprintf(HEADING_TITLE, $product_info['products_name'])?>

with

<?=echo sprintf(HEADING_TITLE, $product_info['products_name']);?>

Ad Madwormer pointed out: The echo statement is missing a semicolon.

If that doesn't work, check the coding in the line ABOVE it, as PhP usually notices an error one line late.

[EPJS]

isn't "<?=" the same as "<? echo" so wouldn't this work?

<?=sprintf(HEADING_TITLE, $product_info['products_name']);?>

[stolzyboy]

technically yes... but <?= is the shorthand and is not enabled by default on all servers

to be more portable, it should be <?php echo

stolzyboy

[Ronny]

Thanks your replies. I´ll try your suggestions.

[Ronny]

I tried, but get same error :bemused:

[ClarkF1]

did you do it for the other one:

tep_image(DIR_WS_IMAGES.'m29.gif')

should be

tep_image(DIR_WS_IMAGES.'m29.gif');

[Ronny]

Yepp...
There are several end tags in that area and I tryed putting ";" in front of all "?>" tags.

Here´s the original code with lines before and after line 123:

<tr><td valign="top">
			 <table border="0" cellspacing="0" cellpadding="0">
			  <tr><td width="2"></td>
				  <td width="220" valign="top"><?php require(DIR_WS_INCLUDES . 'column_left.php'); ?></td>
				  <td width="2"></td>
				  <td width="505" valign="top">
				   	   <?php require(DIR_WS_INCLUDES . 'menu.php'); ?>
					   <table border="0" cellspacing="0" cellpadding="0">
						<tr><td><?=tep_image(DIR_WS_IMAGES.'m27.gif')?></td>
							<td class="bg6 ab" width="496" height="26"> &nbsp; &nbsp;
<?=tep_image(DIR_WS_IMAGES.'m29.gif')?> &nbsp;<span class="tx2">
<?=echo sprintf(HEADING_TITLE, $product_info['products_name'])?></span></td>
							<td><?=tep_image(DIR_WS_IMAGES.'m30.gif')?></td></tr>
						<tr><td height="15" colspan="3"></td></tr>
					   </table>

I find ";" in only the first php line 😕

[ClarkF1]

well it should be in all the others......is this the code after you updated it or is it the original code.

We need to see the updated code if it's still not working

[Ronny]

Updated code:

<tr><td valign="top">
			 <table border="0" cellspacing="0" cellpadding="0">
			  <tr><td width="2"></td>
				  <td width="220" valign="top"><?php require(DIR_WS_INCLUDES . 'column_left.php'); ?></td>
				  <td width="2"></td>
				  <td width="505" valign="top">
				   	   <?php require(DIR_WS_INCLUDES . 'menu.php'); ?>
					   <table border="0" cellspacing="0" cellpadding="0">
						<tr><td><?=tep_image(DIR_WS_IMAGES.'m27.gif');?></td>
							<td class="bg6 ab" width="496" height="26"> &nbsp; &nbsp;<?=tep_image(DIR_WS_IMAGES.'m29.gif');?> &nbsp;<span class="tx2"><?=echo sprintf(HEADING_TITLE, $product_info['products_name']);?></span></td>
							<td><?=tep_image(DIR_WS_IMAGES.'m30.gif');?></td></tr>
						<tr><td height="15" colspan="3"></td></tr>
					   </table>

[ClarkF1]

Have you tried it with

<?php echo

instead of

<?=

It's good practice to use the long tag

[EPJS]

stolzyboy wrote:

technically yes... but <?= is the shorthand and is not enabled by default on all servers

to be more portable, it should be <?php echo

stolzyboy

yeah but what I was really getting at is why he was using "<?=echo" 😃

[Ronny]

THAT WAS IT!!! THANK YOU!!!

God, this is a great forum. This is the second problem I´ve posted and the response is great. Both problems got fixed in no time.

🙂 🙂 🙂

PS:

yeah but what I was really getting at is why he was using "<?=echo"

Can´t answer that. Didn´t write the code. 😉