[RESOLVED] Image Upload Warnings

[brendan2b]

So i have a form where a user uploads an image. It can either be a .jpeg .gif or a .png. If the upload is succesful it takes them to a page where it displays a link to go back to their album.

Once they click that link it creates a thumbnail of the image they just uploaded it so they can see it and then it redirects them to the members page.

When i upload a .gif i get the following errors.

Warning: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error: in /home/photocoo/public_html/successful.php on line 35

Warning: imagecreatefromjpeg(): 'photos/pele.gif' is not a valid JPEG file in /home/photocoo/public_html/successful.php on line 35

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /home/photocoo/public_html/successful.php on line 36

Warning: Cannot modify header information - headers already sent by (output started at /home/photocoo/public_html/successful.php:35) in /home/photocoo/public_html/successful.php on line 67

I have 3 if statements when creating the thumbnails based on image extension. One is for jpeg thumbnails one is for gif thumbnails and one if for png thumbnails.

From what the warnings say it thinks its a jpeg file for some reason when it says photos/pele.goif is not a valied JPEG file. The if statements ask for the file extension so I am not sure why it goes to the jpeg condition. Any help would be great. Thanks.

[brendan2b]

Is it because the GD library doesnt allow .gif images to be created?

Can i create .jpeg thumbnails from .gif images? What would the function be instead of imagecreatefromjpeg if the file is a gif?

[MarkR]

Your error handling system is flawed as your application continues to run following a warning. This should not happen in a robust application.

You're calling imagecreatefromjpeg on a GIF file - something which is clearly not going to work. I recommend you write a function which calls the appropriate imagecreatefrom* function based on the image type - there is at least one example of this in the user-contributed documentation, but I can't vouch for its robustness (You may wish to review their code).

You can't create GIFs with GD, but you can load GIFs. This should not be a problem. You probably want your thumbnails to be PNG or JPEG anyway.

Cheers

Mark

[ClarkF1]

You can create gifs

From php.net:

Only supported in GD versions older than gd-1.6 and newer than gd-2.0.28. Read-only GIF support is available with PHP 4.3.0 and the bundled GD-library. Write support is avaliable since PHP 4.3.9 and PHP 5.0.1.

Check your PHP version and use the correct functions for gifs.

[brendan2b]

here is the code part of my thumbnail action page.

Im not sure why its calling imagecreatefromjpeg, because it shouldnt be going into that if statement.

Here

<?

session_start();
$username = $_SESSION['username'];
$imageName = $_SESSION['name'];

if ($_SESSION['logged']!==true) {
   header('location:loginfailed.php');

}

else {


//Name you want to save your file as
$save = 'th_'.$_SESSION['name'];
$thumb = "th_".$_SESSION['name'];
$file = $_SESSION['name'];


list($width, $height) = getimagesize($file) ;
$width2 = 160 / $width;
$height2 = $height * $width2;
$modwidth = 160;
$modheight = $height2;
$tn = imagecreatetruecolor($modwidth, $modheight) ;



// Here we are saving the .jpg, you can make this gif or png if you want
//the file name is set above, and the quality is set to 100%
if ($_SESSION['extension'] == "jpeg" || $_SESSION['extension'] == "jpg")
{  

$image = imagecreatefromjpeg($file) ;
imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ;
imagejpeg($tn, $save, 100);
}
if ($_SESSION['extension'] == "gif")
{ 
	$image = imagecreatefromgif($file) ;
imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ; 
imagejpeg($tn, $save, 100); 
}
if ($_SESSION['extesion'] == "png")
	{ 
  $image = imagecreatefrompng($file) ;
  imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width,     $height) ; 
  imagepng($tn, $save, 100);
}

[ClarkF1]

Try this:

switch ($_SESSION['extension'])
{
case "jpg":
case "jpeg":
$image = imagecreatefromjpeg($file) ;
imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ;
imagejpeg($tn, $save, 100);
break;

case "gif":
$image = imagecreatefromgif($file) ;
imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width, $height) ;
imagegif($tn, $save, 100);
break;

case "png":
$image = imagecreatefrompng($file) ;
  imagecopyresampled($tn, $image, 0, 0, 0, 0, $modwidth, $modheight, $width,     $height) ;
  imagepng($tn, $save, 100);
break;

default:
echo "Unknown image type";
break;
}

I'd also echo out the contents of $_SESSION['extension'] just to make sure it contains what you expect it to contain.