Thumbnailing first image in an array.

[Pikachu2000]

I thought I had this figured out, and I'm sure it's probably something very simple to someone who has been doing this for a while, but I'm just not experienced enough with PHP to get it to work. If anyone can tell me what the issue is with this code, I'd sure appreciate it.

if(isset($_POST['s1']))
{
	if(!empty($_FILES['images']['name'][0]))
	{
		while(list($key,$value) = each($_FILES['images']['name']))
		{
			if(!empty($value))
			{
				$NewImageName = $t."_".$value;
				copy($_FILES['images']['tmp_name'][$key], "re_images/".$NewImageName);

			$MyImages[] = $NewImageName;
		}
	}

	if(!empty($MyImages))
	{
		$ImageStr = implode("|", $MyImages);
		$Thumbnail = "thumb_".$MyImages[0];
		$tc = $MyImages[0];

	$filename = $_FILES['images']['name'][0];
	$temporary_name = $_FILES['images']['tmp_name'][0];
	$mimetype = $_FILES['images]']['type'][0];
	$filesize = $_FILES['images']['size'][0];

	switch($mimetype)
		{
		case "image/jpg" :
		case "image/jpeg" :
		case "image/pjpeg" :
			$i = imagecreatefromjpeg($temporary_name);
			break;
		case "image/gif" :
			$i = imagecreatefromgif($temporary_name);
			break;
		case "image/png" :
			$i = imagecreatefrompng($temporary_name);
			break;
		}
	var_dump ($_FILES ); echo ( "<br>\n");
	echo ("print " .  $i . "<br>\n");
	echo ("temp_name " . $temporary_name);
	unlink($temporary_name);

	$dest_x = 80;
	$dest_y = 60;

/* LINE 52 */		if(imagesx($i) > $dest_x || imagesy($i) > $dest_y)
			{
			if(imagesx($i) >= imagesy($i))
				{
				$thumb_x = $dest_x;
				$thumb_y = imagesy($i) * ($dest_x / imagesx($i));
				}
			else
				{
				$thumb_x = imagesx($i) * ( $dest_y / imagesy($i));
				$thumb_y = $dest_y;
				}
			}
		else
			{
			$dest_x = imagesx($i);
			$dest_y = imagesy($i);
			}
		imagecreatetruecolor($thumb_x, $thumb_y);
		imagecopyresampled($thumb, $i, 0, 0, 0, 0, $thumb_x, $thumb_y, imagesx($i), imagesy($i));
		imagejpeg($thumb, "thumbs/".$Thumbnail, 80);

	}
}

The following errors are what I'm getting:

string(10) "Array"
print
temp_name /Applications/MAMP/tmp/php/phpOKgqTF
Warning: imagesx(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 52

Warning: imagesy(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 52

Warning: imagesx(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 67

Warning: imagesy(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 68

Warning: imagecreatetruecolor() [function.imagecreatetruecolor]: Invalid image dimensions in /Applications/MAMP/htdocs/AddOffer.php on line 70

Warning: imagesx(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 71

Warning: imagesy(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 71

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 71

Warning: imagejpeg(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 72

[Installer]

Some quick things:

• Enquote your string literal array indexes ($FILES['images'], not $FILES[images]).
• Change var_dump($FILES) . "<br>\n"; to var_dump($FILES); echo "<br />\n";.
• $Thumbnail and $thumbnail aren't the same thing. PHP variable names are case-sensitive.
• You should use move_uploaded_file() instead of copy(), then work with the permanent file.
• What are $ImageStr and $tc for?
• You should use a consistent naming method (either "camelback" or "lower-case with underscore"). (n.b.: Names starting with upper-case are usually reserved for class names.)
• Telling which is "line 52" would save us time locating it.

[Pikachu2000]

I annotated the code to show where line 52 is. Sorry, I should have thought to do that when I posted it.

[Pikachu2000]

Okay, I enquoted the indices, changed the var_dump() and (thanks for pointing it out) changed the case of $thumbnail to $Thumbnail. $ImageStr is used to hold the array of filenames for a DB INSERT later in the script, and $tc was something I threw in earlier to see if it would be of any use in debugging. It is really just an unused variable for the moment..... Thanks for looking at this, its driving me nuts.

Here is the new var_dump() result:

array(1) { ["images"]=> array(5) { ["name"]=> array(10) { [0]=> string(24) "img_0172_unsaturated.jpg" [1]=> string(0) "" [2]=> string(0) "" [3]=> string(0) "" [4]=> string(0) "" [5]=> string(0) "" [6]=> string(0) "" [7]=> string(0) "" [8]=> string(0) "" [9]=> string(0) "" } ["type"]=> array(10) { [0]=> string(10) "image/jpeg" [1]=> string(0) "" [2]=> string(0) "" [3]=> string(0) "" [4]=> string(0) "" [5]=> string(0) "" [6]=> string(0) "" [7]=> string(0) "" [8]=> string(0) "" [9]=> string(0) "" } ["tmp_name"]=> array(10) { [0]=> string(36) "/Applications/MAMP/tmp/php/php8P9QuP" [1]=> string(0) "" [2]=> string(0) "" [3]=> string(0) "" [4]=> string(0) "" [5]=> string(0) "" [6]=> string(0) "" [7]=> string(0) "" [8]=> string(0) "" [9]=> string(0) "" } ["error"]=> array(10) { [0]=> int(0) [1]=> int(4) [2]=> int(4) [3]=> int(4) [4]=> int(4) [5]=> int(4) [6]=> int(4) [7]=> int(4) [8]=> int(4) [9]=> int(4) } ["size"]=> array(10) { [0]=> int(189666) [1]=> int(0) [2]=> int(0) [3]=> int(0) [4]=> int(0) [5]=> int(0) [6]=> int(0) [7]=> int(0) [8]=> int(0) [9]=> int(0) } } }

Everything under it stayed the same. Should I update the code in the OP to reflect the changes you suggested I make?

[Installer]

Sorry, I haven't been able to do much with it beyond that (I had a little trouble even getting my test form to upload correctly to your script at first, then had to shovel some snow 🙂 ). If you want to post the revised code, I'll be able to look at it off and on. Then among all of us I'm sure we'll figure it out..

[Pikachu2000]

Not a problem. I appreciate whatever help I can get. I got thrust into this project, and really hadn't done much work with PHP at all before this. At least by the time I get it where it needs to be, I should be fairly proficient with the language.....

I re-pasted the code with the changes, so it is currently what I have on my box here. BTW, I hate snow. Fortuantely, it snows about 2 times a year here in Dallas.

[Installer]

But I hear it sometimes rains a lot in Dallas.

In your imagecreatefrom...() statements you pass the name of the file, but not the path to it. That's why the image resource you try to use later is invalid. You'll need to concatenate the path to the temp upload directory to the file's temp name and pass that to the function.

Edit: Scratch that. I guess the temp name contains the path.

Are the files being copied to the new directory?

Frankly, I'm still stuck with trying to get my test upload script to work. Maybe you or someone can see if my code for it is wrong (not to hijack your thread):

echo '<form enctype="multipart/form-data" method="post" action="uploadtest.php">' . "\n";
$ul_total = 3;
for ($x = 1; $x <= $ul_total; $x++) {
    echo '<input name="s1[]" type="file" /><br />' . "\n";
}
echo '<input type="hidden" name="MAX_FILE_SIZE" value="900000" />' . "\n";
echo '<input type="submit" name="submit" value="submit" />' . "\n";
echo '</form>' . "\n";

[Pikachu2000]

Yeah, in the spring it rains a lot with the storms we get.

The path that echos from the $temporary_name variable isn't a valid file path? When I echo it, it shows /Applications/MAMP/tmp/php/<insert some randomly generated hash here>. What I do notice, is that there is no corresponding file in that directory, even with the unlink() statement commented out. I set permissions to 777 on the directory, with no change in the results. Is this normal, or did I miss a step somewhere?

[Pikachu2000]

Hold everything. I just found an extra bracket in the line declaring the $mimetype variable. Took that out and things have changed a little bit. I've reposted the PHP and the resulting errors to save scrolling up and down this page. I think we're getting closer to figuring this out.....

if(isset($_POST['s1']))
{
	if(!empty($_FILES['images']['name'][0]))
	{
		while(list($key,$value) = each($_FILES['images']['name']))
		{
			if(!empty($value))
			{
				$NewImageName = $t."_".$value;
				copy($_FILES['images']['tmp_name'][$key], "re_images/".$NewImageName);

			$MyImages[] = $NewImageName;
		}
	}

	if(!empty($MyImages))
	{
		$ImageStr = implode("|", $MyImages);
		$Thumbnail = "thumb_".$MyImages[0];
		$tc = $MyImages[0];

	$filename = $_FILES['images']['name'][0];
	$temporary_name = $_FILES['images']['tmp_name'][0];
	$mimetype = $_FILES['images']['type'][0];
	$filesize = $_FILES['images']['size'][0];

	switch($mimetype)
		{
		case "image/jpg" :
		case "image/jpeg" :
		case "image/pjpeg" :
			$i = imagecreatefromjpeg($temporary_name);
			break;
		case "image/gif" :
			$i = imagecreatefromgif($temporary_name);
			break;
		case "image/png" :
			$i = imagecreatefrompng($temporary_name);
			break;
		}
	var_dump ($_FILES ); echo ( "<br>\n");
	echo ("<br>\$temporary_name= " . $temporary_name . "<br>\n");
	echo ("\$filename= " . $filename . "<br>\n");
	echo ("\$mimetype= " . $mimetype . "<br>\n");
	echo ("\$filesize= " . $filesize . "<br>\n");
	echo ("\$i= " . $i . "<br>\n");
	//unlink($temporary_name);

	$dest_x = 80;
	$dest_y = 60;

	if(imagesx($i) > $dest_x || imagesy($i) > $dest_y)
		{
		if(imagesx($i) >= imagesy($i))
			{
			$thumb_x = $dest_x;
			$thumb_y = imagesy($i) * ($dest_x / imagesx($i));
			}
		else
			{
			$thumb_x = imagesx($i) * ( $dest_y / imagesy($i));
			$thumb_y = $dest_y;
			}
		}
	else
		{
		$dest_x = imagesx($i);
		$dest_y = imagesy($i);
		}
	imagecreatetruecolor($thumb_x, $thumb_y);
/* LINE 74 */		imagecopyresampled($thumb, $i, 0, 0, 0, 0, $thumb_x, $thumb_y, imagesx($i), imagesy($i));
		imagejpeg($thumb, "thumbs/".$Thumbnail, 80);

	}
}

These are the errors and debugging output now wrote:

array(1) { ["images"]=> array(5) { ["name"]=> array(10) { [0]=> string(24) "img_0172_unsaturated.jpg" [1]=> string(0) "" [2]=> string(0) "" [3]=> string(0) "" [4]=> string(0) "" [5]=> string(0) "" [6]=> string(0) "" [7]=> string(0) "" [8]=> string(0) "" [9]=> string(0) "" } ["type"]=> array(10) { [0]=> string(10) "image/jpeg" [1]=> string(0) "" [2]=> string(0) "" [3]=> string(0) "" [4]=> string(0) "" [5]=> string(0) "" [6]=> string(0) "" [7]=> string(0) "" [8]=> string(0) "" [9]=> string(0) "" } ["tmp_name"]=> array(10) { [0]=> string(36) "/Applications/MAMP/tmp/php/phpa1s9wm" [1]=> string(0) "" [2]=> string(0) "" [3]=> string(0) "" [4]=> string(0) "" [5]=> string(0) "" [6]=> string(0) "" [7]=> string(0) "" [8]=> string(0) "" [9]=> string(0) "" } ["error"]=> array(10) { [0]=> int(0) [1]=> int(4) [2]=> int(4) [3]=> int(4) [4]=> int(4) [5]=> int(4) [6]=> int(4) [7]=> int(4) [8]=> int(4) [9]=> int(4) } ["size"]=> array(10) { [0]=> int(189666) [1]=> int(0) [2]=> int(0) [3]=> int(0) [4]=> int(0) [5]=> int(0) [6]=> int(0) [7]=> int(0) [8]=> int(0) [9]=> int(0) } } }

$temporary_name= /Applications/MAMP/tmp/php/phpa1s9wm
$filename= img_0172_unsaturated.jpg
$mimetype= image/jpeg
$filesize= 189666
$i= Resource id #7

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 74

Warning: imagejpeg(): supplied argument is not a valid Image resource in /Applications/MAMP/htdocs/AddOffer.php on line 75

[Pikachu2000]

Installer wrote:

But I hear it sometimes rains a lot in Dallas.

In your imagecreatefrom...() statements you pass the name of the file, but not the path to it. That's why the image resource you try to use later is invalid. You'll need to concatenate the path to the temp upload directory to the file's temp name and pass that to the function.

Edit: Scratch that. I guess the temp name contains the path.

Are the files being copied to the new directory?

Frankly, I'm still stuck with trying to get my test upload script to work. Maybe you or someone can see if my code for it is wrong (not to hijack your thread):

echo '<form enctype="multipart/form-data" method="post" action="uploadtest.php">' . "\n";
$ul_total = 3;
for ($x = 1; $x <= $ul_total; $x++) {
    echo '<input name="s1[]" type="file" /><br />' . "\n";
}
echo '<input type="hidden" name="MAX_FILE_SIZE" value="900000" />' . "\n";
echo '<input type="submit" name="submit" value="submit" />' . "\n";
echo '</form>' . "\n";

More like this here:

echo '<form enctype="multipart/form-data" method="post" action="uploadtest.php">' . "\n";
$ul_total = 3;
for ($x = 1; $x <= $ul_total; $x++) {
    echo '<input name="images[]" type="file" /><br />' . "\n";
}
echo '<input type="hidden" name="MAX_FILE_SIZE" value="900000" />' . "\n";
echo '<input type="submit" name="s1" value="submit" />' . "\n";
echo '</form>' . "\n";

[Pikachu2000]

Installer,

I got it all figured out this morning (after echo()ing every variable in the bloody script). However, if you hadn't pointed out the errors you did, I would probably be sitting here with a PowerMac hanging by a cord out the window by now. I hate, more than anything, having to go through someone else's work and figure it out then fix it.

Thanks for taking the time to look the code over, it sure was a big help!