Assistance with Drop Down List

[wlaneer]

I need some assistance with coding a drop down list. I am new to this stuff

Im missing something....

<?
$id= $_REQUEST['city'];
$cities = getCities ($city_id);
require_once("includes/init.inc");
?>
<form method="post" action="city.php?city_id=<?$id['city_id']?>">
<select name="city">
<?
foreach ($cities as $city){
echo <<<CITIES
<option value="{$city['city_id']}">{$city['city_name']}</option>;
CITIES;
}
?>
</select>
<input type="submit" name="submit" value="Go">
</form>
<?
function getCities ($city_id){
global $db;
$sql = "SELECT * FROM cities ORDER BY 'city_name' ASC";
return $db->queryAllRows($sql);
}
?>

Any and all assistance is appreciated.

Thanks

[Roger_Ramjet]

Learn to use the php tags, it makes it a lot easier for proplr to help you

<?
$id= $_REQUEST['city'];
$cities = getCities ($city_id);
require_once("includes/init.inc");
?>
<form method="post" action="city.php?city_id=<?$id['city_id']?>">
<select name="city">
<?
foreach ($cities as $city){
echo <<<CITIES
<option value="{$city['city_id']}">{$city['city_name']}</option>;
CITIES;
}
?>
</select>
<input type="submit" name="submit" value="Go">
</form>
<?
function getCities ($city_id){
global $db;
$sql = "SELECT * FROM cities ORDER BY 'city_name' ASC";
return $db->queryAllRows($sql);
}
?>

[Roger_Ramjet]

First thing you are doing wrong is to use the clumsy HEREDOC quoting syntax, not necessary and in my experience it never works anyway.

<?
foreach ($cities as $city) {
echo '<option value="' . $city['city_id'] . '">' . $city['city_name'] . '</option>';
}
?>

Using the single quoted string syntax forces you to concatenate your vars like that which leads to much more legible code where simple typos are easy to spot so your code is that much easier to debug.

[wlaneer]

Thanks, I am brand new at this and I am learning. This is what I would like to do:

I have created a drop down list of cities from the database. I want to select the city and pass the city_id from the selected city to a page that gathers information for that city.

I would like some guidance on how I can accomplish this task. If anyone has some links to tutorials I would appreciate that as well.

Thanks so much.

[leatherback]

Hi,
The lines that roger gave you should do the trick.

It is a bit dificult to assess where you need the help.

• Does the form now form properly (e.g., data in the dropdown, with ID and label?
• Can you get it to submit?
• Can you retrieve the selected ID from the $_POST[] array?
• Can you query the database based on the selected variable?

[wlaneer]

I get the form to populate with the lables; however, Im not sure how to code it so that when I press "go" the city id from the query passes to the page city.php.

I had the form submit to the same page, and request the id, however I got an error stating that header info had already been sent, so I would rather start from scratch so I can understand, vs just coping code and not knowing what is going on.

here is the current code on the page:

<?
$cities = getCities ($city_id);
?>
<form method="post" action="city_list.php">
<select name="city">
<?
foreach ($cities as $city){
echo '<option value="'.$city['city_id'] .'">'.$city['city_name'].'</option>';
}
?>
</select>
<input type="submit" name="submit" value="Go">
</form>
<?
function getCities ($city_id){
global $db;
$sql = "SELECT * FROM cities ORDER BY 'city_name' ASC";
return $db->queryAllRows($sql);
}
?>

It creates and populates the drop down form with the name of the city. now I need the city id to pass to another page called city.php.

Thanks to all for helping someone who is trying to learn.

🙂