How to remove link breaks?

scialom

Yes I know it should be easy - but it doesn't work:

I have this code:

$msg = "Hello,
              Nice to be here!";

          $msg=str_replace("\n","",$msg);

          echo "<script language=\"JavaScript\" type=\"text/javascript\">
          alert ($msg);
          </script>

Still I have the line breaks so the javascript can't run.

Any ideas?
Assaf

NogDog

You need to quote the value in the JS alert() call:

<?php
$msg = "Hello,
Nice to be here!";

$msg=str_replace("\n"," ",$msg);

echo "<script language=\"JavaScript\" type=\"text/javascript\">
alert ('$msg');
</script>";
?>

scialom

Thanks, but it is the same problem.
When I view the source it looks like:
alert ('Hello,
Nice to be here!')

which is no good 🙁

NogDog

Maybe you're using a WinDOS editor (such as Notepad) that uses "\r\n" for newlines?

suntra

Simply remove \n AND \r...

$newString = str_replace(array("\n", "\r"), '', $oldString);

ClarkF1

You can use trim()

suntra

trim() won't remove line breaks inside a string, only at the left and right ends, not "in the middle" !

ClarkF1

Whoops........I just realised reading through the thread again. Was more concerned about whether a tree was about to come through the window.

madwormer2

VERY windy here too.

Anyway, if you want the newlines to display in the alert message, you need to replace them with \n.

So, the above replace code modified would look like:

$newString = str_replace(array("\n", "\r"), array('\n','\r'), $oldString);

I know that looks bizarre, but it works.