[RESOLVED] error message

[philweb]

Hi

I found this script on the web and all being well it should work. It is an resize image script to work with an upload file script via the include() function. But I keep getting an error message and I am unable to upload a file, (the file is a jpg called test) would anyone be so kind as to have a look at the scripts and try and determine what might be causing the error.

Here is the error:
Warning: imagejpeg() [function.imagejpeg]: Unable to open 'http://www.mysite.co.uk/php_solutions/test.JPG_thb.jpg' for writing in /home/philweb/public_html/php_solutions/create_thumb.inc.php on line 69

line 69 is this
$success = imagejpeg($thumb, THUMBS_DIR.$name.'_thb.jpg', 100);

Thanks in advance,

Phil

Here are the two complete scripts.

// define constants
  define('THUMBS_DIR', 'http://www.mysite.co.uk/php_solutions/');
  define('MAX_WIDTH', 120);
  define('MAX_HEIGHT', 90);

  // process the uploaded image
  if (is_uploaded_file($_FILES['image']['tmp_name'])) {
    $original = $_FILES['image']['tmp_name'];
    // begin by getting the details of the original
    list($width, $height, $type) = getimagesize($original);
	// calculate the scaling ratio
    if ($width <= MAX_WIDTH && $height <= MAX_HEIGHT) {
      $ratio = 1;
      }
    elseif ($width > $height) {
      $ratio = MAX_WIDTH/$width;
      }
    else {
      $ratio = MAX_HEIGHT/$height;
      }
	// strip the extension off the image filename
	$imagetypes = array('/\.gif$/', '/\.jpg$/', '/\.jpeg$/', '/\.png$/');
    $name = preg_replace($imagetypes, '', basename($_FILES['image']['name']));

// create an image resource for the original
switch($type) {
  case 1:
    $source = @ imagecreatefromgif($original);
    if (!$source) {
      $result = 'Cannot process GIF files. Please use JPEG or PNG.';
      }
    break;
  case 2:
    $source = imagecreatefromjpeg($original);
    break;
  case 3:
    $source = imagecreatefrompng($original);
    break;
  default:
    $source = NULL;
    $result = 'Cannot identify file type.';
  }
// make sure the image resource is OK
if (!$source) {
  $result = 'Problem copying original';
  }
else {
  // calculate the dimensions of the thumbnail
  $thumb_width = round($width * $ratio);
  $thumb_height = round($height * $ratio);
  // create an image resource for the thumbnail
  $thumb = imagecreatetruecolor($thumb_width, $thumb_height);
  // create the resized copy
  imagecopyresampled($thumb, $source, 0, 0, 0, 0, $thumb_width, $thumb_height, $width, $height);
  // save the resized copy
  switch($type) {
    case 1:
      if (function_exists('imagegif')) {
        $success = imagegif($thumb, THUMBS_DIR.$name.'_thb.gif');
        $thumb_name = $name.'_thb.gif';
	    }
      else {
        $success = imagejpeg($thumb, THUMBS_DIR.$name.'_thb.jpg', 50);
	    $thumb_name = $name.'_thb.jpg';
	    }
      break;
    case 2:
      $success = imagejpeg($thumb, THUMBS_DIR.$name.'_thb.jpg', 100);
      $thumb_name = $name.'_thb.jpg';
      break;
    case 3:
      $success = imagepng($thumb, THUMBS_DIR.$name.'_thb.png');
      $thumb_name = $name.'_thb.png';
    }
	if ($success) {
	  $result = "$thumb_name created";
	  }
	else {
	  $result = 'Problem creating thumbnail';
	  }
  // remove the image resources from memory
  imagedestroy($source);
  imagedestroy($thumb);
  }
}

// define a constant for the maximum upload size
define ('MAX_FILE_SIZE', 51200);

if (array_key_exists('upload', $_POST)) {
  // define constant for upload folder
  define('UPLOAD_DIR', 'http://www.mysite.co.uk/php_solutions/');
  // replace any spaces in original filename with underscores
  // at the same time, assign to a simpler variable
  $file = str_replace(' ', '_', $_FILES['image']['name']);
  // convert the maximum size to KB
  $max = number_format(MAX_FILE_SIZE/1024, 1).'KB';
  // create an array of permitted MIME types
  $permitted = array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/png');
  // begin by assuming the file is unacceptable
  $sizeOK = false;
  $typeOK = false;

  // check that file is within the permitted size
  if ($_FILES['image']['size'] > 0 && $_FILES['image']['size'] <= MAX_FILE_SIZE) {
    $sizeOK = true;
	}

  // check that file is of an permitted MIME type
  foreach ($permitted as $type) {
    if ($type == $_FILES['image']['type']) {
      $typeOK = true;
	  break;
	  }
	}

  if ($sizeOK && $typeOK) {
    switch($_FILES['image']['error']) {
	  case 0:
		include('./create_thumb.inc.php');
	    break;
	  case 3:
		$result = "Error uploading $file. Please try again.";
	  default:
        $result = "System error uploading $file. Contact webmaster.";
	  }
    }
  elseif ($_FILES['image']['error'] == 4) {
    $result = 'No file selected';
	}
  else {
    $result = "$file cannot be uploaded. Maximum size: $max. Acceptable file types: gif, jpg, png.";
	}
  }

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>File upload</title>
</head>

<body>
<?php
// if the form has been submitted, display result
if (isset($result)) {
echo "<p><strong>$result</strong></p>";
}
?>
<form action="" method="post" enctype="multipart/form-data" name="uploadImage" id="uploadImage">
<p>
<label for="image">Upload image:</label>
<input type="hidden" name="MAX_FILE_SIZE" value="<?php echo MAX_FILE_SIZE; ?>" />
<input type="file" name="image" id="image" />
</p>
<p>
<input type="submit" name="upload" id="upload" value="Upload" />
</p>
</form>
</body>
</html>

[kkobashi]

Do you have permissions to write to that directory?

[bradgrafelman]

You can't write files across HTTP (ok technically there's a way, but it doesn't apply here)... use the local file path (either absolute, e.g. '/home/username/path/to/dir/' or a relative path, e.g. 'path/to/dir/').

[philweb]

Hi Brad,

Thanks for that, I changed it to what you said and it works! Thanks very much.

Now all I have to do is get the image url inserted into a db, is it easy to join scripts together?

Thanks again, I will mark this up as resolved upon your reply.

Phil

[bradgrafelman]

philweb wrote:

is it easy to join scripts together?

Erm, I'm not quite sure what you mean by this.

Are you asking if you can execute one script within another? If so, that's an easy answer - yes, using something like [man]include[/man], [man]require[/man], or their '_once' counterparts.

[philweb]

Hi

What I mean is I now have one script that uploads an image and is resized and another that is uploaded and placed into th db.Is it possible to combine the two to have the image resized, uploaded and inserted into th db? The first resize script is as above and works, the one below uploads and inserts the image into the db along with a few other bits of info.
Thanks,

Phil

// This page allows users to upload files to the server.

// Set the page title and include the HTML header.
$page_title = 'Upload a File';


if (isset($_POST['submit'])) { // Handle the form.

require_once ('../mysql_connect.php'); // Connect to the database.


// Function for escaping and trimming form data.
function escape_data ($data) { 
	global $dbc;
	if (ini_get('magic_quotes_gpc')) {
		$data = stripslashes($data);
	}
	return mysql_real_escape_string (trim ($data), $dbc);
} // End of escape_data() function.
// First name
if (!empty($_POST['first_name'])) {
	$fn = escape_data($_POST['first_name']);
} else {
	$fn = '';
}
// Check for a description (not required).
if (!empty($_POST['description'])) {
	$d = escape_data($_POST['description']);
} else {
	$d = '';
}
$picture_url = "family_pics/images/".$_FILES['upload']['name'];

// Add the record to the database.
$query = "INSERT INTO family (first_name, picture_url,  description, registration_date) VALUES ('$fn', '$picture_url','$d', NOW())";
$result = @mysql_query ($query);

if ($result) {


	// Create the file name.
	$extension = explode ('.', $_FILES['upload']['name']);
	$uid = mysql_insert_id(); // Upload ID
	$filename = $_FILES['upload']['name'];

	// The file
$filename = $_FILES['upload']['name'];


	// Move the file over.
	if (move_uploaded_file($_FILES['upload']['tmp_name'], "../family_pics/images/$filename")) {
		echo '<p>The file has been uploaded!</p>';
	} else {
		echo '<p><font color="red">The file size is too big!.</font></p>';

		// Remove the record from the database.
		$query = "DELETE FROM family WHERE upload_id = $uid";
		$result = @mysql_query ($query);
	}


} else { // If the query did not run OK.
	echo '<p><font color="red">Your submission could not be processed due to a system error. We apologize for any inconvenience.</font></p>'; 
}



@mysql_close(); // Close the database connection.

} // End of the main Submit conditional.