Pull random file(image) from directory

Paul_Ferrie

Hi guys,

I am trying to get one of x amount of files from a dir.
The code below works but sometimes it returns empty.

$files = array();
		if ($handle2 = opendir("../media/random")) {
    		while (false !== ($file = readdir($handle2))) {
				if ($file != "." && $file != "..") {
					$files[] = $file;		
				}	
			}
		closedir($handle2);
	}	
	$getRand = mt_rand(1, count($files));
	for($i = 0 ; $i < count($files) ; $i++) {
   		$file2 = $files[$getRand];	
	}
	$output .="&files=".$file2;
	echo $output;

Cany oneone see why it would return empty??

thanks

leatherback

Not sure. you might want to put some else statements in there, so that if the routine fails, you know where it fails.

Furthermore this:
$getRand = mt_rand(1, count($files));
for($i = 0 ; $i < count($files) ; $i++) {
$file2 = $files[$getRand];

}

Does not really make sense. Why the for loop? I presume it returns 1 file?

Paul_Ferrie

Does not really make sense. Why the for loop? I presume it returns 1 file?

Am working trial and error here. If you know a better/proper way then please let me know.

Files in the dir are layed out like:
1_random.jpg
2_random.jpg
3_random.jpg and so on...

$file2 outputs the file name that is pulled.

leatherback

Try:

// this is just an example var, you will use your own $maxfiles 
$maxfiles = 3

// Find files. I assumed this works
$files = array();
        if ($handle2 = opendir("../media/random")) {
            while (false !== ($file = readdir($handle2))) {
                if ($file != "." && $file != "..") {
                    $files[] = $file;        

                }    

            }
        closedir($handle2);
    }
  else
    {
    echo "Couldnt open dir";
    }

// Create a random list of files
$showfiles = array();
while(array_count_values($files) < $maxfiles-1)
  {
  $thisRand = mt_rand(1, count($files));
  $showfiles[$thisRand] = $files[$thisRand];
  }

// and create output
foreach($showfiles as $filename)
  {
  echo $filename; 
  }

NogDog

$files = glob('../media/random/*.*');
shuffle($files);
$randFile = basename($files[0]);

Note: if you want to keep the relative path with the filename, just get rid of the call to basename()

leatherback

shuffle($files);

cool!

🙂

MarkR

My approach:

Rename the files 0.jpg, 1.jpg etc.
Pick a random number
Use that as the filename.

This is much simpler and more efficient.

Mark