[RESOLVED] Voting Form trouble...

[middleman666]

hey people,

I've written the following code and for some reason it doesn't seem to be executing when the form is submitted. It's confusing me as I have used the same method else where and it works fine.

<?php 
include('dbconnect.php');
$artistid = $_GET['id'];
?>
<form action="<?php $_SERVER['PHP_SELF']; ?>" method="post" name="vote">
<span class="listHeadings">VOTE FOR THIS TRACK </span>
<br>
<input type="radio" name="vote" value="1">
1
<input type="radio" name="vote" value="2">
2
<input type="radio" name="vote" value="3">
3
<input type="radio" name="vote" value="4">
4
<input type="radio" name="vote" value="5">
5
<INPUT TYPE="hidden" NAME="submitted" VALUE="yes">
<input class="vote" type="submit" name="action" value="VOTE">
<?php if (!empty($_GET[message])){ echo '<br>'.$_REQUEST[message]; } ?>
</form>

<?php
//Has Form Been Submitted?
if (isset($_POST['action']) && ($_POST['submitted']== 'yes')) {  

  // Have all Fields been filled out?
  if (!$_POST['vote']) { 
    $message = "Please select a number first.";   

    print "<script>window.location.href='$url_this?message=$message'</script>";  

    exit; 
  }

  // Has user already voted?
  $hostname = gethostbyaddr($_SERVER['REMOTE_ADDR']); 
  $IP = GetHostByName($hostname);
  $result = mysql_query("select * from Vote where userIP = $IP and artistID = $artistid") 
                 or die ("Could not vote at this time");

  if (mysql_num_rows($result)) {
    $message = "You have already voted.";   

    print "<script>window.location.href='$url_this?message=$message'</script>";  

    exit; 
  }
  else {
    $ArtistID = $artistid;
    $Vote = $_POST['vote'];
    $IP = GetHostByName($hostname);
  }

  //Add entry to database
  mysql_query("INSERT INTO Vote SET 
    artistID='$ArtistID',
    userIP='$IP',
    vote='$Vote'
  "); 

  //Succesful
  $message = "Thanks for your vote!";
  print "<script>window.location.href='$url_this?message=$message'</script>";
}
?>

Can anyone see where I'm going wrong?

Thanks.

[Houdini]

This needs changed

// Has user already voted?
  $hostname = gethostbyaddr($_SERVER['REMOTE_ADDR']);
  $IP = GetHostByName($hostname); 

to this

// Has user already voted?
  $hostname = gethostbyaddr($_SERVER['REMOTE_ADDR']);
  $IP = gethostbyname($hostname);

[middleman666]

hey,
thanks for the reply.

I changed what you said, but I'm still not having any luck.
When I submit the form without selecting a vote number, the form does nothing when it should be saying 'Please select a number first.'
And when I select a vote number and submit, I get the 'or die' message of 'Could not vote at this time'.

Is there a different way of checking for whether a radio field has been filled out?

Thanks.

[middleman666]

OK, I've changed some other things so the code now looks like the following:

<?php 
include('dbconnect.php'); 
$artistid = $_GET['id']; 
?> 

<form name="vote" method="post" action="<?php $_SERVER['PHP_SELF']; ?>">
<span class="listHeadings">VOTE FOR THIS TRACK </span>
<br>
<input type="radio" name="vote" value="1">
1
<input type="radio" name="vote" value="2">
2
<input type="radio" name="vote" value="3">
3
<input type="radio" name="vote" value="4">
4
<input type="radio" name="vote" value="5">
5
<INPUT TYPE="hidden" NAME="submitted" VALUE="yes">
<input class="vote" type="submit" name="action" id="action" value="VOTE">
<?php if (!empty($_GET[message])){ echo '<br>'.$_REQUEST[message]; } ?>
</form>

<?php
//Has Form Been Submitted?
if (isset($_POST['vote']) && ($_POST['submitted']== 'yes')) {  

  // Have all Fields been filled out?
  if (!$_POST['action']) { 
    $message = "Please select a number first.";   

    print "<script>window.location.href='$url_this?menu=home&id=$artistid&message=$message'</script>";  

    exit; 
  }

  // Has user already voted?
  $hostname = gethostbyaddr($_SERVER['REMOTE_ADDR']); 
  $IP = gethostbyname($hostname); 
  $result = mysql_query("select * from Vote where userIP = \"%$IP%\" and artistID = \"%$artistid%\"") 
            or die ("Could not vote at this time");

  if (mysql_num_rows($result)) {
    $message = "You have already voted.";   

    print "<script>window.location.href='$url_this?menu=home&id=$artistid&message=$message'</script>";  

    exit; 
  }
  else {
    $ArtistID = $artistid;
    $Vote = $_POST['vote'];
    $IP = gethostbyname($hostname); 
  }

  //Add entry to database
  mysql_query("INSERT INTO Vote SET 
    artistID='$ArtistID',
    userIP='$IP',
    vote='$Vote'
  "); 

  //Upload Succesful
  $message = "Thanks for your vote!";
  print "<script>window.location.href='$url_this?menu=home&id=$artistid&message=$message'</script>";
}
?>

Now, I still dont get a message when the forms not filled out, but when I fill it out and submit, it does add to the database, but also, I can submit the form multiple times - I want to be able to check to the database to see if the IP and artistID has already been submitted and if it has then I don't want the user to be able to vote again.

Any thoughts?

thanks.

[middleman666]

sorry... I changed this:

  if (mysql_num_rows($result)) { 
    $message = "You have already voted.";    

    print "<script>window.location.href='$url_this?menu=home&id=$artistid&message=$message'</script>";   

    exit; 
  } 
  else { 
    $ArtistID = $artistid; 
    $Vote = $_POST['vote']; 
    $IP = gethostbyname($hostname); 
  } 

to this:

  if (mysql_num_rows($result)) {
    $ArtistID = $artistid;
    $Vote = $_POST['vote'];
    $IP = gethostbyname($hostname); 
  }
  else {
    $message = "You have already voted.";   

    print "<script>window.location.href='$url_this?menu=home&id=$artistid&message=$message'</script>";  

    exit; 
  }

And now the multiple voting is sorted.

Only problem I have now is the message that says that the form has not been filled out.

EDIT: sorry, I've been a mis-typing fool. I accidently changed:

//Has Form Been Submitted? 
if (isset($_POST['action']) && ($_POST['submitted']== 'yes')) {   

  // Have all Fields been filled out? 
  if (!$_POST['vote']) { 

to this..

//Has Form Been Submitted? 
if (isset($_POST['vote']) && ($_POST['submitted']== 'yes')) {   

  // Have all Fields been filled out? 
  if (!$_POST['action']) { 

it should be the first one.

Thanks for the help anyway.
resolved.

[middleman666]

I also got rid of the % from the query. And I put the multiple vote code back to the way it originaly was.