[RESOLVED] if test filetype extension

oaskedal

Hi!

I'm all new in php and I struggle with this if-test in my upload-form. I'd like it to check the following:
1) If the fileextension is either "gif", "jpg" or "png" it should do nothing (just prosceed as if it's ok.)
2) If it isn't one of these three file extensions, it should give the user an errormessage (e.g. if the user tries to upload an doc or pdf file or something)

How should the expression be inside the if-test to check all three fileextensions.. ?

$gif = "gif";
$jpg = "jpg";
$png = "png";

if ($exten!=$gif||$jpg||$png) {   // $exten is the variable with the extension
	  $errormessage .= 'You didn't attach an imagefile (jpg,gif or png)<br>';
		$fault = true;
		}

}

wilku

Try:

$allowed = array("gif","jpg","png");
if (!in_array($exten,$allowed) {   // $exten is the variable with the extension
      $errormessage .= 'You didn\'t attach an imagefile (jpg,gif or png)<br>';
        $fault = true;
        }

rgermain

To make the code more easily read and easy to follow...

Try formatting if statements as such:

<?
if ($somevariable == "somevalue")) 
{
         //INDENTED CODE HERE 
} 
else
{
       //INDENTED CODE HERE
      if($somevariable == "somevalue")
      {
              //INDENTED CODE
      }
      else
      {
            //INDENTED CODE
      }
}
?>

Not a requirement. Just a simple suggestion. 🙂

Rodney_H_

Another way is to use the switch() statement/control structure.

And, even another way would be to create an array and see if the extension is in that array (or not)...

THis example presupposes that the $exten variable is already set:

<?php
// create an array of acceptable file types for your app:
$acceptable_files = array('gif', 'jpg', 'png');

if(!in_array($exten, $acceptable_files))
{
	// trigger error here:
	die('no way!');
}

else
{
	// OK to proceed:
	echo 'cool....';
}
?>

oaskedal

Thank you all!

Now it works fine :-)

bradgrafelman

Don't forget to mark this thread resolved.