'exactract()'ing functions, classes, etc. into a template system

[Sykoi]

Well I ditched my idea to load, store, and eval() templates from files as it has some serious security issues, and decided to go with a much simpler approach:

class template {
	public $theme = "default";
	public $theme_dir = "themes/";
	private $templates = array();
	private $vars = array();
	private $errors = array();
	private $cwd = "";


function template() {
	$this->cwd = getcwd();
}

function assign($var_name, $var_value) {
	if (!get_magic_quotes_gpc()) {
		$var_value = addslashes(&$var_value);
	}
	$var_value = str_replace(";","",$var_value);
	$var_value = preg_replace("/[^A-Za-z0-9_-]\n\t\r/","",$var_value);
	$this->vars[$var_name] = $var_value;
}

function display($file) {
	//chdir("../".$this->theme_dir);
	//Takes about 20 milliseconds to chdir
	$filename = $this->theme_dir.$this->theme."/".$file.".tpl.php"; //Add "../". to test locally
	extract($this->vars);
	ob_start();
	include($filename);
	$contents = ob_get_contents();
	ob_end_clean();
	print $contents;
	return 1;
}
}

However, I'm having some troubles... How can I access functions from this class inside my templates? I obviously can't extract() the class itself seeing as its not an array... And I can't exactly use $this-> or $template, seeing as ... Well, I honestly have no idea why I can't do this.

So whats a solution? What about accessing other classes? What about accessing just a function, completely outside of a class?

[Weedpacket]

$thingy = new template();

$thingy->assign('name', 'value');

What's the issue, again?

There are things called static methods; which are called in the form "classname::methodname()", but you won't be able to use that here because class methods can't refer to $this.

[Sykoi]

Uhh... I'm the one who wrote this, so I know how to use it - what I don't know, however, is how to pass an object into the variable array so I can access it inside a template... Extract, and $var = $this->vars, both change the object into the literal string "object".

My question is, HOW do I access an object using the method shown above, since any attempt to pass an object results in it being a literal string instead of an actual object.

I really don't want to write another regex/eval parser, as thats what I'm trying to get away from, seeing as its not only extremely insecure, but its also incredibly slow. (199ms for 100 templates with eval vs 40ms for 100 templates with current method)

Edit: I'm a moron... I had forgotten to remove the input parser from assign, after I had removed eval... Fixed! 🙂

[Weedpacket]

Sykoi wrote:

Edit: I'm a moron... I had forgotten to remove the input parser from assign, after I had removed eval... Fixed!

Ah, that explains my confusion, too. "Does he mean - no, those are strings because he's quoting them and all..."