Problem With Updating Table

[tigomark]

Hello,

I need another set of eyes on this project I am working on. I am trying to update a table for a video rental script. On the selection page all variables work, I see them they all have values so on that side I am pretty sure I am ok.

When I try to insert the values into the table the table woun't "execute my querry".

Here is the insert code:

$db_name = "Name";

$table_name = "temp_db";

$connection = @mysql_connect("$host", "$username", "$password") or
die("Couldn't connect.");

$db = @mysql_select_db($db_name, $connection) or die("Couldn't select database.");

$sql = "
INSERT INTO $table_name
(id, Title, Genre, Decade, Director, Actor1First, Actor1Last,
Actor2First, Actor2Last, Actor3First, Actor3Last, NewRelease,
Description, ImageName, EmployeeName, OwnersEmail, Rented, RentedEmail, By) VALUES
(\"id\", \"$Title\", \"$Genre\", \"$Decade\", \"$Director\",
\"$Actor1First\", \"$Actor1Last\", \"$Actor2First\", \"$Actor2Last\",
\"$Actor3First\", \"$Actor3Last\", \"$NewRelease\", \"$Description\",
\"$ImageName\", \"$EmployeeName\", \"$OwnersEmail\", \"$Rented\", \"$Email\",
\"$FName $LName\")

";

$result = @($sql, $connection) or die ("Not executing query");

Right now I am getting the die message and I am sure there is something small causing this but I must be staring at the code for too long now because I can't see it.

---

Thank you all for your help. It was a syntax error with the varible $By. Sql did not like me using one of it's opperators as a varible. I knew it had to be something small. Thank you for your help!!!

[Houdini]

Here's your code

$sql = "
INSERT INTO $table_name
(id, Title, Genre, Decade, Director, Actor1First, Actor1Last,
Actor2First, Actor2Last, Actor3First, Actor3Last, NewRelease,
Description, ImageName, EmployeeName, OwnersEmail, Rented, RentedEmail, By) VALUES
(\"id\", \"$Title\", \"$Genre\", \"$Decade\", \"$Director\",
\"$Actor1First\", \"$Actor1Last\", \"$Actor2First\", \"$Actor2Last\",
\"$Actor3First\", \"$Actor3Last\", \"$NewRelease\", \"$Description\",
\"$ImageName\", \"$EmployeeName\", \"$OwnersEmail\", \"$Rented\", \"$Email\",
\"$FName $LName\")

";

if id is actually $id ( a variable) and the id is a number or integer then it should not be quoted nor escaped. I noticed that all other Values are shown as variables, but keep in mind that variables that are actually integers or numbers are not to be quoted.

[tigomark]

That was deffinatly a problem but even fixing the $id varible I still get the error. Even if I do not add $id as an insert option will it work. Thanks

[Houdini]

$sql = "
INSERT INTO $table_name
( Title, Genre, Decade, Director, Actor1First, Actor1Last,
Actor2First, Actor2Last, Actor3First, Actor3Last, NewRelease,
Description, ImageName, EmployeeName, OwnersEmail, Rented, RentedEmail, By) VALUES
( \"$Title\", \"$Genre\", \"$Decade\", \"$Director\",
\"$Actor1First\", \"$Actor1Last\", \"$Actor2First\", \"$Actor2Last\",
\"$Actor3First\", \"$Actor3Last\", \"$NewRelease\", \"$Description\",
\"$ImageName\", \"$EmployeeName\", \"$OwnersEmail\", \"$Rented\", \"$Email\",
\"$FName\"  \"$LName\")";//comment added the escape and quote 

or with less work do this instead.

$sql = "
INSERT INTO $table_name
( Title, Genre, Decade, Director, Actor1First, Actor1Last,
Actor2First, Actor2Last, Actor3First, Actor3Last, NewRelease,
Description, ImageName, EmployeeName, OwnersEmail, Rented, RentedEmail, By) VALUES
('$Title', '$Genre', '$Decade', '$Director',
'$Actor1First', '$Actor1Last', '$Actor2First', '$Actor2Last',
'$Actor3First', '$Actor3Last', '$NewRelease', '$Description',
'$ImageName', '$EmployeeName', '$OwnersEmail', '$Rented', '$Email',
'$FName'  '$LName')";//much less typing and possibility of error

[Weedpacket]

Some tips: Drop all the error-suppressing @ signs and/or use mysql_error() to find out what the MySQL reckons the problem is instead of using your own messages. What you've got might be suitable for a live site, but for development/debugging it's not telling you anything.