[RESOLVED] Wikis & PHP Array Sorting?

bjblackmore

Hi,

This is a bit of a wiki help question, but hopefully people here might have had some experience with this!

I'm setting up a wiki for use on our company intranet, and I've created a page that will pull information out of active directory, and publish it, so employees have an easy way of finding each others contact details. I've created the page by using PHP inside of the wiki page, which runs an LDAP query, this all works fine, and displays the information correctly in an unsorted format. I would like to sort the information by employee name. I have the code, and it works in a plain PHP file perfectly, however, when I copy & paste the working code from the PHP file, into our wiki (Dokuwiki), the sort function fails to work. I've looked through a few options, such as register_globals being off in the PHP.ini, and set it to ON, but this hasn't helped. Below is a snip of my code, can anyone suggest a way to get this working in a wiki page?

Cheers

Ben

<snip>

$info = ldap_get_entries($connect, $read);

function my_sort(&$a, &$b)
{
global $sort_by;
if ($a[$sort_by][0]==$b[$sort_by][0]) return 0;
return ($a[$sort_by][0]<$b[$sort_by][0]) ? -1 : 1;
}

$sort_by = 'displayname';
usort($info, 'my_sort');

print "<table><tr>"
. "<td><b>Name</b></td>"
. "<td><b>Mobile Number</b></td>"
. "</tr>";

for($i=1;$i<@$info[$i];$i++)
{
	print "<tr><td>" . $info[$i]["displayname"][0] . "</td>";
	if (isset($info[$i]["mobile"][0]))
	{
	print "<td>" . $info[$i]["mobile"][0] . "</td></tr>";
	} else {
	print "<td>No Number Available</td></tr>";
	}
}

print "</table>";

<snip>

wilku

Turn back off register_globals for starters - it doesn't apply to globals that you said are global. It just translates all $_REQUEST['name'] to $name and thats bad (for security reasons).
It doesn't works, you mean it doesn't sort or throws some error messages. Be sure to turn on all error reporting (E_ALL) to include notices - just for the time needed to check.

bjblackmore

Hi Wilku,

Thanks for the reply. I have turned register_globals off per your advice.
When I say it doesn't work, I mean that in the plain php file, I get the following out put:

A Smith
B Wilson
C Doe
.....
Z Bloggs
etc

But when I copy & paste the exact same code into Dokuwiki I get:
C Doe
Z Bloggs
A Smith
B Wilson

The sort function just isn't sorting.
I just enabled E_ALL, and I get the following error:

Notice: Undefined index: in C:\Inetpub\dokuwiki\inc\parser\xhtml.php(339) : eval()'d code on line 33

I've opened xhtml.php and this is the function around line 339:

function php($text) {
    global $conf;
    if($conf['phpok']){
        ob_start();
        eval($text);   [B]<-line 339[/B]
        $this->doc .= ob_get_contents();
        ob_end_clean();
    }else{
        $this->file($text);
    }
}

Line 33 in my php code is:

function my_sort(&$a, &$b)
{
    global $sort_by;  [B]<-Line 33[/B]
    if ($a[$sort_by][0]==$b[$sort_by][0]) return 0;
    return ($a[$sort_by][0]<$b[$sort_by][0]) ? -1 : 1;
}

Is something incompatible between eval($text); & global $sort_by;??

Ben

wilku

echo $text before line 339 and echo $sort_by after line 33 and see what it tries to evaluate and what is $sort_by at the moment of execution.

bjblackmore

wilku,
$text is exacly the same php code that I've put in my wiki page. The 'function php($text)' is code to execute PHP code on the page if it's allowed.
$sort_by is being echoed as 'displayname' which is the variable that I want to sort my data by.

bjblackmore

Ah interesting; If I change the code so that:

function my_sort(&$a, &$b)
{
global $sort_by;
if ($a[$sort_by][0] == $b[$sort_by][0]) return 0;
return ($a[$sort_by][0]<$b[$sort_by][0]) ? -1 : 1;
}
usort($info, 'my_sort');
$sort_by = 'displayname'; <-This line here

function my_sort(&$a, &$b)
{
global $sort_by;
$sort_by = 'displayname'; <-Goes here, the sort function works correctly, and I don't get any errors!
if ($a[$sort_by][0] == $b[$sort_by][0]) return 0;
return ($a[$sort_by][0]<$b[$sort_by][0]) ? -1 : 1;
}

usort($info, 'my_sort');

Is this OK? You can't see any problems can you? I'm not going to cause any future coding problems anywhere else am I?

Ben

laserlight

I would suggest an approach that uses [man]create_function/man

$sort_by = 'displayname';
usort($info, create_function('$a,$b', "return \$a['$sort_by'][0] - \$b['$sort_by'][0];"));

This avoids the need of a global variable.

EDIT:
Of course, if you need to work with non-numeric values, then you may have to use:

function genericCmp($a, $b) {
    if ($a == $b) {
        return 0;
    } elseif ($a < $b) {
        return -1;
    } else {
        return 1;
    }
}

$sort_by = 'displayname';
usort($info, create_function('$a,$b', "return genericCmp(\$a['$sort_by'][0], \$b['$sort_by'][0]);"));

Of course, for string values you would forward the return value of strcmp() instead.

bjblackmore

Laserlight,

That second secton of code worked a treat!

Thanks for your help, and thanks to wilku as well!

Ben