problem showing my code on screen

Migz

hi , i have some code here

<?php
require 'userinfo.php';

require 'MESN.php';

echo '<hr />';

if($logged_in == 1) 
{
$MTM = mysql_query("SELECT * FROM my_code" . " WHERE viewers=" . "'" . $username . "'" . "");
echo('<h2>Your Madtast Code Box!</h2>');
echo "<hr />";

while($row = mysql_fetch_array($MTM))
  {
   $code = str_replace("\n","<br>",$row['code']);
  echo('<table border="1" width="600" height="100"><tbody><tr><td>');
  echo ("<h3>" . "Creator: " . $row['username'] . "<br />" . "Language: " . $row['language'] . "<br />" . "Discription: " . $row['discription'] . "<br />" . "Code: " . '<textarea type="text", readonly="readonly", style="height:300px; width:400px;>"' . $code . "</textarea></h3>");
  echo("</td></tr></tbody></table><hr />");
  }

echo "<hr />";
mysql_close($con);
}
else { echo("<h2>You Must Be Logged In To Access This Page!</h2>"); }
echo('</body>
<html>');
?>

but it doesnt display right , it only shows
"your madtast code box"

can anyone help me . tx
http://v2s.madtast.net/profiles/cread.php

leatherback

Hi, add some info behind the mysql_query command, and clean things up a bit:


$MTM = mysql_query("SELECT * FROM my_code WHERE viewers='".$username."'") or die(mysql_error());

bradgrafelman

Also, where is $username ever defined?

Weedpacket

   $code = str_replace("\n","<br>",$row['code']);

You could replace this with a call to [man]nl2br[/man]

Have you looked at the generated HTML source, or just at the browser's attempt to render it?

'<textarea type="text", readonly="readonly", style="height:300px; width:400px;>"'

You might want to check where your quote marks in this string are (especially toward the end) - oh, and there shouldn't be commas between the attributes (while I'm still being pedantic, I'll add that the <textarea> element doesn't have a type= attribute).

Kudose

Furthermore, you can use readonly by itself, as opposed to readonly="readonly".

Weedpacket

Kudose wrote:
Furthermore, you can use readonly by itself, as opposed to readonly="readonly".

Not since XHTML 1.0 - all XML attributes must have values.