[RESOLVED] How to require questions to be answered in a quiz.

[EPJS]

I want it so if not all the questions were answered, you'll get a message asking you to go back and answer all the questions. I tried a few different ways to achieve this, but everything I tried caused the message to always come up, even if all the questions were answered it would still say "please answer all".

Here's the code for the quiz, can you fix it up so it requires every question to be answered.

quiz.php

Is this correct?<br />
<input name="q[1]" type="radio" value="yes" />Yes<br />
<input name="q[1]" type="radio" value="no" />No<br />
<br />

Is this correct?<br />
<input name="q[2]" type="radio" value="yes" />Yes<br />
<input name="q[2]" type="radio" value="no" />No<br />
<br />

Is this correct?<br />
<input name="q[3]" type="radio" value="yes" />Yes<br />
<input name="q[3]" type="radio" value="no" />No<br />
<br />

THERE ARE 10 OF THESE

quizresults.php

//------- Variables ------------------------------------

// Name
$name = htmlspecialchars($_POST['name']);

// Mailing
$sendto = "REMOVE@REMOVE";
$subject = "the quiz";
$content = "Name: {$name}\n\n";
$content .= print_r($_POST['q'], true);
$headers = "From: Quiz Answers\n";

//------------------------------------------------------



$count = 0;
$total = 10;

if (is_array($_POST['q'])) {
    foreach ($_POST['q'] as $value) {
        if ($value == 'yes') {
            ++$count;
        }
    }
}

echo "<h1>Hello <span style='color:red'>" . $_POST['name'] . "</span></h1>";

printf("<h1>You are %d%% correct.</h1>", round($count / $total * 100));

mail($sendto, $subject, $content, $headers);

[Kudose]

foreach($_POST['q'] as $key => $value)
  if(empty($value)) die('Answer all questions.');

[EPJS]

I'm getting a

Warning: Invalid argument supplied for foreach()

[leatherback]

Hi,

I have noticed that sometimes empty checkboxes & radiobuttons are not posted to the next page.

So you might want to do something like:

for ($i = 0; $i <= 10; $i++) {
if(array_key_exists($_POST['q'], $i))
  {
  if($_POST['q'][$i] == '')
    {
     $echo "please fill out question ".$i+1."";
    }
  }
else
  {
     $echo "please fill out question ".$i+1."";
  }
}

[EPJS]

First I got

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING

I removed the $ from $echo making it just echo, and now I get this

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ';'

It's telling me the error is on this line

echo "please fill out question ".$i+1."";

for ($i = 0; $i <= 10; $i++) {
if(array_key_exists($_POST['q'], $i))
  {
  if($_POST['q'][$i] == '')
    {
     echo "please fill out question ".$i+1.""; //This line
    }
  }
else
  {
     echo "please fill out question ".$i+1."";
  }
}

[leatherback]

for ($i = 0; $i <= 10; $i++) {
$j = $i+1;
if(array_key_exists($_POST['q'], $i))
  {
  if($_POST['q'][$i] == '')
    {
     echo "please fill out question ".$j;
    }
  }
else
  {
     echo "please fill out question ".$j;
  }
} 

[EPJS]

Warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object

I'm getting one per question. So there's a whole page full of that message.

[leatherback]

EPJS wrote:

I'm getting one per question. So there's a whole page full of that message.

Hi EPJS,

There are some typos in the scripts (I even put it in my sig: I often just write when I am looking for something, and do NOT check all the code, as they are examples of how to work them. I feel that you should be writing yuour own scripts eventually. If you see an erro like that, go to the manual, and chekc the function.

In this case, I reversed the array and the index. My mistake.

if(array_key_exists($_POST['q'], $i))

should be

if(array_key_exists($i, $_POST['q']))

[EPJS]

If some questions have been answered, it works as intended. However if none of the questions are answered (submitting a blank quiz) then you get that error again

Warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in

Even with the typo fix.

As long as I answer just one question, it's fine. Otherwise a warning comes up.

[rgermain]

You then will need to check for and empty array as nothing is being passed. Simply check if all the questions were filled in and let them know they need to fill out the question if not.

With the information provided by leatherback and some research you should be able to accomplish this pretty easily.

R. Germain

[EPJS]

I added

if (isset($_POST['q'])) {
//the code posted above
}

And it seems to have stopped the warnings from appearing when you don't answer any of the questions. But it's still allowing the quiz to be submitted unanswered 🙁

[leatherback]

Well..

How do you prevent the quizz from being submitted?

If you do this:

if (isset($_POST['q'])) {
//the code posted above
// And the processing of the form, I suppose
} 

You should offer an alternative:

else
  {
  echo "Sorry, you need to fill out the questions";
  echo $form;
  }

[EPJS]

Ok what am I doing wrong? I almost have it just right, but now if you answer 1-9 questions the results repeat the number of times as many questions you answered. (if you answer all 10 questions, the page is blank). At least this time, if none of the questions are answered, it asks you to answer them.

if (isset($_POST['q'])) {
	for ($i = 0; $i <= 9; $i++) {
		$j = $i+1;
		if(array_key_exists($i, $_POST['q'])) {
			if($_POST['q'][$i] == '') {
				echo ''; //It doesn't matter what is here, it never echos
			}
		}
		else {
			$count = 0;
			$total = 10;

		if (is_array($_POST['q'])) {
			foreach ($_POST['q'] as $value) {
				if ($value == 'yes') {
					++$count;
				}
			}
		}
		echo "<h1>Hello <span style='color:red'>" . $_POST['name'] . "</span></h1>";

		printf("<h1>You are %d%% my type of girl.</h1>", round($count / $total * 100));

		mail($sendto,$subject, $content, $headers);
	}
}
}
else {
	echo "<h1>Sorry, you need to fill out the questions</h1>";
}

[leatherback]

give this a go:

$errors = "";

// testing for all answers
if(isset($_POST['q']))
  {
  for ($i = 0; $i <= 9; $i++) {
  $j = $i+1;
  if(array_key_exists($i, $_POST['q']))
    {
    if($_POST['q'][$i] == '') // No answer given
      {
       $errors .= "please fill out question ".$j."<br />";
      }
    }
  else
    { // Doesn't exist in post array
    $errors .= "please fill out question ".$j."<br />";
    }
  }
else
  { // Variable was not submitted
  $errors = "You need to fill out the questions";
  }

// performing the processing
if($errors == "")
  {
  echo "<h1>Hello <span style='color:red'>" . $_POST['name'] . "</span></h1>";
  printf("<h1>You are %d%% my type of girl.</h1>", round($count / $total * 100));
  mail($sendto,$subject, $content, $headers);
  }
else
  {
  echo $errors;
  }

[EPJS]

Parse error: syntax error, unexpected T_ELSE

else //this line is where it says the error is
  { // Variable was not submitted
  $errors = "You need to fill out the questions";
  } 

The warnings aren't very descriptive, so I'm not sure their meaning 60% of the time

[bradgrafelman]

Try adding a '}' before that else (to close the if(isset($_POST['q'])) block).

[EPJS]

Ok thanls, that worked 🙂
I knew there was a missing } but wasn't sure where it went. I had it at the end before haha

It works now 🙂