[RESOLVED] Having problems changing a display from one result to multiple

schwim

Hi there guys,

In my script, I have a block that people can insert into other pages, which displays a single random result. I thought that I had created it to where I could change the result to more than one, by changing the limit, but for some reason, it's not showing any more than one result, regardless of what I set limit to. Here's my code:

/* this query will get a random testimonial result */

$query = "SELECT id,postdate,author,authorweb,authorwebname,title,testtext,highlight FROM ".$prefix."testimonials WHERE active=1 ORDER BY rand() LIMIT 4";  <~~ changing limit

$result = mysql_query ($query) or die('MySQL error: ' . mysql_error() . '<hr/>' . $query);

$result_rows = mysql_num_rows($result);


$result = mysql_query ($query);while ($row = mysql_fetch_assoc ($result)) {



	$id = $row['id'];

	$postdate = $row['postdate'];

	$author = $row['author'];

	$authorweb = $row['authorweb'];

	$authorwebname = $row['authorwebname'];

	$title2 = $row['title'];

	$testtext1 = strip_tags ($row['testtext'], '<br>');

	$highlight = $row['highlight'];



	function nicetrim ($s, $length) {



		$str_to_count = html_entity_decode($s);

		if (strlen($str_to_count) <= $length) {

			return $s;

		}



		$s2 = substr($str_to_count, 0, $length);

		$s2 = substr($str_to_count, 0, $length - 3);

		$s2 .= "...";

		return $s2;

	}



	$testtext = nicetrim($testtext1, $block_textcount);

	$title = nicetrim($title2, $block_titlecount);



	/* display the data */

	echo("<html>

	<head>

	<script language=\"javascript\" type=\"text/javascript\">

	<!--

	/****************************************************

	     Author: Eric King

	     Url: http://redrival.com/eak/index.shtml

	     This script is free to use as long as this info is left in

	     Featured on Dynamic Drive script library (http://www.dynamicdrive.com)

	****************************************************/

	var win=null;

	function NewWindow(mypage,myname,w,h,scroll,pos){

	if(pos==\"random\"){LeftPosition=(screen.width)?Math.floor(Math.random()*(screen.width-w)):100;TopPosition=(screen.height)?Math.floor(Math.random()*((screen.height-h)-75)):100;}

	if(pos==\"center\"){LeftPosition=(screen.width)?(screen.width-w)/2:100;TopPosition=(screen.height)?(screen.height-h)/2:100;}

	else if((pos!=\"center\" && pos!=\"random\") || pos==null){LeftPosition=0;TopPosition=20}

	settings='width='+w+',height='+h+',top='+TopPosition+',left='+LeftPosition+',scrollbars='+scroll+',location=no,directories=no,status=no,menubar=no,toolbar=no,resizable=no';

	win=window.open(mypage,myname,settings);}

	// -->

	</script>

	</head>

	<body>

	<div align=center>

	<table width=$block_width border=1 cellpadding=1 cellspacing=1>");

	if($block_showtitle == 1) {

		echo("<tr>

			<td bgcolor='#ffffff' width=400>

			<font size=3><b>$title</b></font>

			</td>

		</tr>");

	}

	echo("	<tr>

			<td bgcolor='#ffffff'>

			<font size=2>");

	if($use_highlight == 1){



		if($highlight != ""){



			echo("...".$highlight."...

			<hr>

			<a href=\"$siteurl/index.php?id=$id\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View this testimonial</a><br>");



		}else{



			echo("$testtext

			<hr>

			<a href=\"$siteurl/index.php?id=$id\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View this testimonial</a><br>");



		}



	}else{



		echo("$testtext

			<hr>

			<a href=\"$siteurl/index.php?id=$id\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View this testimonial</a><br>");



	}



	echo("</font><p>

			</td>

		</tr>");

	if($block_showauth == 1) {

		echo("<tr>

			<td align='right'>

			<font size='1'>$author</font>

			</td>

		</tr>");

	}

	if($authorweb != "") {



		if($block_showauthweb == 1) {

			echo("<tr>

			<td align='right'>

			<font size='1'><a href='$authorweb' target='_blank'>$authorwebname</a></font>

			</td>

		</tr>");

		}

	}

	echo("<tr>

			<td bgcolor='#ffffff'>

			<font size=2>

			<a href=\"$siteurl\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View all testimonials</a><br>

   			<a href=\"$siteurl/form.php\" onclick=\"NewWindow(this.href,'submit','600','400','yes','center');return false\" onfocus=\"this.blur()\">Submit your own</a>

			</font><p>

			</td>

		</tr>

	</table>

	</div><br>

	<br>

	</body>

	</html>");

}

}



mysql_close($autoconn);

Could someone point out what I'm doing wrong that is not allowing it to show mulitple results?

thanks,
json

leatherback

Hi,

In the loop which you use to retrieve the actual data (while ($row = mysql_fetch_assoc ($result)) {
})

You need to do all the processing, or store the values of multiple rows. Otherwise in each loop you will just overwrite the existing variables.

Just for illustrations' sake, place
echo $row['author'];
on the first line after the
while ($row = mysql_fetch_assoc ($result)) {
statement.

schwim

Hi there, and thanks very much for your reply, leatherback.

I pasted the echo statement like you suggested, and the value appeared above & below the table that's getting printed.

My confusion stems from the fact that I grabbed this code from another part of my script where I print all of the records in the admin section. I know that the table shouldn't be inside the while condition, but I was going to fix that once I made sure that it was printing multiple records.

To my eye, I don't see any difference between where the code works(admin section) and where it doesn't.

I guess that was a very poor attempt to explain that I'm not sure what I need to do to store multiple rows. If you could dumb it down for me, I'd appreciate it 🙂

thanks,
json

leatherback

ok,

gimme a minute. Just copied the script to a local processor, and will have a look. Thought you had the table OUTSIDE the loop. Hm.. Online looking on long scripts..

Will be back

leatherback

Did some cleaning of the code. You do not need to add backets around the echo statement. I also moved the head & foot of table & page outside the loop. I think that will help. I suspect if you look at the HTML generated by the original script, that the content was there, but hidden, as your HTML was flawed

<?php

$limit = 4;

// cleaning function

function nicetrim($s, $length) 
   {
	$str_to_count = html_entity_decode($s);
	if (strlen($str_to_count) <= $length) 
	  {
	  return $s;
	  }

$s2 = substr($str_to_count, 0, $length);
$s2 = substr($str_to_count, 0, $length - 3);
$s2 .= "...";
return $s2;
}

	/* display the data */

	// Dont forget the encodiung and html version, keywords yadieyadie
echo "
<html>
<head>
<script language=\"javascript\" type=\"text/javascript\">
	<!--

	/****************************************************

	     Author: Eric King

	     Url: http://redrival.com/eak/index.shtml

	     This script is free to use as long as this info is left in

	     Featured on Dynamic Drive script library (http://www.dynamicdrive.com)

	****************************************************/

	var win=null;

	function NewWindow(mypage,myname,w,h,scroll,pos){

	if(pos==\"random\"){LeftPosition=(screen.width)?Math.floor(Math.random()*(screen.width-w)):100;TopPosition=(screen.height)?Math.floor(Math.random()*((screen.height-h)-75)):100;}

	if(pos==\"center\"){LeftPosition=(screen.width)?(screen.width-w)/2:100;TopPosition=(screen.height)?(screen.height-h)/2:100;}

	else if((pos!=\"center\" && pos!=\"random\") || pos==null){LeftPosition=0;TopPosition=20}

	settings='width='+w+',height='+h+',top='+TopPosition+',left='+LeftPosition+',scrollbars='+scroll+',location=no,directories=no,status=no,menubar=no,toolbar=no,resizable=no';

	win=window.open(mypage,myname,settings);}

	// -->

	</script>

	</head>

	<body>

	<div align=center>

	<table width=$block_width border=1 cellpadding=1 cellspacing=1>

	";


/* this query will get a random testimonial result */

$query = "SELECT id,postdate,author,authorweb,authorwebname,title,testtext,highlight FROM ".$prefix."testimonials WHERE active=1 ORDER BY rand() LIMIT ".$limit;  

$result = mysql_query ($query) or die('MySQL error: ' . mysql_error() . '<hr />' . $query);
  $result_rows = mysql_num_rows($result);

  while ($row = mysql_fetch_assoc ($result)) 
    {
	$id 			= $row['id'];
	$postdate 		= $row['postdate'];
	$author 		= $row['author'];
	$authorweb 		= $row['authorweb'];
	$authorwebname 	= $row['authorwebname'];
	$title2 		= $row['title'];
	$testtext1 		= strip_tags($row['testtext'], '<br>');  // Not sure what you try to do
	$highlight 		= $row['highlight'];
	$testtext 		= nicetrim($testtext1, $block_textcount);  // Not sure what you try to do
	$title 			= nicetrim($title2, $block_titlecount);  // Not sure what you try to do



if($block_showtitle == 1) 
  {
  echo "
  <tr>
	<td bgcolor='#ffffff' width=400>
	<font size=3><b>$title</b></font>
	</td>
	</tr>
	";
  }

echo "
<tr>
  <td bgcolor='#ffffff'>
  <font size=2>";
	if($use_highlight == 1){
		if($highlight != ""){
			echo"...".$highlight."...
			<hr>
			<a href=\"$siteurl/index.php?id=$id\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View this testimonial</a><br>";

		}else{

		    echo "$testtext
			<hr>
			<a href=\"$siteurl/index.php?id=$id\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View this testimonial</a><br>";
		}

        }else{

		echo "$testtext
			<hr>
			<a href=\"$siteurl/index.php?id=$id\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View this testimonial</a><br>";
	}

	echo "</font><p>

			</td>

		</tr>";

	if($block_showauth == 1) {

		echo "<tr>

			<td align='right'>

			<font size='1'>$author</font>

			</td>

		</tr>";

	}

	if($authorweb != "") {



		if($block_showauthweb == 1) {

			echo "<tr>

			<td align='right'>

			<font size='1'><a href='$authorweb' target='_blank'>$authorwebname</a></font>

			</td>

		</tr>";

		}

	}

	echo "<tr>

			<td bgcolor='#ffffff'>

			<font size=2>

			<a href=\"$siteurl\" onclick=\"NewWindow(this.href,'submit','800','600','yes','center');return false\" onfocus=\"this.blur()\">View all testimonials</a><br>

   			<a href=\"$siteurl/form.php\" onclick=\"NewWindow(this.href,'submit','600','400','yes','center');return false\" onfocus=\"this.blur()\">Submit your own</a>

			</font><p>

			</td>

		</tr>";


}
echo "
	</table>

	</div><br>

	<br>

	</body>

	</html>";

}



mysql_close($autoconn);

?>

schwim

Thanks very much for the help leatherback. I really appreciate it.

thanks,
json

schwim

woops, I was replying to your earlier post:

I'll go try this and let you know.

thanks,
json

schwim

It seems to work excellently leatherback. Thank you very much for your assistance. You were right that it was simply poor formatting of the html ending the page generation.

thanks,
json

bradgrafelman

Don't forget to mark this thread resolved.