[RESOLVED] Help with form checkboxes

nascarjunky

I am using the following code to create a form with checkboxes. The checkbox choices are included from a database query. I want the checkbox to show the values from the 'driver' field + the 'salary' field. The current code simply displays the checkbox + a . + the value from 'salary'.

Any advice would be greatly appreciated.

Thanks,

<?php
/*  Program name: alldrivercheckboxes.php
 *  Description:  Program displays a list of 
 *                checkboxes from database info for selecting 12 man roster.
 */

   //session_start();
   //if (@_SESSION['auth'] != "yes")
   //{
   //  header("Location: Login.php");
   //  exit();
   // }

   include("nascarconnect.php");

   echo "<html>
      <head><title>All Drivers</title></head>
      <body>";


  $query = "SELECT * FROM AllDrivers
                ORDER BY salary";
  $result = mysql_query($query)
       or die ("Couldn't execute query.");

  echo "<div style='margin-left: .5in'>
  <p>&nbsp;
  <p><b>Please Select 15 Drivers From The List Below.</b>
  <p>Be Sure And Select 15:\n";


  /* create form containing checkboxes */
  echo "<form action='15manrosterselection.php' method='POST'>\n";

  while ($row = mysql_fetch_array($result))
  {
     extract($row);
     echo "<input type='checkbox' name='driver[$driver]' value='$driver . $salary'>$driver . 

$salary\n";
     echo "<br>\n";
  }
echo "<p><input type='submit' value='Submit 15 Man Roster'>
        </form>\n";
?>
</div></body></html>

dream_scape

You can't do concatenation in double quotes.

You'll have to do either:

echo "<input type='checkbox' name='driver[$driver]' value='{$driver}{$salary}'>{$driver}{$salary}\n";

Or:

echo "<input type='checkbox' name='driver[$driver]' value='" . $driver . $salary . "'>" . $driver . $salary . "\n";

leatherback

Hey Nascar,

Sorry to bug you but.. What you try to do doesn't make sense, to be honest. As driver & salary come from the same table, you can -based on driver id- always retrieve the salary. Why pain your head by merging two fields into one value-field. I can't image the headaches you run into doing anything with the submitted variables..

nascarjunky

I am a newbie so could you please explain what you mean. I was just trying to show the salary of the driver so the person could see it when making their choices. Please let me know what the better solution would be. I would greatly appreciate your help.

Thanks,

leatherback

Hi Nascarjunky,

Please do not write to me in private to look at your reply. I usually revisited the threads I post in, like most people that try and answer questions. This is a global forum, and as such, people will not always get back to you within minutes: They might be asleep, at work or having dinner. In general: Having a life.

With regards to your question.
I am assuming you have a table with columns:

id : Unique autonumber field
name : Name of the driver
salary : Salary of driver

If you have a form with checkboxes. This value of the checkbox is posted to the processing script, right?

So if you take the checkbox, and have this:
echo "
<input type='checkbox' name='driver[$driver]' value='$driver . $salary'>$driver.$salary";

You are posting: $driver . $salary' to the next page (so John3600). This is really hard to use, as you cannot search for john3600 in your database (Well.. you could but..).

Much easier is it to take your driver identifier column. If you use this as value, you can on the processing page just get the driver from the database again:
e.g., select * from TABLE where id = $POSTED_VALUE

nascarjunky

Leatherback,

Thanks so much for the reply. Please let me know if I am correct about the following or I am misunderstanding your solution.

If I change the echo statement in the form so that value = id I am assuming the following will be displayed on the form for user input.
(A Checkbox) (Driver id value only)
On the form processing page I should then include a query to include all the
records based on this driver value id.

After reading your reply I do understand why I wouldn't want to create a value that included both the driver name and driver salary. However, I would need to figure out a way to at least get the driver name on the form for the player to make their selection.

Thanks again for your help.

leatherback

Hi:

<input type='checkbox' name='driver' value='$id'>$driver.$salary";

The value you pass to the script is ID, the user sees [driver][salary]

In the next page you can then retrieve the name and the salary using
$id = CHECKUSERINPUT($_POST['id'])
"select driver, salary from TABLE where id=";

You will need to think about how to get your posted variables sanitized before passing them to scripts (Your CHECKUSERINPUT), but I assume you have system in place to do this.

nascarjunky

Thanks so much for the reply. I will try this fix when I get back in town tonight.

Thanks,

Bob

nascarjunky

Fix did not work. I must be doing something wrong.

<?php
/*  Program name: alldrivercheckboxes.php
 *  Description:  Program displays a list of 
 *                checkboxes from database info for selecting 12 man roster.
 */

   //session_start();
   //if (@_SESSION['auth'] != "yes")
   //{
   //  header("Location: Login.php");
   //  exit();
   // }

   include("nascarconnect.php");

   echo "<html>
      <head><title>All Drivers</title></head>
      <body>";


  $query = "SELECT * FROM AllDrivers 
                ORDER BY salary DESC";
  $result = mysql_query($query)
       or die ("Couldn't execute query.");

  echo "<div style='margin-left: .5in'>
  <p>&nbsp;
  <p><b>Please Select 15 Drivers From The List Below.</b>
  <p>Be Sure And Select 15:\n";


  /* create form containing checkboxes */
  echo "<form action='15manrosterselection.php' method='POST'>\n";

  while ($row = mysql_fetch_array($result))
  {
     extract($row);
     echo "<input type='checkbox' name='driver'value='$drid'>$driver.$salary";
     echo "<br>\n";
  }
echo "<p><input type='submit' value='Submit 15 Man Roster'>
        </form>\n";
?>
</div></body></html>

Click HERE to see the results.

Please help.

bradgrafelman

Are you trying to display drivers and their saleries, e.g. "Foo Bar.2560000" ?

If so, are you sure the column in your MySQL table is called "driver" ? Note that 'Driver' and 'driver' are two different variable names.