Condense my code?

mzanimephp

Hi, I built this (newbish) little calculator in my spare time. And I'm sure it could be coded better than how I did it. Do any of you have any suggestions for possibly making the code leaner? Here's my code:

<html>
<head>
<title>PHP Experiment</title>
<style type="text/css">
body { font:12px Arial; }
.forms { width:250px; border:solid 1px #ABC; padding:5px 10px 10px 10px; }

.forms label { 
  color:#999; float:left; text-align:right; 
  width:100px;
}
.forms input[type=checkbox] { 
  vertical-align:middle; 
}
.forms br { clear:left; }

.smtxt { font-size:11px; }
</style>
</head>
<body>


<?php 

if(empty($_GET['time'])) { 
$time = 0; 
} else {
$time = $_GET['time'];
} 

$web = 50;
$forms = 5;
$blog = 10;
$total = 0;

// per one

if((!empty($_GET['web'])) && (empty($_GET['forms'])) && (empty($_GET['blog']))) {
$ch1 = 'checked="checked"';
$total = $web * $time;
}

if((empty($_GET['web'])) && (!empty($_GET['forms'])) && (empty($_GET['blog']))) {
$ch2 = 'checked="checked"';
$total = $forms * $time;
}

if((empty($_GET['web'])) && (empty($_GET['forms'])) && (!empty($_GET['blog']))) {
$ch3 = 'checked="checked"';
$total = $blog * $time;
}

// per two

if((!empty($_GET['web'])) && (!empty($_GET['forms'])) && (empty($_GET['blog']))) {
$ch1 = 'checked="checked"';
$ch2 = 'checked="checked"';
$total = ($web + $forms) * $time;
}

if((!empty($_GET['web'])) && (empty($_GET['forms'])) && (!empty($_GET['blog']))) {
$ch1 = 'checked="checked"';
$ch3 = 'checked="checked"';
$total = ($web + $blog) * $time;
}

if((empty($_GET['web'])) && (!empty($_GET['forms'])) && (!empty($_GET['blog']))) {
$ch2 = 'checked="checked"';
$ch3 = 'checked="checked"';
$total = ($forms + $blog) * $time;
}

// per three

if((!empty($_GET['web'])) && (!empty($_GET['forms'])) && (!empty($_GET['blog']))) {
$ch1 = 'checked="checked"';
$ch2 = 'checked="checked"';
$ch3 = 'checked="checked"';
$total = ($web + $forms + $blog) * $time;
}

if((isset($total)) && ($total > 500)) {
$toomuch = true;
}

$total = '$'.$total.'.00';

?>




<form class="forms" action="index.php">

<?php
if(!ereg('^[0-9]+$',$time)) {
exit("<span style='color:red'>Only enter numerical values!<br /><input type=\"submit\" value=\"OK\" /></span>");
}
?>
<b>Approximate Work Duration:</b>
<br />
<br />
<input type="text" value="<?php echo $time; ?>" size="2" name="time" /> Hours
<br />
<br />


<label for="web">$25.00 per hour</label>
<input type="checkbox" name="web" <?php echo $ch1; ?> />
Web site design
<hr />

<label for="forms">+ $5.00 per hour</label>
<input type="checkbox" name="forms" <?php echo $ch2; ?> />
Web forms
<hr />

<label for="blog">+ $10.00 per hour</label>
<input type="checkbox" name="blog" <?php echo $ch3; ?> />
Install extras
<br />
<hr />
<span class="smtxt">Extras may include a blog, a forum, 
or a shopping cart</span>
<br />
<br />

<input type="submit" value="Calculate" />
<!--
<input type="reset" value="Clear" />
-->
<br />
<br />

Estimated total:<br /> 
<input size="13" type="text" value="<?php echo $total; ?>" />
<br />
<br />


<?php 
if($toomuch) {
echo 'On a low budget? Sometimes (depending upon the client '
.' and their circumstances) I will provide my services for '
.'<a href="#">gifts</a> in return. View the items in my wishlist!';
}

?>

</form>

</body>
</html>

NogDog

Here's a version using an array (called $rates) to help organize things. By simply changing the numeric values for its elements, you control the rates listed on the form and the actual calculations.

<html>
<head>
<title>PHP Experiment</title>
<style type="text/css">
body { font:12px Arial; }
.forms { width:250px; border:solid 1px #ABC; padding:5px 10px 10px 10px; }

.forms label {
  color:#999; float:left; text-align:right;
  width:100px;
}
.forms input[type=checkbox] {
  vertical-align:middle;
}
.forms br { clear:left; }

.smtxt { font-size:11px; }
</style>
</head>
<body>

<?php
$rates = array(
   'web' => 50,
   'forms' => 5,
   'blog' => 10
);

$rate = 0;

$time = (empty($_GET['time'])) ? 0 : $_GET['time'];

foreach($rates as $key => $value)
{
   if(!empty($_GET[$key]))
   {
      $rate += $rates[$key];
      $ch[$key] = 'checked="checked"';
   }
   else
   {
      $ch[$key] = '';
   }
}

$total = $rate * $time;

if($total > 500) {
   $toomuch = true;
}
?>

<form class="forms" action="<?php echo $_SERVER['PHP_SELF']; ?>">

<?php
if(!ereg('^[0-9]+$',$time)) {
exit("<span style='color:red'>Only enter numerical values!<br /><input type=\"submit\" value=\"OK\" /></span>");
}
?>
<b>Approximate Work Duration:</b>
<br />
<br />
<input type="text" value="<?php echo $time; ?>" size="2" name="time" /> Hours
<br />
<br />

<label for="web"><?php printf('$%.2f', $rates['web']); ?> per hour</label>
<input type="checkbox" name="web" <?php echo $ch['web']; ?> />
Web site design
<hr />

<label for="forms">+ <?php printf('$%.2f', $rates['forms']); ?> per hour</label>
<input type="checkbox" name="forms" <?php echo $ch['forms']; ?> />
Web forms
<hr />

<label for="blog">+ <?php printf('$%.2f', $rates['blog']); ?> per hour</label>
<input type="checkbox" name="blog" <?php echo $ch['blog']; ?> />
Install extras
<br />
<hr />
<span class="smtxt">Extras may include a blog, a forum,
or a shopping cart</span>
<br />
<br />

<input type="submit" value="Calculate" />
<!--
<input type="reset" value="Clear" />
-->
<br />
<br />

Estimated total:<br />
<input size="13" type="text" value="<?php printf('$%.2f', $total); ?>" />
<br />
<br />

<?php
if($toomuch) {
echo 'On a low budget? Sometimes (depending upon the client '
.' and their circumstances) I will provide my services for '
.'<a href="#">gifts</a> in return. View the items in my wishlist!';
}

?>

</form>
</body>
</html>

mzanimephp

Wow, thats insane!

Of course, I have questions...

Whats the difference between this operator => and this one? -> (In plain english)

I assume this operator += means "added to, or equal"

I don't like how this part looks, it's so cryptic... printf('$%.2f', $rates['web']);

NogDog

mzanimephp wrote:
Wow, thats insane!

Of course, I have questions...

Whats the difference between this operator => and this one? -> (In plain english)

=> is used for defining associative array elements. The string on the left is the array element key, and the value on the right is the value assigned to that key.

-> is used in object-oriented code as the "pathname separator" to specify object/class attributes or methods, such as:

$obj = new MyClass();
$result = $obj->myMethod();  // executes the method myMethod() defined in class MyClass as instantiated in object $obj.

I assume this operator += means "added to, or equal"

It means set the value of the variable on the left side to its current value plus the value of the expression on the right side. The following two commands are functionally equivalent:

$var = $var + 10;
$var += 10;

I don't like how this part looks, it's so cryptic... printf('$%.2f', $rates['web']);

See [man]printf[/man] or [man]sprintf[/man] for a full description with all the options. In this case, it means print the string '$%.2f', but replace the place-holder %.2f with the value of $rates['web'], with exactly two decimal places.