Insert query empty

[genista]

Hi all,

I seem to be having a problem with updating a database and I suspect it is the php outputting html that might be the cause, here is the order of the script:

having got the database records out we output some html based on certain criteria being met:

if (($service1 == "true")){ 
        echo "<tr><td><br>Your price for service1  is: £$service1price use this field to update your price:</tr></td><tr><td><input type=\"text\" name=\"service1price\" value=\"\" maxlength=\"25\"></tr></td></br>";
        }
        else{
        echo "<br>You do not provide service1</br>";
    }  

You can see here that the user can update the price of a service provided they.. provide it!

This works fine, now I need to set the data to be posted back to the database. I post the supplierid because this is a new table and it might be the first time the user is updating the table:

if(isset( $submit )) 
{      

$supplierid = isset($_POST['supplierid']) ? $_POST['supplierid'] : "";
$service1price = isset($_POST['service1price']) ? $_POST['service1price'] : "";

Now I do some error checking before updating the database:

}

  if(!empty($messages)){
    displayErrors($messages);
}  

    else
    {
$query = "INSERT INTO supplierprices (supplierid, serviceprice1) VALUES('".$supplierid."', '".$service1price."') ON DUPLICATE KEY UPDATE supplierid = '" . $supplierid . "'";  

 $result = mysql_query($query, $link) or die('Update failed: ' . mysql_error()); 
 echo $query; 

//print_r($query);  

 mysql_info($link) ; 
    if(mysql_affected_rows($link) == 0) 
    { 
      //$link next to affected rows and mysql query
        echo ''; 
    } 

else 
{ 
    echo 'Your profile has been updated successfully, please click <a href=suppliers.php>here</a> to go back to the main member page.'; 
}           
 }  

So the above is not completly finished but the query itself is. The problem when I output the query is that having entered a value for serviceprice1 it is empty here.

Any ideas why?

Thanks,

G

[doublehops]

I think you need to change

if(isset( $submit )) 

to

if(isset($_POST['submit']))

[Piranha]

I noticed that you open and close the <br> tag. That tag should not be closed that way. If you want to close it correctly according to XML rules then you should do it in the same tag: <br />.

[Weedpacket]

Piranha wrote:

That tag should not be closed that way.

Exactly, the <br> element is defined to be empty (how can you put something inside a line break, after all?)

Also, depending on what happens between the quoted blocks of code, you might be trying to insert data that doesn't exist. If $submit (or rather, as douplehops points out, $_POST['submit']) isn't set, does the code in the third sample still run?

[genista]

Thanks for the updates guys, I have made the changes as mentioned. To you Weedpacket, the update does automatically run as per the third section and is therefore updating with no data in. To fix this I have no moved a closed bracket below the query, so it is encapsulated into the rest of the script.

Now the query only runs when you hit submit.

I have also changed the dynamic html like so:

 	if (($service1 == "true")){ 
		echo "<tr><td><br>Your price for service 1 is: £$serviceprice1 use this field to update your price:</tr></td><tr><td><input type=\"text\" name=\"service1price\" value=\"\" maxlength=\"25\"></tr></td><br/>";
		}
		else{
		echo "<br>You do not provide service 1<br/>";
	}

When I run the query with a value typed in for serviceprice1 the query is empty. In order to see if the html was the problem I have coded some html at the bottom under the PHP. It manages to add a value to the query, which suggests that my html in the PHP is still wrong..

Following on from that when I do run the query the supplierid is empty so it is not updating the database even though I have at least managed to get another value in the query (serviceprice1).

I've got myself in a muddle, no doubt about it.

G