[RESOLVED] Confused on why loop seems to works, but doesnt finish.

[dmacman1962]

Hi All,

I am working on a PHP/SQL query and I am getting the correct number of records from the table and the correct data, but my loop does not seem to finish; note the

echo '<br /><br />end the 1st loop';

after the loop, it does not echo.

echo '------------Starting 1st loop--------------------<br /><br />';
$msconnect=mssql_connect("x","x","x") or die("Could not connect to the database.");
$msdb=mssql_select_db("x",$msconnect) or die("Could not select the database.");

//1st loop
$query = mssql_query("SELECT * FROM AMGR_Client_Tbl WHERE Record_Type='42'") or exit(mysql_error());

echo '<pre>';
print_r($query).'<br>';
echo '</pre>';

$total_rows = mssql_num_rows($query);
echo 'The total number of records is '.$total_rows.'<br /><br />';
$x=1;

while ($row = mssql_fetch_array($query) or die (mysql_error())) {
echo $x.') '.$row['First_Name'].' '.$row['Name'].'<br />';
$x++;
}
echo '<br /><br />end the 1st loop';

I am expecting 2 records and I get ...

------------Starting 1st loop--------------------

Resource id #3

The total number of records is 2

1) record 1
2) record 2

But no '<br /><br />end the 1st loop'???

Am I missing something obvious here or is it something in the SQL stored procedure that is the issue?

Thanks in advance,
Don

[laserlight]

Remove the "or die (mysql_error()" from the loop condition.

[dmacman1962]

Bingo!

I am curious why that was causing the problem.

Something about the "mssql_fetch_array" that differs from the mysql_fetch_array ??

Thanks,

Don

[laserlight]

Well, for the loop to end, mssql_fetch_array() (or mysql_fetch_array(), for that matter) must return a value that is evaluated to false.

But when you get a false value, the die() is evaluated, so the script stops there, and your 'end the 1st loop' message is thus not printed, even though the loop has indeed ended.

[dmacman1962]

Thanks Laserlight.

I got this to work and I will have to give this some more research/thought to completely understand why it works all the time in php/mysql but not for my query in php/sql.

Not urgent, just still trying to get my head around the whole thing.

Thanks,

Don