[RESOLVED] Results Returned Issue

gitosh

Hello people, I have raised this issue before in this forum and now I wish to visit it again since it has been a consistent problem. I'll explain this problem using an example. Here is the example code.

$sqlquery=mssql_init("Gssp_GetUserRoles",$sqlconnect);
mssql_bind($sqlquery,"@username",&$username,SQLVARCHAR);
$result=mssql_execute($sqlquery);
$numrows=mssql_num_rows($result);

In search a case, assuming the number of records in the database is five, the row count returns the actual number, therefore in this case when you echo $numrows it displays five (5) which is the correct figure. But when you echo the results, the records shown are one less the actual records, in this case four records are displayed instead of five. here is the code for displaying the results

if(mssql_fetch_array($result))
{
do
{
for ($i=0; $i<=$numrows; $i++)
  {
while($row=mssql_fetch_array($result))
  {

  $_SESSION[i]=($row['name']);
  echo $_SESSION[i];


  }
 }

  } while(mssql_next_result($result));
  }

I have realised that it's the first record that is skipped. Has anyone encountered a similar problem and what's the solution ?
Thank you all in advance. I'm using SQL 2000

Installer

It looks like you threw some control structures up in the air and left their parts where they landed. Particularly, the do and while are disjointed. And where do you define the constant i?

The first mssql_fetch_array($result) call is where your first record is lost; you never do anything with its return. It also looks like you have error_reporting turned off. That's a good way not to figure things out.

And you start the for numbering at zero and end it at equal to $numrows, so you try to retrieve one more than $numrows (two more in this case, since you've already thrown away the first row. Or, to be more precise, a total of ((($numrows + 1) * ($numrows +1)) + 1), considering you have the while loop inside the for loop). Again, error reporting should have alerted you to that.

Try this:

if ($numrows) { 
    for ($i = 0; $i < $numrows; $i++) {
        $row = mssql_fetch_array($result)) { 
        $_SESSION[$i] = $row['name']; 
        echo $_SESSION[$i]; 
    } 
}

gitosh

Thanks alot installer, you're right, my first row was being lost at this point

 if(mssql_fetch_array($result)){..........

I've replaced that with

 if ($numrows){........

Piranha

You should replace the rest of the code as well with the code Installer gave you. It does the same thing, but does it correctly. If you don't understand why your code is not correct take a paper and a pen and follow what your code does and you will see what is wrong.

Installer

But be sure to replace this line (in my code):

$row = mssql_fetch_array($result)) {

with:

$row = mssql_fetch_array($result);

😉