[RESOLVED] new newbie deleting checked arrays

verN

hi everyone, I've got a problem here I am trying to delete the selected check box (s) that a user selects and then they clikc on a delete button to delete that particular elemnt. I have used an array of checkboxes to keep track of the values and I have used echo to ensure that the value is passed but the elements do not get deleted eventhough the variable holds to the email address that it needs to delete here's the code have a look and let me know what i'm doing wrong

                    [code=php]if(isset($_POST['Delete'])) {
        	            $dels = $_POST['e'];
            foreach($dels as $key => $value) {

                        $qu = "DELETE FROM mailinglists WHERE seminarID= 1                            AND emailAddress='$value'";

                       echo $qu;
                       echo '<br />';
                       echo $value;
                       $res=@mysql_query($qu,$dbc);

         }

                     if($res > 0) {
         	        echo '<h1 id="mainhead">Deleted</h1>';
                    }else {
         	        echo '<h1 id="mainhead">Error</h1>';
                    }   }
                     [/COLOR]

$qu= "SELECT emailAddress FROM mailinglists WHERE seminarID = 1";
$sol=@($qu);
$num_rows = mysql_num_rows($sol);

            if($num_rows > 0) {
echo '<table width="403" border="0" align="center" bgcolor="#ffffff">';
		// this retrieves the results
	while ($row=mysql_fetch_array($sol, MYSQL_ASSOC)) {
		$eAdd = $row['emailAddress'];

	    // create a row for printing the results (email addresses)				
echo '<tr><td align="left"><input type="checkbox" name="e[]" value="<?=$eAdd?>';
		echo $eAdd;
		echo '" title=' . $eAdd . '>';
        echo $eAdd . '</input>
        </td></tr>';   
		}



        echo '<tr><td>

<input name="Delete" type="submit" value="Delete selected email address (s)" >
</td></tr></table>';
}[/code]

Thanks in advance

leatherback

Hi,

PLease
1) Place your code between [php ] [ /php] tags (without spaces) which will highlight the code, and make it easier to spot typos.
2) Remote the @ signs in front of the mysql_query() commands, as this will trigger the silent mode (No errors returned)
3) Place or die(mysql_error()) after each query statement, which will tell you WHAT went wrong in the query.
4) Post back the errors, if the error alone is nonsense to you (Which it propb. is! ;-))

verN

<?   

            // checks whether to process the delete function 
            if(isset($_POST['Delete'])) {


		 	$dels = $_POST['e'];
            foreach($dels as $key => $value) {
              //su = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='niles'";
              $qu = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='$value'";
              //".$value;
              echo $qu;
              echo '<br />';
              echo $value;
              $res=mysql_query($qu,$dbc) or die(mysql_error());

            }

         if($res > 0) {
         	echo '<h1 id="mainhead">Deleted</h1>';
         }else {
         	echo '<h1 id="mainhead">Error</h1>';
         }
		 }
?>

 <form method="post" action="mailingLists.php" name="form2" onSubmit="">
<?                     

	        $qu= "SELECT emailAddress FROM mailinglists WHERE seminarID =1";
			$sol=mysql_query($qu) or die(mysql_error());
			$num_rows = mysql_num_rows($sol);


		if($num_rows > 0) {

		echo '<table width="403" border="0" align="center" bgcolor="#ffffff">';
		// this retrieves the results
		while ($row=mysql_fetch_array($sol, MYSQL_ASSOC)) {
		$eAdd = $row['emailAddress'];

	    // create a row for printing the results (email addresses)				
		echo '<tr><td align="left"><input type="checkbox" name="e[]" value="<?=$eAdd?>';
		echo $eAdd;
		echo '" title=' . $eAdd . '>';
        echo $eAdd . '</input>
        </td></tr>';   
		}



        echo '<tr><td>
		<input name="Delete" type="submit" value="Delete selected email address (s)" >
		</td></tr></table>';
		}
?>

Hi,
I have made changes however I still have the same mistake where I have used echo and the value passed stores the email address selected. when I used echo for the query again this comes up
DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress=example@example.com'

however in my database the email address doesn't get deleted help.
thanks

ClarkF1

Please use php tags around your code [PHP ] [/ PHP] (remove spaces)

verN

<?php 
// checks whether to process the delete function 
if(isset($_POST['Delete'])) {
$dels = $_POST['e'];
foreach($dels as $key => $value) {
$qu = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='$value'";
//".$value;
echo $qu;
echo '<br />';
echo $value;
$res=mysql_query($qu,$dbc) or die(mysql_error());
}
if($res > 0) {
echo '<h1 id="mainhead">Deleted</h1>';
}else {
echo '<h1 id="mainhead">Error</h1>';
}
}
?>

<form method="post" action="mailingLists.php" name="form2" onSubmit="">
<?php 
$qu= "SELECT emailAddress FROM mailinglists WHERE seminarID =1";
$sol=mysql_query($qu) or die(mysql_error());
$num_rows = mysql_num_rows($sol);

if($num_rows > 0) {
echo '<table width="403" border="0" align="center" bgcolor="#ffffff">';
// this retrieves the results
while ($row=mysql_fetch_array($sol, MYSQL_ASSOC)) {
$eAdd = $row['emailAddress'];
// create a row for printing the results (email addresses) 
echo '<tr><td align="left"><input type="checkbox" name="e[]" value="<?=$eAdd?>';
echo $eAdd;
echo '" title=' . $eAdd . '>';
echo $eAdd . '</input>
</td></tr>'; 
}
echo '<tr><td>
<input name="Delete" type="submit" value="Delete selected email address (s)" >
</td></tr></table>';
}
?>

I think there's something wrong with the delete query becaue when a particular checkbox is selected that value gets stored. Please help this problem is bugging me and i don't know why it foesn't work

thanks

bradgrafelman

Just out of curiosity, is there any reason why you've ignored the request (twice) to put your code between the board's PHP bbcode tags? Perhaps the "third time's a charm":

When posting PHP code, please use the board's [PHP][/PHP] bbcode tags - they make the code much, much easier to read (as well as aiding the diagnosis of syntax errors). You should edit your post now and add these bbcode tags to help others in reading/analyzing your code.

verN

hiyya,

im sorry this is the first time I am using the forums on this site when I read the previous posts I assumed it meant adding the php tags which I had done. I still don't undertandat what you mean by the

bbcode tags could you explain further is it the icon next to <> which says php on the paper
if so my appologies here's the code if it isn't could you let me know
thanks

<?php 
// checks whether to process the delete function 
if(isset($_POST['Delete'])) {
$dels = $_POST['e'];
foreach($dels as $key => $value) {
$qu = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='$value'";
//".$value;
echo $qu;
echo '<br />';
echo $value;
$res=mysql_query($qu,$dbc) or die(mysql_error());
}
if($res > 0) {
echo '<h1 id="mainhead">Deleted</h1>';
}else {
echo '<h1 id="mainhead">Error</h1>';
}
}
?>

<form method="post" action="mailingLists.php" name="form2" onSubmit="">
<?php 
$qu= "SELECT emailAddress FROM mailinglists WHERE seminarID =1";
$sol=mysql_query($qu) or die(mysql_error());
$num_rows = mysql_num_rows($sol);

if($num_rows > 0) {
echo '<table width="403" border="0" align="center" bgcolor="#ffffff">';
// this retrieves the results
while ($row=mysql_fetch_array($sol, MYSQL_ASSOC)) {
$eAdd = $row['emailAddress'];
// create a row for printing the results (email addresses) 
echo '<tr><td align="left"><input type="checkbox" name="e[]" value="<?=$eAdd?>';
echo $eAdd;
echo '" title=' . $eAdd . '>';
echo $eAdd . '</input>
</td></tr>'; 
}
echo '<tr><td>
<input name="Delete" type="submit" value="Delete selected email address (s)" >
</td></tr></table>';
}
?>

bradgrafelman

So when you submit the form, do the queries show up? Have you tried echo'ing out [man]mysql_affected_rows/man to see if any rows were matched (after you run the DELTE query, obviously) ?

EDIT: Oops, found your problem. Look at this part:

echo '<tr><td align="left"><input type="checkbox" name="e[]" value="<?=$eAdd?>'; 
echo $eAdd; 
echo '" title=' . $eAdd . '>'; 
echo $eAdd . '</input> 
</td></tr>';

I don't know why you split it into 4 different echo's, but essentially, you're outputting something like this:

<tr><td align="left"><input type="checkbox" name="e[]" value="<?=$eAdd?>example@example.com" title=example@example.com>example@example.com </input>
</td></tr>

Notice the problems?

You have that <?=$eAdd?> junk in the value="" part. Looks like this code originaly used the short tag syntax to place the e-mail address in there, but you have since tried to modify it. Remove this extra code.
You should probably surround the title= value in quotes.

verN

// create a row for printing the results (email addresses)echo '<tr><td align="left">
<input type="checkbox" name="e[]" value=";
			echo $eAdd;
			echo " title=' . $eAdd . '>';
            echo $eAdd . '</input>
            </td></tr>';   

			}

I am now getting th following problem-
DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='; echo $eAdd; echo '

its to do with the "" help!

verN

Yes, finally its working the solution is below for deleting the selected checkboxes, it was to do with the checkbox value
thanks for your help

<?    

        // checks whether to process the delete function 
            if(isset($_POST['Delete'])) {


		 	$dels = $_POST['e'];
            foreach($dels as $key => $value) {
              $delete_query = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='$value'";

              //".$value;
              echo $delete_query;
              echo '<br />';
              //echo $value;
              $delete_result=@mysql_query($delete_query,$dbc);

            }

            if (mysql_affected_rows() == 1) {
         	echo '<h1 id="mainhead">Deleted</h1>';
               } else {
         	   echo '<h1 id="mainhead">Error</h1>';
               }
	  }
?>

<?                     

	        $select_query= "SELECT emailAddress FROM mailinglists WHERE seminarID =1";
			$select_result=@mysql_query($select_query,$dbc);

		if (mysql_num_rows($select_result) > 0) {


		echo '<table width="403" border="0" align="center" bgcolor="#ffffff">';
		// this retrieves the results
		while ($row=mysql_fetch_array($select_result, MYSQL_ASSOC)) {
		$eAdd = $row['emailAddress'];

	    // create a row for printing the results (email addresses)				
		//echo '<tr><td align="left"><input type="checkbox" name="e[]" value="';
		echo $eAdd;
		echo '" title=' . $eAdd . '>';
        echo $eAdd . '</input>
        </td></tr>';   
		}

        echo '<tr><td>
		<input name="Delete" type="submit" value="Delete selected email address (s)" >
		</td></tr></table>';
		}
?>

bradgrafelman

Looks like your script might possibly be open to a SQL injection vulnerability. You need to sanitize all user-supplied data with a function like [man]mysql_real_escape_string/man before you ever use it in a query.

verN

Hi is this correct, by the way thank you for teaching me somehting new

$dels = $_POST['e'];
	            foreach($dels as $key => $value) {
                  //$delete_query = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='n@hotm.com'";
                  $delete_query = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='$value'";
                  mysql_real_escape_string($value);

bradgrafelman

What you want to do is replace the contents of $value with what is returned by that function, and use that new value in your query... like this:

$value = mysql_real_escape_string($value);
$delete_query = "DELETE FROM mailinglists WHERE seminarID= 1 AND emailAddress='$value'";