Contact Form Trouble

[gerard]

Hi

I've been using this adapted contact form for a number of years on my server without problems, but now it's throwing up error messages on a different server:

Notice: Undefined variable: REMOTE_ADDR in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab.php on line 37

Notice: Undefined variable: REMOTE_ADDR in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab.php on line 39

Notice: Undefined variable: action in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab.php on line 42

I'm afraid I've no idea what this means or how to fix it. Any idea what I can do?

Here's the contact form code:

<?  

// Enter your email address here
$adminaddress = "[e-mail]"; 

// Enter the address of your website here MUST include http://www. 
$siteaddress ="http://www.abisti.co.uk"; 

// Enter your company name or site name here 
$sitename = "Abisti Web Design"; 

// Enter your page title here
$ptitle = "Contact Form ";

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = "#FFFFFF";

//Table Border
$bocolor = "#FFFFFF";

// Font Colour
$fcolor = "#000099";

// Link Colour
$lcolor = "#0000ff";

// Font Style
$font = "verdana";

// Font Size
$fontsize = "3";

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date("m/d/Y H:i:s");
$vers = "VinceMail V1.1";
$traceroute = "<a href=\"http://www.above.net/cgi-bin/trace?$REMOTE_ADDR\">";

if ($REMOTE_ADDR == "") $ip = "<i> no ip </i>";
else $ip = getHostByAddr($REMOTE_ADDR);

IF ($action==""): 
?> <br />
<FORM name=validation METHOD=POST ACTION="<? echo "$PHP_SELF"; ?>" onSubmit="return checkbae()"> 
<table border="0" cellspacing="0" cellpadding="2" width="90%">
  <tr> 
    <td valign="TOP"> 
      <center>
          <table border="0" cellspacing="0" cellpadding="3" width="100%">
            <tr> 
              <td valign="TOP" colspan=2><span class="strong"><? echo "$ptitle"; ?><br />
                </span> 
                <p align="left">&nbsp;</p>
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Your 
                First Name:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="fname" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Your 
                Last Name:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="lname" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Your 
                Email:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="vemail" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Company 
                Name:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="cname" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Tel 
                no:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="telno" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" height="34">How 
                did you find out about Abisti?</td>
              <td valign="middle" height="34"> 
                <select name="refer">
<option value="Rec">Please specify...</option>                  

<option value="Rec">Recommendation</option>
                  <option value="Google">Google</option>
                  <option value="UKWDA">UK Web Designers Association</option>
                  <option value="YP">Yellow Pages</option>
				   <option value="Yell">Yell.Com</option>
				    <option value="BT Book">BT Phonebook</option>
                  <option value="Other SE">Other Search Engine</option>
                  <option value="Other Ad">Other Advertising</option>
                  <option value="Link">Link from Abisti Designed Site</option>
                  <option value="Other">Other</option>
                </select>
              </td>
            </tr>
            <tr> 
              <td valign="TOP" colspan="2"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>">Additional 
                Comments:</td>
            </tr>
            <tr> 
              <td valign="TOP" colspan="2"> 
                <textarea name="comments" rows="10" cols="40" class="textformbox" ></textarea>
              </td>
            </tr>
            <tr> 
              <td colspan=2> 
                <input type="submit" name="action" value="Send" class="sendbutton">
                <input type="reset" name="Reset" value="Reset" class="sendbutton">
              </td>
            </tr>
          </table>
      </center>
    </td>
  </tr>
</table>
<script type="text/javascript">

var testresults

function checkemail(){

var str=document.validation.vemail.value

var filter=/^.+@.+\..{2,3}$/

if (filter.test(str))

testresults=true

else{

alert("Please input a valid email address!")

testresults=false

}

return (testresults)

}

</script>
<script>

function checkbae(){

if (document.layers||document.all)

return checkemail()

else

return true

}

</script>

<?
//This grabs the form data and formats it and sends it in an email to you

ELSEIF ($action="Send"): 
mail("$adminaddress","Info Request", "FAO: Admin @ $sitename \n
First Name: $fname 
Last Name: $lname
Email: $vemail
Company: $cname
Telephone: $telno
Referrer: $refer\n
The visitor commented:
------------------------------
$comments
------------------------------

Logged Info :
------------------------------
Mailer: $vers
Using: $HTTP_USER_AGENT
Hostname: $ip
IP address: $REMOTE_ADDR
Date/Time:  $date","FROM:$adminaddress"); 

//This grabs the form data and sends a confirmation to your visitor

mail("$vemail","Thank You for visiting $sitename", "Hi $fname,\n
Thank you for your interest in $sitename!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 48hrs.\n
Best regards,
$sitename
$siteaddress","FROM:$adminaddress"); 


PRINT "<p>Hello, $fname.";
PRINT "<br /><br />";
PRINT "Thank you for your completing our form.<br /><br />";
PRINT "We will respond to $vemail , as soon as possible.<br /></p>";
ENDIF;
?>

</form>

[PHP tags added by moderator - bpat1434]

[bpat1434]

Seems like register globals conflict.

$REMOTE_ADDR should be: $SERVER['REMOTE_ADDR']
$action should be $POST['action']

If you search the forums here, you'll see plenty of posts about register globals and how to fix it as well.

[Houdini]

It is probably also due to use of short tags

[bpat1434]

Short tags would have no impact here. If short tags weren't enabled, you would see the source, rather than the server parsed result(s).

[gerard]

Many thanks for your replies!

I've replaced these:

$REMOTE_ADDR should be: $SERVER['REMOTE_ADDR']
$action should be $POST['action']

as suggested, but now get this error message:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab.php on line 37

[bpat1434]

Need the new code....

Well, this is line 37:

$traceroute = "<a href=\"http://www.above.net/cgi-bin/trace?$REMOTE_ADDR\">";

You may want to change it to this:

$traceroute = '<a href="http://www.above.net/cgi-bin/trace?' . $_SERVER['REMOTE_ADDR'] . '">';

[gerard]

Oh, sorry, here it is...

<?  

// Enter your email address here
$adminaddress = "[e-mail]"; 

// Enter the address of your website here MUST include http://www. 
$siteaddress ="http://www.abisti.co.uk"; 

// Enter your company name or site name here 
$sitename = "Abisti Web Design"; 

// Enter your page title here
$ptitle = "Contact Form ";

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = "#FFFFFF";

//Table Border
$bocolor = "#FFFFFF";

// Font Colour
$fcolor = "#000099";

// Link Colour
$lcolor = "#0000ff";

// Font Style
$font = "verdana";

// Font Size
$fontsize = "3";

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date("m/d/Y H:i:s");
$vers = "VinceMail V1.1";
$traceroute = "<a href=\"http://www.above.net/cgi-bin/trace?$_SERVER['REMOTE_ADDR']\">";

if ($_SERVER['REMOTE_ADDR'] == "") $ip = "<i> no ip </i>";
else $ip = getHostByAddr($_SERVER['REMOTE_ADDR']);

IF ($_POST['action']==""): 
?> <br />
<FORM name=validation METHOD=POST ACTION="<? echo "$PHP_SELF"; ?>" onSubmit="return checkbae()"> 
<table border="0" cellspacing="0" cellpadding="2" width="90%">
  <tr> 
    <td valign="TOP"> 
      <center>
          <table border="0" cellspacing="0" cellpadding="3" width="100%">
            <tr> 
              <td valign="TOP" colspan=2><span class="strong"><? echo "$ptitle"; ?><br />
                </span> 
                <p align="left">&nbsp;</p>
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Your 
                First Name:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="fname" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Your 
                Last Name:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="lname" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Your 
                Email:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="vemail" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Company 
                Name:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="cname" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" width="38%">Tel 
                no:</td>
              <td valign="TOP" width="62%"> 
                <input type="text" name="telno" size="40" class="formbox" >
              </td>
            </tr>
            <tr> 
              <td valign="TOP" height="34">How 
                did you find out about Abisti?</td>
              <td valign="middle" height="34"> 
                <select name="refer">
<option value="Rec">Please specify...</option>                  

<option value="Rec">Recommendation</option>
                  <option value="Google">Google</option>
                  <option value="UKWDA">UK Web Designers Association</option>
                  <option value="YP">Yellow Pages</option>
				   <option value="Yell">Yell.Com</option>
				    <option value="BT Book">BT Phonebook</option>
                  <option value="Other SE">Other Search Engine</option>
                  <option value="Other Ad">Other Advertising</option>
                  <option value="Link">Link from Abisti Designed Site</option>
                  <option value="Other">Other</option>
                </select>
              </td>
            </tr>
            <tr> 
              <td valign="TOP" colspan="2"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>">Additional 
                Comments:</td>
            </tr>
            <tr> 
              <td valign="TOP" colspan="2"> 
                <textarea name="comments" rows="10" cols="40" class="textformbox" ></textarea>
              </td>
            </tr>
            <tr> 
              <td colspan=2> 
                <input type="submit" name="action" value="Send" class="sendbutton">
                <input type="reset" name="Reset" value="Reset" class="sendbutton">
              </td>
            </tr>
          </table>
      </center>
    </td>
  </tr>
</table>
<script type="text/javascript">

var testresults

function checkemail(){

var str=document.validation.vemail.value

var filter=/^.+@.+\..{2,3}$/

if (filter.test(str))

testresults=true

else{

alert("Please input a valid email address!")

testresults=false

}

return (testresults)

}

</script>
<script>

function checkbae(){

if (document.layers||document.all)

return checkemail()

else

return true

}

</script>

<?
//This grabs the form data and formats it and sends it in an email to you

ELSEIF ($_POST['action']="Send"): 
mail("$adminaddress","Info Request", "FAO: Admin @ $sitename \n
First Name: $fname 
Last Name: $lname
Email: $vemail
Company: $cname
Telephone: $telno
Referrer: $refer\n
The visitor commented:
------------------------------
$comments
------------------------------

Logged Info :
------------------------------
Mailer: $vers
Using: $HTTP_USER_AGENT
Hostname: $ip
IP address: $_SERVER['REMOTE_ADDR']
Date/Time:  $date","FROM:$adminaddress"); 

//This grabs the form data and sends a confirmation to your visitor

mail("$vemail","Thank You for visiting $sitename", "Hi $fname,\n
Thank you for your interest in $sitename!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 48hrs.\n
Best regards,
$sitename
$siteaddress","FROM:$adminaddress"); 


PRINT "<p>Hello, $fname.";
PRINT "<br /><br />";
PRINT "Thank you for your completing our form.<br /><br />";
PRINT "We will respond to $vemail , as soon as possible.<br /></p>";
ENDIF;
?>

</form>

[bpat1434]

Of course you could use something like this too:

<?php
// Enter your email address here
$adminaddress = '[e-mail]';

// Enter the address of your website here MUST include http://www.
$siteaddress ='http://www.abisti.co.uk';

// Enter your company name or site name here
$sitename = 'Abisti Web Design';

// Enter your page title here
$ptitle = 'Contact Form ';

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = '#FFFFFF';

//Table Border
$bocolor = '#FFFFFF';

// Font Colour
$fcolor = '#000099';

// Link Colour
$lcolor = '#0000ff';

// Font Style
$font = 'verdana';

// Font Size
$fontsize = '3';

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date('m/d/Y H:i:s');
$vers = 'VinceMail V1.1';
$traceroute = '<a href="http://www.above.net/cgi-bin/trace?'.$_SERVER['REMOTE_ADDR'].'">';

if ($_SERVER['REMOTE_ADDR'] == '') $ip = '<i> no ip </i>';
else $ip = getHostByAddr($_SERVER['REMOTE_ADDR']);

IF ($_POST['action']==''){
?> <br />
<form name="validation" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>" onSubmit="return checkbae()">
<table border="0" cellspacing="0" cellpadding="2" width="90%">
  <tr>
    <td valign="TOP">
      <center>
          <table border="0" cellspacing="0" cellpadding="3" width="100%">
            <tr>
              <td valign="TOP" colspan=2><span class="strong"><?php echo $ptitle; ?><br />
                </span>
                <p align="left">&nbsp;</p>
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                First Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="fname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Last Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="lname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Email:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="vemail" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Company
                Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="cname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Tel
                no:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="telno" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" height="34">How
                did you find out about Abisti?</td>
              <td valign="middle" height="34">
                <select name="refer">
				  <option value="Rec">Please specify...</option>                  

				  <option value="Rec">Recommendation</option>
                  <option value="Google">Google</option>
                  <option value="UKWDA">UK Web Designers Association</option>
                  <option value="YP">Yellow Pages</option>
                  <option value="Yell">Yell.Com</option>
                  <option value="BT Book">BT Phonebook</option>
                  <option value="Other SE">Other Search Engine</option>
                  <option value="Other Ad">Other Advertising</option>
                  <option value="Link">Link from Abisti Designed Site</option>
                  <option value="Other">Other</option>
                </select>
              </td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2"><font face="<?php echo $font; ?>" size="<?php echo $fontsize; ?>" color="<?php echo $fcolor; ?>">Additional
                Comments:</td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2">
                <textarea name="comments" rows="10" cols="40" class="textformbox" ></textarea>
              </td>
            </tr>
            <tr>
              <td colspan=2>
                <input type="submit" name="action" value="Send" class="sendbutton">
                <input type="reset" name="Reset" value="Reset" class="sendbutton">
              </td>
            </tr>
          </table>
      </center>
    </td>
  </tr>
</table>
<script type="text/javascript">
var testresults

function checkemail(){
	var str=document.validation.vemail.value
	var filter=/^.+@.+\..{2,3}$/

if (filter.test(str))
	testresults=true
else{
	alert("Please input a valid email address!")
	testresults=false
}
return (testresults)
}

function checkbae(){
	if (document.layers||document.all)
		return checkemail()
	else
		return true
}
</script>

<?php
}
//This grabs the form data and formats it and sends it in an email to you

ELSEIF ($_POST['action']=='Send') {
	$message = sprintf('FAO: Admin @ %s

First Name: %s
Last Name: %s
Email: %s
Company: %s
Telephone: %s
Referrer: %s

The visitor commented:
------------------------------
%s
------------------------------

Logged Info :
------------------------------
Mailer: %s
Using: %s
Hostname: %s
IP address: %s
Date/Time:  %s', $adminaddress, $_POST['fname'], $_POST['lname'], $_POST['vemail'],
	$_POST['cname'], $_POST['telno'], $_POST['refer'], $_POST['comments'], $vers,
	$_SERVER['HTTP_USER_AGENT'], $ip, $date);
$tymessage = sprintf('Hi %2$s,
Thank you for your interest in %1$s!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 48hrs.

Best regards,
%1$s
%3$s', $sitename, $_POST['fname'], $adminaddress);

//This grabs the form data and sends a confirmation to your visitor
mail($adminaddress,'Info Request', $message, 'FROM:'.$adminaddress);
mail($_POST['vemail'],'Thank You for visiting '.$sitename, $tymessage,'FROM:'.$adminaddress);


echo '<p>Hello, ' . $_POST['fname'] . '<br /><br />
Thank you for your completing our form.<br /><br />
We will respond to ' . $_POST['vemail'] . ', as soon as possible.<br /></p>';
}
?>

</form>

Which would be more forward compliant with PHP.

[gerard]

Thanks!

Both of these solutions throw up this message:

Notice: Undefined index: action in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab2.php on line 42

<?php
// Enter your email address here
$adminaddress = '[e-mail]';

// Enter the address of your website here MUST include http://www.
$siteaddress ='http://www.abisti.co.uk';

// Enter your company name or site name here
$sitename = 'Abisti Web Design';

// Enter your page title here
$ptitle = 'Contact Form ';

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = '#FFFFFF';

//Table Border
$bocolor = '#FFFFFF';

// Font Colour
$fcolor = '#000099';

// Link Colour
$lcolor = '#0000ff';

// Font Style
$font = 'verdana';

// Font Size
$fontsize = '3';

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date('m/d/Y H:i:s');
$vers = 'VinceMail V1.1';
$traceroute = '<a href="http://www.above.net/cgi-bin/trace?'.$_SERVER['REMOTE_ADDR'].'">';

if ($_SERVER['REMOTE_ADDR'] == '') $ip = '<i> no ip </i>';
else $ip = getHostByAddr($_SERVER['REMOTE_ADDR']);

IF ($_POST['action']==''){
?> <br />
<form name="validation" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>" onSubmit="return checkbae()">
<table border="0" cellspacing="0" cellpadding="2" width="90%">
  <tr>
    <td valign="TOP">
      <center>
          <table border="0" cellspacing="0" cellpadding="3" width="100%">
            <tr>
              <td valign="TOP" colspan=2><span class="strong"><?php echo $ptitle; ?><br />
                </span>
                <p align="left">&nbsp;</p>
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                First Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="fname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Last Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="lname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Email:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="vemail" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Company
                Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="cname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Tel
                no:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="telno" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" height="34">How
                did you find out about Abisti?</td>
              <td valign="middle" height="34">
                <select name="refer">
                  <option value="Rec">Please specify...</option>                  

                  <option value="Rec">Recommendation</option>
                  <option value="Google">Google</option>
                  <option value="UKWDA">UK Web Designers Association</option>
                  <option value="YP">Yellow Pages</option>
                  <option value="Yell">Yell.Com</option>
                  <option value="BT Book">BT Phonebook</option>
                  <option value="Other SE">Other Search Engine</option>
                  <option value="Other Ad">Other Advertising</option>
                  <option value="Link">Link from Abisti Designed Site</option>
                  <option value="Other">Other</option>
                </select>
              </td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2"><font face="<?php echo $font; ?>" size="<?php echo $fontsize; ?>" color="<?php echo $fcolor; ?>">Additional
                Comments:</td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2">
                <textarea name="comments" rows="10" cols="40" class="textformbox" ></textarea>
              </td>
            </tr>
            <tr>
              <td colspan=2>
                <input type="submit" name="action" value="Send" class="sendbutton">
                <input type="reset" name="Reset" value="Reset" class="sendbutton">
              </td>
            </tr>
          </table>
      </center>
    </td>
  </tr>
</table>
<script type="text/javascript">
var testresults

function checkemail(){
    var str=document.validation.vemail.value
    var filter=/^.+@.+\..{2,3}$/

if (filter.test(str))
    testresults=true
else{
    alert("Please input a valid email address!")
    testresults=false
}
return (testresults)
}

function checkbae(){
    if (document.layers||document.all)
        return checkemail()
    else
        return true
}
</script>

<?php
}
//This grabs the form data and formats it and sends it in an email to you

ELSEIF ($_POST['action']=='Send') {
    $message = sprintf('FAO: Admin @ %s

First Name: %s
Last Name: %s
Email: %s
Company: %s
Telephone: %s
Referrer: %s

The visitor commented:
------------------------------
%s
------------------------------

Logged Info :
------------------------------
Mailer: %s
Using: %s
Hostname: %s
IP address: %s
Date/Time:  %s', $adminaddress, $_POST['fname'], $_POST['lname'], $_POST['vemail'],
    $_POST['cname'], $_POST['telno'], $_POST['refer'], $_POST['comments'], $vers,
    $_SERVER['HTTP_USER_AGENT'], $ip, $date);
$tymessage = sprintf('Hi %2$s,
Thank you for your interest in %1$s!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 48hrs.

Best regards,
%1$s
%3$s', $sitename, $_POST['fname'], $adminaddress);

//This grabs the form data and sends a confirmation to your visitor
mail($adminaddress,'Info Request', $message, 'FROM:'.$adminaddress);
mail($_POST['vemail'],'Thank You for visiting '.$sitename, $tymessage,'FROM:'.$adminaddress);


echo '<p>Hello, ' . $_POST['fname'] . '<br /><br />
Thank you for your completing our form.<br /><br />
We will respond to ' . $_POST['vemail'] . ', as soon as possible.<br /></p>';
}
?>

</form>

[gerard]

... I should add that I'm quite happy to lose the remote address bit if it's easier, but I'm not sure which bits to remove.

[bpat1434]

Okay, change this:

<input type="submit" name="action" value="Send" class="sendbutton">

to this:

<input type="hidden" name="action" value="Send" />
<input type="submit" name="submit" value="Send" class="sendbutton" />

[gerard]

Hi

I've done this but am still getting the following message:

Notice: Undefined index: action in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab2.php on line 42

<?php
// Enter your email address here
$adminaddress = '[e-mail]';

// Enter the address of your website here MUST include http://www.
$siteaddress ='http://www.abisti.co.uk';

// Enter your company name or site name here
$sitename = 'Abisti Web Design';

// Enter your page title here
$ptitle = 'Contact Form ';

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = '#FFFFFF';

//Table Border
$bocolor = '#FFFFFF';

// Font Colour
$fcolor = '#000099';

// Link Colour
$lcolor = '#0000ff';

// Font Style
$font = 'verdana';

// Font Size
$fontsize = '3';

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date('m/d/Y H:i:s');
$vers = 'VinceMail V1.1';
$traceroute = '<a href="http://www.above.net/cgi-bin/trace?'.$_SERVER['REMOTE_ADDR'].'">';

if ($_SERVER['REMOTE_ADDR'] == '') $ip = '<i> no ip </i>';
else $ip = getHostByAddr($_SERVER['REMOTE_ADDR']);

IF ($_POST['action']==''){
?> <br />
<form name="validation" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>" onSubmit="return checkbae()">
<table border="0" cellspacing="0" cellpadding="2" width="90%">
  <tr>
    <td valign="TOP">
      <center>
          <table border="0" cellspacing="0" cellpadding="3" width="100%">
            <tr>
              <td valign="TOP" colspan=2><span class="strong"><?php echo $ptitle; ?><br />
                </span>
                <p align="left">&nbsp;</p>
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                First Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="fname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Last Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="lname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Email:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="vemail" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Company
                Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="cname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Tel
                no:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="telno" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" height="34">How
                did you find out about Abisti?</td>
              <td valign="middle" height="34">
                <select name="refer">
                  <option value="Rec">Please specify...</option>                  

                  <option value="Rec">Recommendation</option>
                  <option value="Google">Google</option>
                  <option value="UKWDA">UK Web Designers Association</option>
                  <option value="YP">Yellow Pages</option>
                  <option value="Yell">Yell.Com</option>
                  <option value="BT Book">BT Phonebook</option>
                  <option value="Other SE">Other Search Engine</option>
                  <option value="Other Ad">Other Advertising</option>
                  <option value="Link">Link from Abisti Designed Site</option>
                  <option value="Other">Other</option>
                </select>
              </td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2"><font face="<?php echo $font; ?>" size="<?php echo $fontsize; ?>" color="<?php echo $fcolor; ?>">Additional
                Comments:</td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2">
                <textarea name="comments" rows="10" cols="40" class="textformbox" ></textarea>
              </td>
            </tr>
            <tr>
              <td colspan=2>
               <input type="hidden" name="action" value="Send" />
<input type="submit" name="submit" value="Send" class="sendbutton" />
                <input type="reset" name="Reset" value="Reset" class="sendbutton">
              </td>
            </tr>
          </table>
      </center>
    </td>
  </tr>
</table>
<script type="text/javascript">
var testresults

function checkemail(){
    var str=document.validation.vemail.value
    var filter=/^.+@.+\..{2,3}$/

if (filter.test(str))
    testresults=true
else{
    alert("Please input a valid email address!")
    testresults=false
}
return (testresults)
}

function checkbae(){
    if (document.layers||document.all)
        return checkemail()
    else
        return true
}
</script>

<?php
}
//This grabs the form data and formats it and sends it in an email to you

ELSEIF ($_POST['action']=='Send') {
    $message = sprintf('FAO: Admin @ %s

First Name: %s
Last Name: %s
Email: %s
Company: %s
Telephone: %s
Referrer: %s

The visitor commented:
------------------------------
%s
------------------------------

Logged Info :
------------------------------
Mailer: %s
Using: %s
Hostname: %s
IP address: %s
Date/Time:  %s', $adminaddress, $_POST['fname'], $_POST['lname'], $_POST['vemail'],
    $_POST['cname'], $_POST['telno'], $_POST['refer'], $_POST['comments'], $vers,
    $_SERVER['HTTP_USER_AGENT'], $ip, $date);
$tymessage = sprintf('Hi %2$s,
Thank you for your interest in %1$s!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 48hrs.

Best regards,
%1$s
%3$s', $sitename, $_POST['fname'], $adminaddress);

//This grabs the form data and sends a confirmation to your visitor
mail($adminaddress,'Info Request', $message, 'FROM:'.$adminaddress);
mail($_POST['vemail'],'Thank You for visiting '.$sitename, $tymessage,'FROM:'.$adminaddress);


echo '<p>Hello, ' . $_POST['fname'] . '<br /><br />
Thank you for your completing our form.<br /><br />
We will respond to ' . $_POST['vemail'] . ', as soon as possible.<br /></p>';
}
?>

</form>

[bpat1434]

Oh, duh....

When you first start the page, the $_POST array isn't populated yet. So thus "action" won't be a key in the array. So on line 42, we need to change how we check if the form is submitted. It can be done like so:

change

IF ($_POST['action']==''){

to

IF (!isset($_POST) && !empty($_POST) && !empty($_POST['action'])){

If the $_POST array is set, it will check if it has any keys. If it does, it will see if the "action" key is empty (null, 0, or an empty string"''"). If any 1 of those are true, it will show the form; otherwise, it will skip to the Elseif statement below.

[WARNING] I updated the code a bit.... forgot a "!" in front of the isset() call.

[gerard]

Hi there

I've done as instructed but am still getting:

Notice: Undefined index: action in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab.php on line 159

<?php
// Enter your email address here
$adminaddress = '[e-mail]';

// Enter the address of your website here MUST include http://www.
$siteaddress ='http://www.abisti.co.uk';

// Enter your company name or site name here
$sitename = 'Abisti Web Design';

// Enter your page title here
$ptitle = 'Contact Form ';

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = '#FFFFFF';

//Table Border
$bocolor = '#FFFFFF';

// Font Colour
$fcolor = '#000099';

// Link Colour
$lcolor = '#0000ff';

// Font Style
$font = 'verdana';

// Font Size
$fontsize = '3';

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date('m/d/Y H:i:s');
$vers = 'VinceMail V1.1';
$traceroute = '<a href="http://www.above.net/cgi-bin/trace?'.$_SERVER['REMOTE_ADDR'].'">';

if ($_SERVER['REMOTE_ADDR'] == '') $ip = '<i> no ip </i>';
else $ip = getHostByAddr($_SERVER['REMOTE_ADDR']);

IF (!isset($_POST) && !empty($_POST) && !empty($_POST['action'])){ 
?> <br />
<form name="validation" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>" onSubmit="return checkbae()">
<table border="0" cellspacing="0" cellpadding="2" width="90%">
  <tr>
    <td valign="TOP">
      <center>
          <table border="0" cellspacing="0" cellpadding="3" width="100%">
            <tr>
              <td valign="TOP" colspan=2><span class="strong"><?php echo $ptitle; ?><br />
                </span>
                <p align="left">&nbsp;</p>
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                First Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="fname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Last Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="lname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Your
                Email:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="vemail" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Company
                Name:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="cname" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" width="38%">Tel
                no:</td>
              <td valign="TOP" width="62%">
                <input type="text" name="telno" size="40" class="formbox" >
              </td>
            </tr>
            <tr>
              <td valign="TOP" height="34">How
                did you find out about Abisti?</td>
              <td valign="middle" height="34">
                <select name="refer">
                  <option value="Rec">Please specify...</option>                  

                  <option value="Rec">Recommendation</option>
                  <option value="Google">Google</option>
                  <option value="UKWDA">UK Web Designers Association</option>
                  <option value="YP">Yellow Pages</option>
                  <option value="Yell">Yell.Com</option>
                  <option value="BT Book">BT Phonebook</option>
                  <option value="Other SE">Other Search Engine</option>
                  <option value="Other Ad">Other Advertising</option>
                  <option value="Link">Link from Abisti Designed Site</option>
                  <option value="Other">Other</option>
                </select>
              </td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2"><font face="<?php echo $font; ?>" size="<?php echo $fontsize; ?>" color="<?php echo $fcolor; ?>">Additional
                Comments:</td>
            </tr>
            <tr>
              <td valign="TOP" colspan="2">
                <textarea name="comments" rows="10" cols="40" class="textformbox" ></textarea>
              </td>
            </tr>
            <tr>
              <td colspan=2>
               <input type="hidden" name="action" value="Send" />
<input type="submit" name="submit" value="Send" class="sendbutton" />
                <input type="reset" name="Reset" value="Reset" class="sendbutton">
              </td>
            </tr>
          </table>
      </center>
    </td>
  </tr>
</table>
<script type="text/javascript">
var testresults

function checkemail(){
    var str=document.validation.vemail.value
    var filter=/^.+@.+\..{2,3}$/

if (filter.test(str))
    testresults=true
else{
    alert("Please input a valid email address!")
    testresults=false
}
return (testresults)
}

function checkbae(){
    if (document.layers||document.all)
        return checkemail()
    else
        return true
}
</script>

<?php
}
//This grabs the form data and formats it and sends it in an email to you

ELSEIF ($_POST['action']=='Send') {
    $message = sprintf('FAO: Admin @ %s

First Name: %s
Last Name: %s
Email: %s
Company: %s
Telephone: %s
Referrer: %s

The visitor commented:
------------------------------
%s
------------------------------

Logged Info :
------------------------------
Mailer: %s
Using: %s
Hostname: %s
IP address: %s
Date/Time:  %s', $adminaddress, $_POST['fname'], $_POST['lname'], $_POST['vemail'],
    $_POST['cname'], $_POST['telno'], $_POST['refer'], $_POST['comments'], $vers,
    $_SERVER['HTTP_USER_AGENT'], $ip, $date);
$tymessage = sprintf('Hi %2$s,
Thank you for your interest in %1$s!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 48hrs.

Best regards,
%1$s
%3$s', $sitename, $_POST['fname'], $adminaddress);

//This grabs the form data and sends a confirmation to your visitor
mail($adminaddress,'Info Request', $message, 'FROM:'.$adminaddress);
mail($_POST['vemail'],'Thank You for visiting '.$sitename, $tymessage,'FROM:'.$adminaddress);


echo '<p>Hello, ' . $_POST['fname'] . '<br /><br />
Thank you for your completing our form.<br /><br />
We will respond to ' . $_POST['vemail'] . ', as soon as possible.<br /></p>';
}
?>

</form>

[bpat1434]

another typo... use || instead of &&

[gerard]

use || instead of &&

Not sure what you mean here - this is line 159:

ELSEIF ($_POST['action']=='Send') {

[bpat1434]

on the IF line that we changed earlier. Use "||" instead of "&&"

IF (!isset($_POST) || empty($_POST) || empty($_POST['action'])) {

[gerard]

That's got rid of all the messages on the form page - many thanks!

...But when you fill the form in, you now get this message:

Warning: sprintf() [function.sprintf]: Too few arguments in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\contactformab.php on line 182

Also, the email that's supposed to contain the filled-in form is blank....

[bpat1434]

Sorry,

Find this line (182):

        $_SERVER['HTTP_USER_AGENT'], $ip, $date);

and replace with:

        $_SERVER['HTTP_USER_AGENT'], $_SERVER['REMOTE_ADDR'], $ip, $date);

[gerard]

Thanks, that's great.

However, I got a problem when I tried to adapt the form - I thought I could get away with simply adding fields from line 321 and again on line 383. Clearly not
- on pressing submit, you get reams of the following message:

Notice: Undefined index: Hardware2 in C:\websites\LocalUser\ictspaghetti.com\public_html\CAD\subscribeform.php on line 383

...I've only put 1 down here but there's one for every form object.

I've obviously done something stupid in my attempts at adapting it.

The PHP code was too long and wouldn't allow me to put it here, so I've put up the page at: http://www.abisti.co.uk/BAsubscribeform.php