Php error - Need help fixing, won`t work with db

[djfox15]

I get the following errors:
Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result resource in /home/secrett1/public_html/trances.php on line 23
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

& instead of loading any part of the file, the whole thing is blank after that.

Here`s the coding, can anyone figure out what is wrong with it & know how to fix it:

$lev=$_SESSION['level2'];

$res = mysql_query("SELECT id, name, gallNum, URL, rating, numRates, description, views, cat, addDate, feature, literature FROM image WHERE id=$id");
if ($rows = mysql_fetch_row($res)) {
return $rows;
} else {
print (mysql_error());
}

if($submit){
$s = $sub." by ".$name;
$b= emote($bod);
mysql_query("INSERT INTO comment (imageID,subject,content,date,sender) VALUES ( '$id', '$s', '$b', NOW(),$send)")or die ( mysql_error());
mysql_query("INSERT INTO messagedata (recBoxID, sendBoxID, content, subject, isNew, date) VALUES ($rows[2], '7', 'You have a new comment on one of your trances that you have submitted.
Click here to read the comment.
This is automated message please do not reply.', 'New Comment Received', 1, NOW() )");

}
if($policy && ($lev>6)){
mysql_query("UPDATE userdata SET violations=SUM(violations,1) WHERE login='$name'");
}

$res = mysql_query("SELECT login FROM userdata WHERE id='$rows[2]'");
if ($by = mysql_fetch_row($res)) {
return $by;
} else {
print (mysql_error());
}

$res = mysql_query("SELECT icon FROM userdata WHERE id='$rows[2]'");
if ($icon = mysql_fetch_row($res)) {
return $icon;
} else {
print (mysql_error());
}

$res = mysql_query("SELECT name, id FROM imagecats WHERE id=$rows[8]");
if ($catName = mysql_fetch_row($res)) {
return $catName;
} else {
print (mysql_error());
}

$res = mysql_query("SELECT COUNT(*) FROM comment WHERE imageID='$id'");
if ($numCom = mysql_fetch_row($res)) {
return $numCom;
} else {
print (mysql_error());
}

$res = mysql_query("SELECT COUNT(*) FROM userdata WHERE imageFav='%$id%'");
if ($numFavs = mysql_fetch_row($res)) {
return $numFavs;
} else {
print (mysql_error());
}

//Update unique pageview counter
if( !$_SESSION["sess_$id"] ){
$_SESSION["sess_$id"] = "visited";
$v = $rows[7] + 1;
mysql_query("UPDATE image SET views=$v WHERE id='$id'");
}

[bradgrafelman]

1. When posting PHP code, please use the board's [PHP][/PHP] bbcode tags - they make the code much, much easier to read (as well as aiding the diagnosis of syntax errors). You should edit your post now and add these bbcode tags to help others in reading/analyzing your code.

2. Which line is line 23?

[djfox15]

if ($rows = mysql_fetch_row($res)) {

That is line 23.

[NogDog]

That error normally means your query failed due to some SQL error. Try using this format while developing your code to get some more debug info:

$query = "SELECT id, name, gallNum, URL, rating, numRates, description, views, cat, addDate, feature, literature FROM image WHERE id=$id";
$res = mysql_query($query) or die("Query failed: [$query] - " . mysql_error());

This way if it fails you'll see the query exactly as MySQL did, plus the error message that MySQL returned.

[djfox15]

This message comes up:
Query failed: [SELECT id, name, gallNum, URL, rating, numRates, description, views, cat, addDate, feature, literature FROM image WHERE id=] - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

[bradgrafelman]

Looks like $id wasn't set. Where do you define that variable?

[djfox15]

On another file profile.php, there will be a link to the trance.php file. profile.php transfers the id to trance.

[bradgrafelman]

How does it "transfer" it? Do you mean via the query string (e.g. "/profile.php?id=5") ?

If so, $id still won't be defined in your script. Instead, you should look at using $_GET['id'] (after you sanitize the data, of course - wouldn't want to be vulnerable to SQL injection attacks, now would you?).

[djfox15]

Im afraid I dont understand.

[bradgrafelman]

Okay... let's talk through it one step at a time. How is the id "transferred" ? Is it via a link on the page, e.g. http://yoursite.com/path/to/profile.php?id=5 ?

[djfox15]

profile.php would have:

<?
$n = $_SESSION['sess_name'];
$rr = rtrim($user[0]);
$rt = rtrim($n);

?>
<?
//########################################IMAGES in GALLERY####################################################
//Get each image in the users gallery
$offset = isset($_REQUIRE['offset'])?$_REQUIRE['offset']:0;

  if(!$offset || $offsett<0) $offset=0;
  $recent = 0;
while( $rows = mysql_fetch_row($res) ){
   if( $recent >= $offset && $recent < ($offset + 10 )){
	if( $recent%2 == 0 ){
	echo "<tr><td><tr><td><tr><td><tr><td><tr>";
    }
    //Display each image in gallery
    echo "<td width=16%><center><a href='trances.php?id=$rows[0]&l=$log'><img src=thumbnail.php?img=$rows[3] border=0></a>";
    echo "<br><b><a href='trances.php?id=$rows[0]&l=$log'>$rows[1]</a></b><br> $rows[5]";

//If this is the current users gallery with proper level or an admin allow edit
if( $gall==$rows[2] && $rr == $rt && $user[2] > 0 || $lev > 7) {
   echo "<br><a href='imageedit.php?id=$rows[0]'>Edit image.</a>";
}

//If this is the current users gallery or an admin allow delete
if( $rr == $rt || $lev > 7){
  echo "<br><a href='deleteimage.php?id=$rows[0]'>Delete image.</a><br>";
}

echo "</center>";
  }
  $recent = $recent + 1;
}
//########################################IMAGES in GALLERY####################################################
?>

Where the rows are called from in an earlier section of profile.php:

/* figure out what gallery is this */
$g = isset($_REQUEST['g'])?$_REQUEST['g']:false;
if($g){
  $gall = $g;
}else{
  $gall=$_SESSION['gal'];
}
$lev=isset($_SESSION['level2'])?$_SESSION['level2']:0;

/* Intercept form vars */
$submit = isset($_REQUEST['submit'])?$_REQUEST['submit']:false;
$sub = isset($_REQUEST['sub'])?$_REQUEST['sub']:'';
$name = isset($_REQUEST['name'])?$_REQUEST['name']:'';
$bod = isset($_REQUEST['bod'])?$_REQUEST['bod']:'';
$send = isset($_REQUEST['send'])?$_REQUEST['send']:0;

if($submit){
   $s = $sub." by ".$name;
   //$b= emote($bod);
   mysql_query("INSERT INTO artistcomment (userID,subject,content,date,sender) VALUES ( '$g', '$s', '$bod', NOW(),$send )")or die ( mysql_error());
   mysql_query("INSERT INTO messagedata (recBoxID, sendBoxID, content, subject, isNew, date) VALUES ($gall, '7', 'Profile Comment Recieved <br><a href=profile.php?g=$gall>Please click here to go to your profile</a>.<br>This is automated message please do not reply.', 'New Profile comment received!', 1, NOW() )");
}
//get the users information
$res = mysql_query("SELECT login, views, level, rName, age, gender, aim, yahoo, msn, icq, livejournal, bio,email, country, website,mood, status, icon, webcam, arttype FROM userdata WHERE id='$gall'");
$user = mysql_fetch_row($res);
mysql_free_result($res);

$res = mysql_query("SELECT COUNT(*) FROM userdata WHERE imageFavs='$gall'");
$numFavs = mysql_fetch_row($res);
mysql_free_result($res);

$res = mysql_query("SELECT COUNT(*) FROM artistcomment WHERE userID='$gall'");
$numCom = mysql_fetch_row($res);
mysql_free_result($res);

$res = mysql_query("SELECT COUNT(*) FROM image WHERE gallNum='$gall'");
$numImage = mysql_fetch_row($res);
mysql_free_result($res);

$res = mysql_query("SELECT id, name, gallNum, URL, description, addDate FROM image WHERE gallNum='$gall' ORDER BY id DESC");
$log = $user[0];

[bradgrafelman]

Right, so you're trying to transfer the id of the rows in the query string by using "id=$row[0]" .

When you visit /trances.php?id=5 and want to use that id number, you need to use $_GET['id'] instead of just $id. The only way you would be able to use $id without defining it in this case would be if the register_globals directive was turned on, which it should not be due to security exploits that have been discussed in great length in the past.

It's the same concept when you use $REQUEST to retrieve variables submitted in a form, only you're using $GET since you know the variables are in the query string. For more information on these two superglobals (and the rest of 'em), see this manual page: [man]variables.predefined[/man].

[djfox15]

I have no understanding of the page you just sent me, nor do I know what to do exactly on how to resolve this problem.

I tried putting $_GET['id'] in place of id. The page just goes blank.

[djfox15]

I finally got the error messages to go away but it still will not display the information from the database.