[RESOLVED] Why isn't this working properly?

[OniLink]

Hi,

This code is displaying questions and their corresponding answers. If there isn't answer provided for a question, it wont display it. I also have it so it the first 5 answere questions are visible, and the rest are hidden (only viewable when a certain button is clicked).

Anyway, it works in all cases bar two. They don't seem to be any different from any other case and both have above 5 questions, yet it only displays 5 and doesn't have a "show" the rest button.

Here is the code:

Code in my next post

[firemankurt]

whole code and or output (browser source) would be very helpful.

[OniLink]

Whole code:

echo '<tr>'."\n";
	echo '<td valign="top" class="border"><span class="sub_heading">Questions</span></td>'."\n";
	echo '<td valign="top" class="border">'."\n";

$total_questions = 20;
	$sql = 'SELECT * FROM questions';
	$result = $db->query($sql);
	$numrows = $result->num_rows;
	while ($row = $result->fetch_assoc()) {
		for ($i=1; $i<$total_questions+1; $i++) {
			$q[$i] = $row['q'.$i];
		}
	}

$sql = 'SELECT * FROM answers WHERE id = "'.$id.'" LIMIT 1';
$result = $db->query($sql);
$numrows = $result->num_rows;
while ($row = $result->fetch_assoc()) {
	for ($i=1; $i<$total_questions+1; $i++) {
		$a[$i] = $row['a'.$i];
	}
}

// questions answerd
$total_answers = 0;
for ($i=1; $i<count($a)+1; $i++) {
	if ($a[$i] != '') {
		$total_answers++;
	}
}

// display questions
$count = 1;
for ($i=1; $i<$total_questions+1; $i++) {
	if ($count == 6) {
		echo '<div id="contentQA" style="display:none">'."\n";
	}
	if ($a[$i] != '') {
		echo '<strong>'.$q[$i].'</strong><br />'."\n";
		echo $a[$i].'<br /><br />'."\n";
		$count++;
	}
}
if ($total_answers < 6) {
	echo '<div id="contentQA" style="display:none">'."\n";
}

echo '</div>'."\n";
echo '<div id="btn_QA" class="btn_QA">';
echo '<img src="media/show_hide.gif" width="91" height="13" /></div>'."\n";
}

echo '</td>'."\n";
echo '</tr>'."\n";

[bradgrafelman]

When posting PHP code, please use the board's [PHP][/PHP] bbcode tags - they make the code much, much easier to read (as well as aiding the diagnosis of syntax errors). You should edit your post now and add these bbcode tags to help others in reading/analyzing your code.

[OniLink]

Fixed in my previous post.

[scrupul0us]

first off... you have td and tr tags, but no table tag

a valid table is structured as so .:link:.

secondly, you have some CSS styling there... we need to see your stylesheet (or at least the code that controls the ID's and CLASSES used in that bit) so we can rule out that being the issue

[greenie2600]

An easier way to determine whether the problem has to do with stylesheets:

Load the page in your browser. View source. Locate the questions with which you are having problems.

If you see >5 items and a "Show" button in the source, but not in the rendered page, then you know it's a problem with your CSS (or HTML).

If you don't see them, you know it's a problem with your PHP code.

[greenie2600]

What's $id in "SELECT * FROM answers WHERE id = "'.$id.'" LIMIT 1"? That variable isn't set anywhere in this excerpt. What is that database column for? Is that the corresponding question ID?

Anyway, I'm not sure exactly what you're trying to do with some of the code above, but here's how I would code this:

$query = 'SELECT * FROM questions';
$questions = mysql_query( $questions );

while ( $question = mysql_fetch_assoc( $questions ) ) {

echo $question['question_text'];

$query = 'SELECT * FROM answers WHERE question_id = ' . $question['id'];
$answers = mysql_query( $query );

if ( mysql_num_rows( $answers ) <= 5 ) {
    // ...code to display all answers...
} else {
    // ...code to display first 5 answers plus "Show" button...
}

}

[Weedpacket]

greenie2600 wrote:

An easier way to determine whether the problem has to do with stylesheets:

If you're using Firefox, another thing you can do is turn the stylesheet off (it's the "Page Style" option in the View menu).

[OniLink]

Thanks guys, I checked the output in the browser source and it lead me to the problem.

The problem was it echoed the '<div id="contentQA" style="display:none">' twice because $count = 6 for two loops because there was no answer to the next question and therefor $count didn't go up 1.

Anyway, I've fixed it. Thanks for all your help,
~Oni.