[RESOLVED] end of line character

callico

I have a $_POST with several lines of text I'm getting from a form and I'm trying to strip off the end tag (that tall rectangle) from the end of each line.

I've tried trim and rtrim, also tried specifing what's trimmed...
e.g. $text = rtrim($text, "\n\r");
and $text = rtrim($text, "feof");

But I'm fairly certain I'm not using the right syntax or the right character or I'm just lost!:o

Thanks for your help, DC

bradgrafelman

EDIT: Woops, I didn't read carefully enough... confused EOL with EOF.

I'm confused as to what character you're seeing... any chance you can give us a link, or perhaps use the [man]ord/man function to determine the character's ASCII value? Example of doing this:

$string = "Hello!";

for($i = 0,$max = strlen($string); $i < $max; $i++)
    echo '"' . $string{$i} . '" = ' . ord($string{$i}) . '<br>';

/* outputs:
"H" = 72
"e" = 101
"l" = 108
"l" = 108
"o" = 111
"!" = 33
*/

callico

I'm still working with the code in my IDE, so it's not posted yet but I've uploaded the resultant text file.

Open it in notepad and you'll see the squares.

Thanks again, DC

bradgrafelman

callico wrote:
Open it in notepad and you'll see the squares.

Actually... heh... I don't have Microsoft's Notepad on my computer... I've replaced it with a much better alternative, Notepad2. Opening the file in Notepad2, it appears just fine with no "squares" as you're describing.

Try deleting everything but a few of those squares, and run the file through the example loop I posted above to get the ASCII values of these characters.

callico

I ran the code you suggested on the text and "13" came up. here is a partial result....

"p" = 112
"l" = 108
"e" = 101
"a" = 97
"s" = 115
"e" = 101
" " = 32
"-" = 45
" " = 13
"<" = 60
"b" = 98
"r" = 114
">" = 62
" " = 13
"<" = 60
"b" = 98
"r" = 114
">" = 62
" " = 13

Installer

If you look at the complete output, you'll see that "10" ("\n") is in there, too. The squares mean nothing more than that they're unprintable characters. Trim() doesn't work for you because it operates only on the ends of string.

Try this:

$str = str_replace(array("\r", "\n"), '', $str);

callico

Thanks Installer!

That did the trick, totally spaced out on trim's end of line function.

bradgrafelman

callico wrote:
That did the trick, totally spaced out on trim's end of line function.

You're certainly not the only one... :o

Anyway, don't forget to mark this thread resolved.

EDIT: Nevermind.. you did while I was replying. :p

NogDog

EDIT: fixed typo in replacement expression

As a more generic replacement that will handle files with linebreaks of \r\n (WinDOS) or just \r (Mac), I like to use:

$text = preg_replace('/\r\n?/', "\n", $text);

(Otherwise, in the case of \r\n from WinDOS text files, you would end up with double \n\n line breaks where one break was intended.)

callico

brad's soultion worked for me but I'm curious about the '/n' for the replacement.

Also, would I need an asterik rather than a ? to remove all \r\n occurances?

Thanks, DC

NogDog

callico wrote:
brad's soultion worked for me but I'm curious about the '/n' for the replacement.

That's me typing too fast and watching TV at the same time. It should be "\n" (in double quotes).

Also, would I need an asterik rather than a ? to remove all \r\n occurances?

The ? is just applied to the '\n', so that each each occurence of '\r\n' or just '\r' if there's not trailing '\n' will be converted to a single '\n'. So 'blah\r\nblah\rblah\r\n\r\nblah" would become 'blah\nblah\nblah\n\nblah'. If you want to reduce multiple line breaks to single line breaks, then use:

$text = preg_replace('/(\r\n?)+/', "\n", $text);

Assuming I didn't make any other typos, of course. 😉

callico

Thanks for the explanation nogdog.