Problem grabbing variable from url

Jon12345

I am having a problem getting my variable from my url. My landing page - index.php shown below - has the following code, which is used to alternate between two sales pages:

<?php $id=8; include('/home/myaccount/mysite.com/html/sta/topper.php');?>
<?php if ($f[1]==1){include "http://www.mysite.com/page1.php";}?>
<?php if ($f[1]==2){include "http://www.mysite.com/page2.php";}?>

On page1.php and page2.php I have an include that contains code that takes variables from the url. A snippet is below:

$ipaddress=$_SERVER['REMOTE_ADDR'];
$var1 = $_GET['myvariable'];

Also, on page1.php and page2.php the links that the visitor will click look like this:

"http://www.mysite.com/redirect.php?sub=<?php echo $var1; ?>&offer=abc"

Now $var1 is getting logged in my tracking system, but it doesn't seem to be echoed to the link. page1.php and page2.php work fine if I just load up those pages individually, but they do not echo the $var1 when using index.php.

What could be the cause of this?

Thanks,

Jon

scrupul0us

just a few things...

code snippet one: you dont have to open and close php tags for every line

<?php 
$id=8; 
include('/home/myaccount/mysite.com/html/sta/topper.php');
if ($f[1]==1){include "http://www.mysite.com/page1.php";}
if ($f[1]==2){include "http://www.mysite.com/page2.php";}
?>

code snippet 2: $_GET['myvariable']; is going to be looking for: index.php?myvariable= in the url... based on the provided urls i dont see that... thats why your getting a blank in your link outputs

your include paths are going to get you in trouble...

include('sta/topper.php');
if ($f[1]==1){include 'page1.php';}
if ($f[1]==2){include 'page2.php';}

Jon12345

Let me try to clarify a few things.

Firstly, the visitor is sent to: www.mysite.com/index.php?myvariable=test

Secondly, the include that points to topper.php works fine and it is the recommended path from the script supplier.

Thirdly, I believe the $_GET['myvariable']; code works as my tracking is logging myvariable in a mysql db successfully.

Is it because I am including page1.php/page2.php which holds an include with the $_GET['myvariable']; code? Should I be having some variable code in these urls:

Change from this:

{include "http://www.mysite.com/page1.php";}

To this:

{include "http://www.mysite.com/page1.php?myvariable=whatever";}

Would that do it?

el_timm

From what I see, the fundamental problem is your architecture. Why are you passing variables to include files by trying to pass them via URLs? A simplier approach would be to pass them directly via PHP:

<?php
include('sta/topper.php'); 
$myvariable = $_GET['myvariable'];
if ($f[1]==1){include 'page1.php';} 
if ($f[1]==2){include 'page2.php';} 
?>

Then page1.php and page2.php would simply use the $myvariable variable directly.

if (isset($myvariable)) { 
  // etc.
}

Also, I don't believe that "include" allows for URL wrappers. If you MUST use URLs to include files, then use file_get_contents();

echo file_get_contents('http://www.mysite.com...?myvariable=whaterver");

Jon12345

Sorry to sound ignorant but what is a URL wrapper?

bradgrafelman

'http://' is an example of a URL wrapper.

What you need to ask yourself is this: Why are you trying to parse PHP files across an HTTP connection? That's like opening up your browser, going to http://some-random-site.com/some-script.php and expecting to retrieve the PHP source code for your own parsing needs. Obviously, it can't be done, right? Well, that's what you're trying to do here in your code.

If you are trying to include a PHP file on your server, you need to use a local file path. An example might be simply

include 'page1.php';

if page1.php is in the same folder of the script doing the include'ing. If not, you can use another relative path:

include 'includes/page1.php';

And, finally, you can simply specify an absolute path (if you know it):

include '/home/myaccount/mysite.com/html/page1.php';

You had the right idea for the 'topper.php' file... same idea applies to the page1.php and page2.php files.