[RESOLVED] Parse error: parse error, unexpected ','

cabcree

Hello! I did a quick search to see if anyone else had this same error. There were some that were close...but...not this specific one: Parse error: parse error, unexpected ','

This is my code (I'm using mySQL). I know the problem area is on line 15. I've tried just writing Null and then I get another error: Could not insert record: Column count doesn't match value count at row 1/n. Some sources I looked up said it needs to be as I have it below. And this is how I feel --> :eek: <--because I'm not getting anywhere with this error.

Thank you for any help that can be provided!!

<?php
$mysqli = mysqli_connect("localhost", "***", "***", "facultytraining");

if (mysqli_connect_errno()) {
  printf("Connect failed: %s/n", mysqli_connect_error());
  exit();
} else {
  $sql = "INSERT INTO faculty_mod1 (id,
				    fname,
				    lname,
				    center,
				    score1,
				    date1)
	VALUES ('
		",
		".$_POST["fname"].",
		".$_POST["lname"].",
		".$_POST["center"].",
		".$_POST["score1"].",
		".$_POST["date1"]."
		')";

  $res = mysqli_query($mysqli, $sql);

if ($res === TRUE) {
	echo "A record has been inserted.";
} else {
	printf("Could not insert record: %s/n", mysqli_error($mysqli));
}

mysqli_close($mysqli);

}
?>

scrupul0us

  $sql = "INSERT INTO faculty_mod1 (
                    fname,
                    lname,
                    center,
                    score1,
                    date1)
    VALUES ('
        ".$_POST["fname"].",
        ".$_POST["lname"].",
        ".$_POST["center"].",
        ".$_POST["score1"].",
        ".$_POST["date1"]."
        ')";

ID is auto increment... you dont need to specify it

cabcree

thanks for your response! I originally did not have the id in there for that very reason. But I added it based on something I read in response to the error below. But just in case...I took it out again and it still comes up with this error: Could not insert record: Column count doesn't match value count at row 1/n.

scrupul0us

do: echo $sql; and post what the value of the string is

you also do know that directly placing post data into a sql query is BAD BAD BAD

each variable should at least be processed with: mysql_real_escape_string()

Piranha

You need ' signs for each value you insert in the database. Not really, but you need it for some data types, and it is not bad to do it with all types.

  $sql = "INSERT INTO faculty_mod1 (
                    fname,
                    lname,
                    center,
                    score1,
                    date1)
    VALUES (
        '".$_POST["fname"]."',
        '".$_POST["lname"]."',
        '".$_POST["center"]."',
        '".$_POST["score1"]."',
        '".$_POST["date1"]."'
        )";

And as scrupol0us said, your code is vunrable to SQL injection. Since you use mysqli you should look into prepared queries to make it safe.

Weedpacket

Since you use mysqli you should look into prepared queries to make it safe.

This can also make the query more readable, since the string would be written as a template:

"Insert into faculty_mod1 (fname, lname, center, score1, date1) Values(?,?,?,?,?)"

into which you'd then slot the actual values.

cabcree

Thanks for all the helpful advice! Unfortunately, none of it worked. What I did find out through more testing is that somehow it isn't allowing me to do more than one field at a time. Do I have it set up wrong or something?

I'm using an HTML file to pull the PHP file which is why the the values looks like this:

    VALUES (' 
        ", 
        ".$_POST["fname"].", 
        ".$_POST["lname"].", 
        ".$_POST["center"].", 
        ".$_POST["score1"].", 
        ".$_POST["date1"]." 
        ')";

As I mentioned before, I did find out through some more testing that it is only allowing me to enter one field doing this (instead of all the fields/values that I had). Does anyone know why?

nicolino101

try using single quotes ... and creating variables instead of POST Vars
ie...
$fname = $POST['fname'];
$lname = $POST['lname'];
VALUES ('$fname','$lname'); etc...

cabcree

Thanks for all your help everyone...unfortunately, none of those ideas helped. I finally figured it out though.

I had to put single quotes as well as double quotes around it. So instead of:

    VALUES (' 
        ".$_POST ["fname"].", 
         ".$_POST["lname"]." , 
        ".$_POST["center"]." , 
        ".$_POST["score1"]." , 
        ".$_POST[" date1"]." 
        ')";

It is:

 VALUES ('".$_POST["fname"]."',
'".$_POST["lname"]."')";

sigh At least I finally found the little aggravating bugger.

Piranha

Ehh... Please look carefully at my post above, I posted about that.

cabcree

OH, duh...there it is...I missed it somehow! I'm so sorry!