Help editing MySql data using PHP page

[DangerM0use]

Hi everyone,
firstly sorry if this has been asked before or posted in the wrong section. I am a newb so it probably is in the right section!! 🙂

Basically, what I am doing is creating a news site. The site has an admin section which has a new article section and an edit article section. The part I am stuck on is the edit article section. I want to be able to get the data from the database and be able to edit it using the same form that was used in the new article section.
This is the code I have for the new article page;

<?php
}
else {
//include config file
include "config.php";

// get form input
// check to make sure it's all there
// escape input values for greater safety
$title = empty($POST['title']) ? die ("ERROR: Enter a title") : mysql_escape_string($POST['title']);
$author = empty($POST['author']) ? die ("ERROR: Enter an author") : mysql_escape_string($POST['author']);
$intro = empty($POST['intro']) ? die ("ERROR: Enter an intro") : mysql_escape_string($POST['intro']);
$text = empty($POST['text']) ? die ("ERROR: Enter the text") : mysql_escape_string($POST['text']);

// open connection 
$connection = mysql_connect($host, $user, $pass) or die ("Unable to connect!"); 

// select database 
mysql_select_db($db) or die ("Unable to select database!"); 

// create query 
$query = "INSERT INTO news (title, author, intro, text) VALUES ('$title', '$author', '$intro', '$text')"; 

// execute query 
$result = mysql_query($query) or die ("Error in query: $query. ".mysql_error()); 

// print message with ID of inserted record 
echo "New record inserted with ID ".mysql_insert_id(); 

// close connection 
mysql_close($connection); 

}
?>

This is what I have so far for the edit article page;

<?php
//include config file
include "config.php";
$articleid = $_GET['id']; // fetch the artcle id from the URL

$query = "SELECT * FROM news WHERE id=".$articleid;
$result = mysql_query($query);

while($row = mysql_fetch_assoc($result)) {

}

?>

I know I am really close to being able to do it, but not sure what I need to do.
Thanks for any help that can be given.

[NogDog]

Well, assuming article ID's are unique and that we therefore should only find 1 or zero matches:

<?php
if(empty($_GET['id']))
{
   echo "<p class='error'>No article ID supplied.</p>\n";
}
else
{
   //include config file
   include "config.php";
   $query = "SELECT title, author, intro, text FROM news WHERE id=".$_GET['id'];
   $result = mysql_query($query) or die("Query failed: ".mysql_error());
   if(mysql_num_rows($result))  // found something
   {
      $row = mysql_fetch_assoc($result);
      echo "<h2 class='title'>".$row['title']."</h2>\n";
      echo "<p class='author'>".$row['author']."</p>\n";
      echo "<p class='intro'>".$row['intro']."</p>\n";
      echo "<p class='text'>".nl2br($row['text']."</p>\n";
   }
   else
   {
      echo "<p class='error'>Invalid article ID.</p>\n";
   }
}
?>

[firemankurt]

You can make page reusable.

<?php
}
else {
//include config file
include "config.php";

// get form input
// check to make sure it's all there
// escape input values for greater safety
$title = empty($_POST['title']) ? die ("ERROR: Enter a title") : mysql_escape_string($_POST['title']);
$author = empty($_POST['author']) ? die ("ERROR: Enter an author") : mysql_escape_string($_POST['author']);
$intro = empty($_POST['intro']) ? die ("ERROR: Enter an intro") : mysql_escape_string($_POST['intro']);
$text = empty($_POST['text']) ? die ("ERROR: Enter the text") : mysql_escape_string($_POST['text']);



$editing = ($_POST['editing'] =='yes');


// open connection
$connection = mysql_connect($host, $user, $pass) or die ("Unable to connect!");

// select database
mysql_select_db($db) or die ("Unable to select database!");

//evaluate added form field to se if editing or new entry
if($editing)
{
// edit query
$query = "
UPDATE news 
SET 
   title='$title', 
   author='$author', 
   intro='$intro', 
   text='$text'
";
}
else
{
// insert query
$query = "
INSERT INTO news 
   (title,    author,     intro,     text) 
VALUES 
   ('$title', '$author', '$intro', '$text')";
}



// execute query
$result = mysql_query($query) or die ("Error in query: $query. ".mysql_error());

// print message with ID of inserted  or edited record
echo ($editing
?"New record inserted" : "Record edited")." with ID ".mysql_insert_id();

// close connection
mysql_close($connection);
}
?> 

[firemankurt]

now take your original form and change it like so...

<?php
//include config file
include "config.php";

if ($_GET['id'])
{
$articleid = $_GET['id']; // fetch the artcle id from the URL

$query = "SELECT * FROM news WHERE id=".$articleid;
$result = mysql_query($query);

while($row = mysql_fetch_assoc($result)) {
$FormVals = $row;
}
}

// Now your form code but add this kind of thing...
....
echo "
   <INPUT type=\"text\" name=\"title\" value=\"".$FormVals['title']."\" size=\"30\">";
if ($FormVals['id'])
{
   echo "<INPUT type=\"hidden\" name=\"editing\" value=\"yes\">";
}
...
?>

[DangerM0use]

NogDog wrote:

Well, assuming article ID's are unique and that we therefore should only find 1 or zero matches:

<?php
if(empty($_GET['id']))
{
   echo "<p class='error'>No article ID supplied.</p>\n";
}
else
{
   //include config file
   include "config.php";
   $query = "SELECT title, author, intro, text FROM news WHERE id=".$_GET['id'];
   $result = mysql_query($query) or die("Query failed: ".mysql_error());
   if(mysql_num_rows($result))  // found something
   {
      $row = mysql_fetch_assoc($result);
      echo "<h2 class='title'>".$row['title']."</h2>\n";
      echo "<p class='author'>".$row['author']."</p>\n";
      echo "<p class='intro'>".$row['intro']."</p>\n";
      echo "<p class='text'>".nl2br($row['text']."</p>\n";
   }
   else
   {
      echo "<p class='error'>Invalid article ID.</p>\n";
   }
}
?>

I used this code you gave, but this only printed the data from the table. How would you get the data into seperate text boxes so it could be edited?

[NogDog]

Where I had the code echoing simple paragraphs, just add in your form elements:

   if(mysql_num_rows($result))  // found something
   {
      $row = mysql_fetch_assoc($result);
      echo "<form action='edit.php' method='post'>\n<p>\n";
      echo "<input name='id' type='hidden' value='".$_GET['id']."'>\n";
      echo "Title: <input name='title' type='text' value='".$row['title']."'><br>\n";
      echo "Author: <input name='author' type='text' value='".$row['author']."'><br>\n";
      echo "Intro: <input name='intro' type='text' value='".$row['intro']."'><br>\n";
      echo "Text: <input name='text' type='text' value ='".nl2br($row['text']."'><br>\n";
      echo "<input type='submit' value='Submit'>\n";
      echo "</p>\n</form>\n";
   }

[DangerM0use]

Ok, so now I have managed to get the data in to a text box, but if I change any of the text in the boxes and click submit it doesn't update the data in the database, it simply goes back to the page that I selected and when I click on view articles, it shows the old info, not the updated one.