login script help

[avatar_alex]

ok i have a script but whenever I try to register a test user it just refreshes the page i need help finding the problem

<?
if (strlen($_POST['username'])<1 || strlen($_POST['password'])<1 || strlen($_POST['passworda'])<1 || strlen($_POST['email'])<1)
{
	echo '<div align="center">Please enter your registration details.</div>';
}
elseif ($_POST['password'] != $_POST['passworda'])
{
	echo '<div align="center">Your passwords do not match.</div>';
}
elseif (strlen($_POST['username'])<4 || strlen($_POST['username'])>16 || strlen($_POST['password'])<4 || strlen($_POST['password'])>16 || strlen($_POST['passworda'])<4 || strlen($_POST['passworda'])>16)
{
	echo '<div align="center">Username and password must be between 4 and 16 characters.</div>';
}
elseif (strlen($_POST['email'])<5 || strlen($_POST['passworda'])>50)
{
	echo '<div align="center">Email addresses must be between 5 and 50 characters.</div>';
}
else
{
	$checkuser = "SELECT username FROM i_users WHERE username='$_POST[username]'";
	$resultcheck = mysql_query($checkuser, $db_conn) or die ('query failed');
	if (mysql_num_rows($resultcheck) >0)
	{
		echo '<div align="center">The username you entered already exists, please select another username.</div>';
	}
	else {
	$query = "INSERT INTO i_users (id,username,passwd,email) VALUES ('','$_POST[username]','$_POST[password]','$_POST[email]')"; 
   $result = mysql_query($query, $db_conn) or die('query failed'.mysql_error()); 
   if (isset($result))
	{
	   echo '<div align="center">Your information has been entered into the database.</div>';
	}
	}
}
?>
<div align="center">
<form action="index.php?page=reg" method="post">
Email:<br />
<input type="text" size="16" name="username" style="font-size:10px;border:solid 1px";><br />
Password:<br />
<input type="text" size="16" name="password" style="font-size:10px;border:solid 1px";><br />
Password again:<br />
<input type="text" name="passworda" size="30" style="font-size:10px;border:solid 1px;"><br />
<input type="submit" name="reg" value="Register" style="font-size:10px;">
</form>
</div>

[roscor]

use this to check the form

<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" >

then where

echo '<div align="center">Your information has been entered into the database.</div>';
    }
    }
} 

add

echo '<meta http-equiv="refresh" content="0;url=index.php">';

if the code has worked the user will be directed to index.php(or the appropiate new login page) where you could say Congratulations You have......................New/ welcome back etc.

roscor

[leatherback]

I am not sure what you mean with "The page just refreshes", as I do not see ANY code which would refresh the page.

That being said.. You have a dataflow which will piss of your users.

Imagine this: You entere a username. But it fails the first requirement (You forgot to fill out one field).
You get an error for the first requirement, and an EMPTY form. Not good.

Then you correct it, but you fail the second. Again.. warning & empty field. And so one. What I would suggest:

• Make sure you present the filled out options in the form if an error occurs (use the value="" option for formfields.
• Check all the requirements, NO else statements. Use an array to store the errors:

  $errors = array();
  
  if (strlen($_POST['username'])<1 || strlen($_POST['password'])<1 || strlen($_POST['passworda'])<1 || strlen($_POST['email'])<1)
  {
   $errors[] = '<div align="center">Please enter your registration details.</div>';
   }
  
  // and so on for all requirements
  
  // Push the array into one strinf, separated by space (You could make it a <br /> if your div's are not blocks)
  implode(" ", $errors);
  
  // Test wether there are errors 
  if(strlen(trim($errors)) > 0)
    {
    echo $errors;
    }
  else
    {
    // process the form
    }