Another php highlighting question

Foxman

I'm trying to make a bbcode parser for

 tags, and i need some help. I'm using the highlight_string function, but it's messing up the output of the form. Heres my code: [code=php]<?php
	$send = $_POST['send'];
	$text = $_POST['text'];
if(!$send){
	echo '<form action="" method="post"><textarea name="text"/></textarea><input type="submit" name="send"/></form>';
}
elseif($send){
	function makephpcodeBox($pcode, $pID)
    	{
			$pcode = highlight_string($pcode);
			$phpc = <<<HTML
				LARGE AMOUNTS OF HTML INCLUDING STRING pID{$pcode}FINISHING HTML TAGS
			HTML;
        return $phpc;
    	}
	$p = 0;
	while(preg_match("/\[php\](.*?)\[\/php\]/ise", $text, $matches))
	{
		$p = $p + 1;
		$text = str_replace($matches[0], makephpcodeBox($matches[1], $p), $text);
	}
	echo $text;
}
?>

The output makes EVERYTHING plain text, including the html around the code that is supossed to be highlighted. What should i do?

bradgrafelman

You should fix your heredoc delimiter. When ending a heredoc string, the ending delimiter must be on a line by itself with nothing else before or after it - including whitespace characters - except possibly a semicolon directly after it.

For more information on the heredoc syntax, see this manual page.

Foxman

Thanks I'll check that now, and If I need further help I ask. Thanks!

Foxman

Okay, I read the article, and I think I understand, and I changed the output, or $pcode string, into double quotes, and It made some improvement. The code I input in the form now comes out highlighted, but the html surrounding it gets moved to the end of the highlighted code, and is still plain text. Here is my entire code, top to bottom, minus css and jscript:

<?php
	$send = $_POST['send'];
	$text = $_POST['text'];
if(!$send){
	echo '<form action="" method="post"><textarea name="text"/></textarea><input type="submit" name="send"/></form>';
}
elseif($send){
	function makephpcodeBox($pcode, $pID)
    {
		$pcode = stripslashes($pcode);
		$pcode = highlight_string($pcode);

    $phpc = "<div style=\"border:1px solid #000000;display:table;width:350;margin:0px auto;\">
  <div style=\"background-image:url(bbcode_top.png);background-repeat:repeat-x;\">
    <a href=\"javascript:menu('pcode$pID','pexpand$pID','pcollapse$pID');\" title=\"Show Or Hide This PHP Code\">
      <span id=\"pexpand$pID\" style=\"display:none;\"><img src=\"expand.gif\" width=\"9\" height=\"9\" alt=\"[+]\" border=\"0\"/></span>
      <span id=\"pcollapse$pID\" display=\"inline\"><img src=\"collapse.gif\" width=\"9\" height=\"9\" alt=\"[-]\" border=\"0\"/></span>
    </a>
    PHP Code :: <a href=\"javascript:code_select('pcode$cID');\" title=\"Highlight The Code\">Select PHP Code</a>
  </div>
  <div id=\"pcode$cID\">
    <div style=\"background-color:#000000;height:1px;width:100%;font-size:0;\"></div>
	<div style=\"background-color:#5A2323;height:1px;width:100%;font-size:0;\"></div>
	<div style=\"background-color:#470A0A;\">$pcode</div>
  </div>
</div>";
        return $phpc;
    }
	$p = 0;
	while(preg_match("/\[php\](.*?)\[\/php\]/ise", $text, $matches))
	{
		$p = $p + 1;
		$text = str_replace($matches[0], makephpcodeBox($matches[1], $p), $text);
	}
	echo $text;
}
?>

aksival

I'm sure exactly what's going on in your code, and this may or may not help, but this is how I do syntax highlighting on my site:

// Replaces all instances of [ php ]...[ /php ] with highlighted code
function bbcode_php($s) {
	// Formats php code inside of [ php ]...[ /php ] using highlight_string()
	$match = array('#\[php\](.*?)\[\/php\]#se');
	$replace = array("'<div class=\"php-code\">'.highlight_string(stripslashes('$1'), true).'</div>'");
	return preg_replace($match, $replace, $s);
}

(spaces added in between BB code brackets to display on forum)

The result is that [ php ]...[ /php ] becomes <div class="php-code">...(entry with highlighted code)...</div>, which you can modify in $replace to be whatever you want.

Like I said, this may or may not help you...

Foxman

Okay, that worked. The stripslashes didn't though, so i changed it to 2 stripslashes and it worked. Now, what i have implemented in my bbcode is that for [ php ], it's a box that expands and contracts when you click a button. The problem is, if there is more than one [php ] tag entered, the button always minimizes the first code box. How can i modifiy the below code so that the function variable $pID increases everytime the php tag is used?

<?php
	$send = $_POST['send'];
	$msg = $_POST['text'];
if(!$send){
	echo '<form action="" method="post"><textarea name="text"/></textarea><input type="submit" name="send"/></form>';
}
elseif($send){

function bbcode_php($s) {
    $match = array('#\[php\](.*?)\[\/php\]#se');
    $replace = array("'<div style=\"border:1px solid #000000;display:table;width:350;margin:0px auto;\">
  <div style=\"background-image:url(bbcode_top.png);background-repeat:repeat-x;\">
    <a href=\"javascript:menu(\'pcode$pID\',\'pexpand$pID\',\'pcollapse$pID\');\" title=\"Show Or Hide This PHP Code\">
      <span id=\"pexpand$pID\" style=\"display:none;\"><img src=\"expand.gif\" width=\"9\" height=\"9\" alt=\"[+]\" border=\"0\"/></span>
      <span id=\"pcollapse$pID\" display=\"inline\"><img src=\"collapse.gif\" width=\"9\" height=\"9\" alt=\"[-]\" border=\"0\"/></span>
    </a>
    PHP Code :: <a href=\"javascript:code_select(\'pcode$cID\');\" title=\"Highlight The Code\">Select PHP Code</a>
  </div>
  <div id=\"pcode$cID\">
    <div style=\"background-color:#000000;height:1px;width:100%;font-size:0;\"></div>
	<div style=\"background-color:#5A2323;height:1px;width:100%;font-size:0;\"></div>
	<div style=\"background-color:#470A0A;\">'.highlight_string(stripslashes(stripslashes('$1')), true).'</div>
  </div>
</div>'");
    return preg_replace($match, $replace, $s);
}
	$msg = bbcode_php($msg);
	echo $msg;
}
?>

(The jscript is above this code.)

aksival

You could write a function that would replace this:

highlight_string(stripslashes(stripslashes('$1')), true)

with a user-defined function like this:

highlight_and_increment('$1')

where the highlight_and_increment() function would stripslashes(), highlight_string(), increment the $pID variable, and return the same output as highlight_string().

Of course, you would need to change the scope of $pID to be global.

Foxman

How do i do that? I tried that and it didn't work so I'm assuming I didn't do it correctly.