[RESOLVED] coding error...?

chinna

i try to update 3 fields in detail table...i try to update the first and second...its succesfully updated...and when i try to up date the third...its show query failed to insert...i use the same coding...i dont know where is the error...please someone help,...

<?php
include "db1.php";
session_start();

if(isset($_REQUEST['save'])){
if (@!$_REQUEST['acc_no1'] || !$_REQUEST['amount1']|| @!$_REQUEST['desc1']  )
	{$display = "<font face='verdana' font siza='12' font color='#FF0000'>*Please enter all the particular ";
	echo $display;
	}

else{
	$acc_no1 = '$_POST[acc_no1]';
	$amount1 = '$_POST[amount1]';
	$desc1 = '$_POST[desc1]';

//Update records
$query = "UPDATE details 
SET acc_no ='$_POST[acc_no1]' 
WHERE item ='$_SESSION[item]' ";
mysql_query($query) or die('Error, insert query failed');
$get = "UPDATE details SET amount = '$_POST[amount1]' WHERE item = '$_SESSION[item]'";
mysql_query($get) or die ('Error , insert query failed');
$through = "UPDATE details SET desc = '$_POST[desc1]' WHERE item = '$_SESSION[item]'";
mysql_query($through) or die ('Error , insert query failed');

}
if ($_REQUEST['display'] == 'ranges') {
	header ("Location: Ranges.php");
		exit;
}
else {
	header ("Location: aftersave.php");
		exit;
		}}

  ?>                  

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>edit</title>
</head>

<body>
<form id="form1" name="form1" method="post" action="">
  <table width="400" border="0" cellspacing="0" cellpadding="0">
    <tr>
      <td height="30" width="200">Item No </td>
      <td width="200"><? if(isset($_SESSION['item'])) {  echo $_SESSION['item'];} ?>    </td>
    </tr>
    <tr>
      <td height="30">Account No</td>
      <td><input type="text" name="acc_no1" id="acc_no1" maxlength="15" /></td>
    </tr>
    <tr>
      <td height="30">Department Code </td>
      <td><? if(isset($_SESSION['depart_code'])) {  echo $_SESSION['depart_code'];} ?></td>
    </tr>
    <tr>
      <td height="104">Description</td>
      <td><textarea name="desc1" id="desc1"></textarea></td>
    </tr>
    <tr>
      <td height="30">Amount</td>
      <td><input type="text" name="amount1" id="amount1" maxlength="10" /></td>
    </tr>
    <br />
  </table>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
  <br />
  <br />
  <input type="submit" name="save" id="save" value="Save"/>
  <input type="reset" name="reset" value="Reset" />

</form>
</body>
</html>

please help me..

hates make waste

NogDog

Have your die() give you some more debug info:

mysql_query($through) or die ("Error , insert query failed ($through): " . mysql_error());

This way your error message will show the query exactly as it was sent to MySQL, along with whatever error was returned from it.

TheoGB

Well I'd query a few things:

1) Why do you do two separate updates when you could update both fields at the same time in one query? (Or maybe you are doing this to debug?)

2) Why do you copy the values:

   $acc_no1 = '$_POST[acc_no1]'; 
    $amount1 = '$_POST[amount1]'; 
    $desc1 = '$_POST[desc1]';

and then use the $_POST values, not the new variables...

3) I would have written:

 $_POST['acc_no1']

where you've written

 '$_POST[acc_no1]'

I'm not entirely sure you're using that correctly but in your final UPDATE you would appear to be updating a TEXT field on the database, which means you'd need to have it in quotes. I would guess that you would do better with something along the lines of:

$desc1 = addslashes($_POST['desc1']); 

//.....

$through = "UPDATE details SET desc = '$desc1' WHERE item = '$_SESSION[item]'"; 
mysql_query($through) or die ('Error , insert query failed');


//...OR even

$through = "UPDATE details SET desc = '".$desc1."' WHERE item = '$_SESSION[item]'"; 
mysql_query($through) or die ('Error , insert query failed');

I point out the latter form just in case something happens with the ' ' marks but it shouldn't be a problem.