[RESOLVED] Updateing Problem

Dlex

Question:

Why dont my table update when i press the fricken update button.

code:

<?php
include('adminheader.php');
require('dbconnect.php');


if (!$_REQUEST['Submit']) { 
     modellists(); 
} elseif ($_REQUEST['Submit'] == "Edit") { 
     editmodels();  

} elseif ($_REQUEST['Submit'] == "Update") { 
     updatemodels();  

} elseif ($_REQUEST['Submit'] == "Delete") { 
     deletemodels();  

}   


function modellists(){

$result = mysql_query("SELECT * FROM Sitemodels");


$path = "models";


while ($row = mysql_fetch_array($result))
{

print "<table>";
print "<tr>";
print "<td rowspan='5'> <img width='100' height='100' src='/rf/models/".$row['image']."' alt='".$row['name']."'></td>";
print "</tr>";
print "<tr>";
print "<td>Name:</td>";
print "<td><a href='details.php?id=".$row['modelid']."'>$row[name]</a></td>";
print "<td><a href=\"" . $_SERVER['PHP_SELF'] . "?modelid=" .$row['modelid'] . "&Submit=Edit\">Edit</a></td>";
print " <td> <a href=\"" .$SERVER['PHP_SELF'] . "?modelid=" .$row['modelid'] . "&Submit=Delete\">Delete</a></td>";
print "</tr>";
print "<tr>";
print "<td>Age:</td>";
print "<td>$row[age]</td>";
print "</tr>";
print "<tr>";
print "<td>Site: </td>";
print "<td><a href='http://www.myspace.com/$row[friendid]'>$row[name]'s Myspace</a></td>";
print "</tr>";
print "<tr>";
print "<td>Site Model of: </td>";
print "<td>$row[month] $row[year]</td>";
print "</tr>";

print "</table>";
print "<hr>";
}
}

function editmodels(){

$result = mysql_query("SELECT * FROM Sitemodels");

while ($row = mysql_fetch_array($result))
{

print "\n<form ENCTYPE=\"multipart/form-data\"  action=\"" . $PHP_SELF . "\" method=\"post\">";
    print "\n<input name=\"id\" type=\"hidden\" ><br>";
    print "\nName: <input name=\"name\" type=\"text\" value=\"$row[name]\"><br>";
    print "\nAge: <input name=\"age\" type=\"text\" value=\"$row[age]\"><br>";
    print "\nFriend ID: <input name=\"friendid\" type=\"text\" value=\"$row[friendid]\"><br>";
    print "\nMonth: <input name=\"month\" type=\"text\" value=\"$row[month]\"><br>";
    print "\nYear:<input name=\"year\" type=\"text\" value=\"$row[year]\"><br>";
    print "\n<input type=\"submit\" Value=\"Update\">";
    print "\n</form>";
}
}

function updatemodels(){


$sql = "UPDATE Sitemodels SET name=' .$_REQUEST[name] . ', 
 age=' . $_REQUEST[age] . ', friendid=' .$_REQUEST[friendid] . ', month=' .$_REQUEST[month] . ', year=' .$_REQUEST[year] . ' WHERE modelid=' .$_REQUEST[modelid] . ';";
 $result = mysql_query($sql);
 echo "Thank you! Information updated.\n";

modellists();
} 

function deletemodels(){

$sql = "DELETE FROM Sitemodels WHERE Sitemodels.modelid = " .$_REQUEST['modelid'] . ";";

$result = mysql_query($sql);

echo " Record Deleted";

modellists();
}
?>
<?php
include('adminfooter.php');
?>

the rest works except this:

function updatemodels(){


$sql = "UPDATE Sitemodels SET name=' .$_REQUEST[name] . ', 
 age=' . $_REQUEST[age] . ', friendid=' .$_REQUEST[friendid] . ', month=' .$_REQUEST[month] . ', year=' .$_REQUEST[year] . ' WHERE modelid=' .$_REQUEST[modelid] . ';";
 $result = mysql_query($sql);
 echo "Thank you! Information updated.\n";

modellists();
}

can anyone figure this out

aspekt9

You have an extra semicolon, ; before you close the query completely:

$sql = ("UPDATE Sitemodels SET name=' .$_REQUEST[name] . ', 
age=' . $_REQUEST[age] . ', friendid=' .$_REQUEST[friendid] . ', month=' .$_REQUEST[month] . ', year=' .$_REQUEST[year] . ' WHERE modelid=' .$_REQUEST[modelid] . '"); 
$result = mysql_query($sql);

Dlex

that doesnt solve my issue either? weird what coudl it be.

aspekt9

Hrm, I wouldn't use $REQUEST, $REQUEST is a generic variable, that holds values from both GET and POST requests.

$_POST just has POST variables:

$sql = ("UPDATE Sitemodels SET name='$_POST["name"]', 
age='$_POST["age"]', friendid='$_POST["friendid"]', month='$_POST["month"]', year='$_POST["year"]' WHERE modelid='$_POST["modelid"]'"); 
$result = mysql_query($sql);

TheoGB

function updatemodels(){


$sql = "UPDATE Sitemodels SET name=' .$_REQUEST[name] . ', 
 age=' . $_REQUEST[age] . ', friendid=' .$_REQUEST[friendid] . ', month=' .$_REQUEST[month] . ', year=' .$_REQUEST[year] . ' WHERE modelid=' .$_REQUEST[modelid] . ';";
 $result = mysql_query($sql);
 echo "Thank you! Information updated.\n";

modellists();
}

Yes, you've mixed up your " and your '.

You are writing $sql in a string within "" but then you're still using the period to add in your other strings.

You should write it like this:

function updatemodels(){


$sql = "UPDATE Sitemodels SET name='".$_REQUEST[name]."', 
 age=".$_REQUEST[age].", friendid=".$_REQUEST[friendid].", month=".$_REQUEST[month].", year=".$_REQUEST[year]." WHERE modelid=".$_REQUEST[modelid];
 $result = mysql_query($sql);
 echo "Thank you! Information updated.\n";

modellists();
}

I've made the gross assumption that the 'name' field is a string field and therefore will need ' on either side of the value, while the others are all numeric and therefore need no quote marks.

Dlex

i have tried bothpieces of code and they both dont work grrr im trying to figure this out also and im so gratefl for yalls help.

TheoGB

Echo $sql before you attempt to run it and see how it looks.

Then try running it through PHPMyAdmin (for example) which should give you a good answer as to the issue.

Are you sure that all the fields you're updating are numerical aside from name? Also I've never used 'REQUEST' so you should probably change them to $_POST as suggested.

Dlex

Nah i have a mix of numerical and Alpha fields. ill try to run it through myadmin

TheoGB

Well all non-numeric fields will need to have their values bookended by ' in the sequel query. I assumed all the fields you were updating, bar name, were numeric but if they're not defined as such in your table definition then enclose any that are text within single quotation marks, as I did for name.

bradgrafelman

And after you do as TheoGB has suggested, post us the new code, as well as the error message MySQL is trying to tell you via [man]mysql_error/man instead of just telling us "It doesn't work."

Dlex

it works if i do it in Phpmyadmin if i replace the field names with hard coded variable like name='karen' it updated no prob. Just wont do it through a form

bradgrafelman

Okay... echo out the query before it's used in mysql_query() and paste it here for us to see.

Standard SQL debugging technique:

$query = "your SQL query here";
$exec = mysql_query($query) or die('MySQL Error: ' . mysql_error() . '<hr>' . $query);

TheoGB

Dlex wrote:
it works if i do it in Phpmyadmin if i replace the field names with hard coded variable like name='karen' it updated no prob. Just wont do it through a form

That's not what I meant you to do at all:

ECHO the SQL statement you're passing to mysql_query that's failing THEN cut and paste that into PHPMyAdmin. That'll tell you why it's failing or you may be able to see immediately. Sounds like you're not getting the data from your variables from what you're saying.

Dlex

it wont echo out for me echo "$sql"; aint working for me the page just blinks and reverts back to old values.

bradgrafelman

Try doing die($sql); instead, so that no other part of the script is executed.

TheoGB

Stick an exit() after the echo $sql statement? It's probably going away because you're running the rest of the script that changes the output.

Dlex

All of this is inside of a function named updatemodels() and only gets called after the button is clicked. Would that have anything to do with it.

Dlex

I changed it to a link instead of a button and it ran my query

i got this

UPDATE Sitemodels SET name=' ', age=' ', friendid='', month= '', year='' WHERE modelid=''

TheoGB

Ah. There you go then: not blooming variable values coming through. Did you change the $REQUEST things to $POST as advised?

TheoGB

Just realised: You're using $REQUEST[name] when you should be using $REQUEST['name'].

You do it correctly on the Delete request but not the update.

Change all your variables in the update request to reflect this.