loop problem

[slimjim]

sounds dumb but drawing blanks on dumb issue.

If I only have 2 entries in database, it produces 4 emails, 2 of each...
How can I stop this please.
It is like looping thru it twice..

if($rtzone=="0"){


$query = "SELECT * FROM friends WHERE rdate = '$tdate' and status='1'";
  $result = mysql_query($query) or die( "ERROR: " . mysql_error() . "\n");

  while ($myrow = mysql_fetch_array($result)) {	
	$subj=$myrow["title"];		
	$fname=$myrow["name"];		


//sending mail();here
	}
}

[NogDog]

I don't see any reason for duplicates in the limited bit of code you've given us, assuming the query would in fact only return 2 unique results -- which perhaps you should verify manually?

[slimjim]

if($rtzone=="0"){ 


$query = "SELECT * FROM friends WHERE rdate = '$tdate' and status='1'"; 
  $result = mysql_query($query) or die( "ERROR: " . mysql_error() . "\n"); 
 $counter = 0;//jus added this          

      while ($myrow = mysql_fetch_array($result)) {     

        $subj=$myrow["title"];         

        $fname=$myrow["name"];         


//sending mail();here 
$counter++;//just added this
echo $counter; //just added this  	    

} 
} 

produces this :
1212
which tells me it is looping more then should and yes I checked manually cause I am the one that added the 2 db entires

confused..

[NogDog]

Any possibility this code is embedded within a larger block that is looping? (In other words, I suspect we need to see more of the code to find where the extra loop is, as I don't see anything in this bit.)

[slimjim]

here is all I am using of course other then connection info and change email address.

    $query2 = "SELECT rtzone FROM friends where status='1'";
	  $result2 = mysql_query($query2) or die( "ERROR: " . mysql_error() . "\n");	    

	  while ($myrow2 = mysql_fetch_array($result2)) {	
		$rtzone=$myrow2["rtzone"];

if($rtzone=="0"){ 


$query = "SELECT * FROM friends WHERE rdate = '$tdate' and rtzone='0' and status='1'"; 
  $result = mysql_query($query) or die( "ERROR: " . mysql_error() . "\n");

$counter = 0;//jus added this

  while ($myrow = mysql_fetch_array($result)) {      
    $subj=$myrow["title"];          
    $fname=$myrow["name"];          
    $message=$myrow["info"];	


$headers  = "From:<[e-mail]>\r\n";
$headers .= "Content-Type:text/plain;charset=iso-8859-1\r\n";

mail($to_addr, $subj, $message, [e-mail]');
$counter++;//just added this 
echo $counter; //just added this           

echo $fname;//showed 2 names 2 times each...
    }; 
}; 

[NogDog]

Yep, your $query loop is inside of your $query2 loop, thus you will do the inner ($query) loop for each row in the outer ($query2) loop. As I don't see anything gained by using that outer loop, I think you could just get rid of it.

[slimjim]

Could it because of the last }
which I forgot to add in here

$query2 = "SELECT rtzone FROM friends where status='1'"; 
      $result2 = mysql_query($query2) or die( "ERROR: " . mysql_error() . "\n");         

      while ($myrow2 = mysql_fetch_array($result2)) {     

        $rtzone=$myrow2["rtzone"]; 

if($rtzone=="0"){ 


$query = "SELECT * FROM friends WHERE rdate = '$tdate' and rtzone='0' and status='1'"; 
  $result = mysql_query($query) or die( "ERROR: " . mysql_error() . "\n"); 

$counter = 0;//jus added this 

  while ($myrow = mysql_fetch_array($result)) {       
    $subj=$myrow["title"];           
    $fname=$myrow["name"];           
    $message=$myrow["info"];     


$headers  = "From:<[e-mail]>\r\n"; 
$headers .= "Content-Type:text/plain;charset=iso-8859-1\r\n"; 

mail($to_addr, $subj, $message, [e-mail]'); 
$counter++;//just added this 
echo $counter; //just added this            

echo $fname;//showed 2 names 2 times each... 
    }; 
}; 


};//this one most likely causing loop correct ?

[slimjim]

reason I was using the outer loop was I also want to add if($rtzone=="1"{

I want to add more loops within the outer loop or is that a bad idea ?

[NogDog]

slimjim wrote:

Could it because of the last }
which I forgot to add in here
...

The problem is that you are using this logic/flow:

select each DB row where [color=red]status = 1[/color]
loop on each DB row:
   if [color=blue]rtzone = 0[/color]
      select each DB row where [color=red]status = 1[/color] and [color=blue]rtzone = 0[/color] and rdate = $tdate
      loop on each DB row
         send email
      end foreach
   end if
end loop 

I used red and blue colors above to show where things are being redundant (and as a side effect giving you a loop within a loop). Just get rid of this section (and closing "}" characters for the while loop and if block later on), and I think you'll have what you want:

$query2 = "SELECT rtzone FROM friends where status='1'";
      $result2 = mysql_query($query2) or die( "ERROR: " . mysql_error() . "\n");         

      while ($myrow2 = mysql_fetch_array($result2)) {     

        $rtzone=$myrow2["rtzone"];

if($rtzone=="0"){ 

[slimjim]

would this work ?

$friend_info = mysql_query("select rtzone from friends where status='1'");
$user=mysql_fetch_array($friend_info);
$user=['rtzone'];

//then use

if($user['rtzone']=='0'){
//do what ever
}

[NogDog]

It's hard to say without knowing exactly what you want to do, but the odds are you can do it all with one query and one while() loop, e.g.:

// mail to all users who have status of 1 and rtzone of either 0 or 1:
$query = "SELECT * FROM friends WHERE status = 1 AND rtzone IN (0, 1)";
$friend_info = mysql_query($query) or die("Query failed ($query) " . mysql_error());
while($row = mysql_fetch_assoc($friend_info))
{
   // send email
}