Finding the end of the array

Neko_D

So I am trying to build an INSERT statement for SQL. I have an associative array with values in it. And on the last value I want to put a ")".

Here is my code

$cols;
       foreach($columns as $key => $item)
       {
            if($item == end($columns))
            {
                 $cols .= $key.") ";
            }//end if
            else
            {
                 $cols .= $key.", ";
            }//end else
       }//end foreach

So my problem is that the "if" always comes out as true. How do I make it NOT come out as true?

Roger_Ramjet

$j = count($columns);
$i = 1;
foreach($columns as $key => $item) {
   if ($i<$j) {
       $cols .= $key.", "; 
   } else {
       $cols .= $key.") "; 
   $i++;
}

Neko_D

Roger Ramjet wrote:

$j = count($columns);
$i = 1;
foreach($columns as $key => $item) {
   if ($i<$j) {
       $cols .= $key.", "; 
   } else {
       $cols .= $key.") "; 
   $i++;
}

Thanks, but isn't there a way I can just use the end() function? If not that is fine, I just do not want to simulate a regular for loop. I will use this fix for now though.

NogDog

// create list of strings for SQL:
$list = sprintf("('%s')", implode("', '", $columns));

// create list of numbers for SQL:
$list = sprintf('(%s)', implode(", ", $columns));

Roger_Ramjet

Of course NoDog, of course. One of those wood-for-the-trees times.

Neko_D

NogDog wrote:

// create list of strings for SQL:
$list = sprintf("('%s')", implode("', '", $columns));

// create list of numbers for SQL:
$list = sprintf('(%s)', implode(", ", $columns));

Holy god there is an implode function? Will this work on a data set of both number and strings?

NogDog

Just use the "strings" version - SQL will deal with quoted numbers fine, but not unquoted strings.