php+mysql issue

agallo

I am have having some trouble debugging the following code.

Everything seems to work fine except the mysql update statement. I have spent nearly a day looking at this code but just can't seem to get it to update a record.
Any help would be greatly appreciated!

I am inserting my entire edit.php file b/c I do not believe it is an issue with the update sql statement.

Thanks in advance for any help =)


<html>
<head>
<h1>Below are the following listings you may edit: </br></h1>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>


<? 


include_once ("../auth.php");
include_once ("../authconfig.php");
include_once ("../check.php");

$username = $check["uname"];


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the property
   $result = mysql_query("select * from property where username='$username' order by id"); 

   //run the while loop that grabs all the property scripts
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the address_no and the ID of the property
      $address_no=$r["address_no"];//take out the address_no
      $id=$r["id"];//take out the id

 //make the address_no a link
  echo "<a href='edit.php?cmd=edit&id=$id'>$address_no - Edit</a>";
  echo "<br>";
}
}
?>

<?
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if ($_POST['update_info'] != "yes")
   {
      $id = $_GET["id"];
      $sql = "SELECT * FROM property WHERE id=$id";
      $result = mysql_query($sql);        

      $myrow = mysql_fetch_array($result);
      ?>

  <form action="edit.php" method="POST">
  <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">

  Address # : <input type="text" name="address_no" value="<?php echo $myrow["address_no"] ?>">
  Address Suite : <INPUT TYPE="TEXT" NAME="address_suite" VALUE="<?php echo $myrow["address_name"] ?>" ><br>
  Address Name : <INPUT TYPE="TEXT" NAME="address_name" VALUE="<?php echo $myrow["address_suite"] ?>" ><br>
  Sq ft : <INPUT TYPE="TEXT" NAME="sq_ft" VALUE="<?php echo $myrow["sq_ft"] ?>" ><br>
  Rent Price : <INPUT TYPE="TEXT" NAME="rent_price" VALUE="<?php echo $myrow["rent_price"] ?>" ><br>
  Bedrooms : <INPUT TYPE="TEXT" NAME="bedroom" VALUE="<?php echo $myrow["bedroom"] ?>" ><br>
  Baths : <INPUT TYPE="TEXT" NAME="bath" VALUE="<?php echo $myrow["bath"] ?>" ><br>
  Living Rooms : <INPUT TYPE="TEXT" NAME="living_room" VALUE="<?php echo $myrow["living_room"] ?>" ><br>
  Dining Rooms : <INPUT TYPE="TEXT" NAME="dining_room" VALUE="<?php echo $myrow["dining_room"] ?>" ><br>
  Furnished : <INPUT TYPE="TEXT" NAME="furnished" VALUE="<?php echo $myrow["furnished"] ?>" ><br>
  Pets : <INPUT TYPE="TEXT" NAME="pets" VALUE="<?php echo $myrow["pets"] ?>" ><br>
  Pet Deposit : <INPUT TYPE="TEXT" NAME="pet_deposit" VALUE="<?php echo $myrow["pet_deposit"] ?>" ><br>
  Lease Term : <INPUT TYPE="TEXT" NAME="lease_term" VALUE="<?php echo $myrow["lease_term"] ?>" ><br>
  Security Deposit : <INPUT TYPE="TEXT" NAME="security_deposit" VALUE="<?php echo $myrow["security_deposit"] ?>" ><br>
  Key Access : <INPUT TYPE="TEXT" NAME="key_access" VALUE="<?php echo $myrow["key_access"] ?>" ><br>
  Resident Phone : <INPUT TYPE="TEXT" NAME="resident_phone" VALUE="<?php echo $myrow["resident_phone"] ?>" ><br>
  Date Available : <INPUT TYPE="TEXT" NAME="date_available" VALUE="<?php echo $myrow["date_available"] ?>" ><br>
  A/C : <INPUT TYPE="TEXT" NAME="ac" VALUE="<?php echo $myrow["ac"] ?>" ><br>
  Heat : <INPUT TYPE="TEXT" NAME="heat" VALUE="<?php echo $myrow["heat"] ?>" ><br>
  Laundry : <INPUT TYPE="TEXT" NAME="laundry" VALUE="<?php echo $myrow["laundry"] ?>" ><br>
  Fireplace : <INPUT TYPE="TEXT" NAME="fireplace" VALUE="<?php echo $myrow["fireplace"] ?>" ><br>
  Alarm : <INPUT TYPE="TEXT" NAME="alarm" VALUE="<?php echo $myrow["alarm"] ?>" ><br>
  Ceiling Fan : <INPUT TYPE="TEXT" NAME="ceiling_fan" VALUE="<?php echo $myrow["ceiling_fan"] ?>" ><br>
  Refrigerator : <INPUT TYPE="TEXT" NAME="refrigerator" VALUE="<?php echo $myrow["refrigerator"] ?>" ><br>
  Stove : <INPUT TYPE="TEXT" NAME="stove" VALUE="<?php echo $myrow["stove"] ?>" ><br>
  Dishwasher : <INPUT TYPE="TEXT" NAME="dishwasher" VALUE="<?php echo $myrow["dishwasher"] ?>" ><br>
  Mircowave : <INPUT TYPE="TEXT" NAME="microwave" VALUE="<?php echo $myrow["microwave"] ?>" ><br>
  Parking : <INPUT TYPE="TEXT" NAME="parking" VALUE="<?php echo $myrow["parking"] ?>" ><br>
  Fenced : <INPUT TYPE="TEXT" NAME="fenced" VALUE="<?php echo $myrow["fenced"] ?>" ><br>
  Pool : <INPUT TYPE="TEXT" NAME="pool" VALUE="<?php echo $myrow["pool"] ?>" ><br>
  Spa : <INPUT TYPE="TEXT" NAME="spa" VALUE="<?php echo $myrow["spa"] ?>" ><br>
  Bills Paid : <INPUT TYPE="TEXT" NAME="bills_paid" VALUE="<?php echo $myrow["bills_paid"] ?>" ><br>
  School District : <INPUT TYPE="TEXT" NAME="school_district" VALUE="<?php echo $myrow["school_district"] ?>" ><br>
  Elem School : <INPUT TYPE="TEXT" NAME="school_elem" VALUE="<?php echo $myrow["school_elem"] ?>" ><br>
  Midd School : <INPUT TYPE="TEXT" NAME="school_midd" VALUE="<?php echo $myrow["school_midd"] ?>" ><br>
  High School : <INPUT TYPE="TEXT" NAME="school_high" VALUE="<?php echo $myrow["school_high"] ?>" ><br>
  Company Name : <INPUT TYPE="TEXT" NAME="company_name" VALUE="<?php echo $myrow["company_name"] ?>" ><br>
  Company Phone : <INPUT TYPE="TEXT" NAME="company_phone" VALUE="<?php echo $myrow["company_phone"] ?>" ><br>
  Agent First Name : <INPUT TYPE="TEXT" NAME="agent_fname" VALUE="<?php echo $myrow["agent_fname"] ?>" ><br>
  Agent Last Name : <INPUT TYPE="TEXT" NAME="agent_lname" VALUE="<?php echo $myrow["agent_lname"] ?>" ><br>
  Agent Phone : <INPUT TYPE="TEXT" NAME="agent_phone" VALUE="<?php echo $myrow["agent_phone"] ?>" ><br>
  Commission : <INPUT TYPE="TEXT" NAME="commission" VALUE="<?php echo $myrow["commission"] ?>" ><br>
  Bonus : <INPUT TYPE="TEXT" NAME="bonus" VALUE="<?php echo $myrow["bonus"] ?>" ><br>
  Remarks:<TEXTAREA NAME="message" ROWS=10 COLS=30><? echo $myrow["remarks"] ?></TEXTAREA><br>

  <input type="hidden" name="cmd" value="edit">
  <input type="hidden" name="update_info" value="yes">

  <input type="submit" name="submit" value="submit">

  </form>

   <? } ?>

<?
   if ($_POST['update_info'] == "yes")
   {

$address_no=$_POST['address_no'];
$address_name=$_POST['address_name'];
$address_suite=$_POST['address_suite']; 
$sq_ft=$_POST['sq_ft']; 
$rent_price=$_POST['rent_price']; 
$bedroom=$_POST['bedroom']; 
$bath=$_POST['bath']; 
$living_room=$_POST['living_room']; 
$dining_room=$_POST['dining_room']; 
$furnished=$_POST['furnished']; 
$pets=$_POST['pets']; 
$pet_deposit=$_POST['pet_deposit']; 
$lease_term=$_POST['lease_term']; 
$security_deposit=$_POST['security_deposit']; 
$key_access=$_POST['key_access']; 
$resident_phone=$_POST['resident_phone']; 
$date_available=$_POST['date_available']; 
$ac=$_POST['ac']; 
$heat=$_POST['heat']; 
$laundry=$_POST['laundry']; 
$fireplace=$_POST['fireplace']; 
$alarm=$_POST['alarm']; 
$ceiling_fan=$_POST['ceiling_fan']; 
$refrigerator=$_POST['refrigerator']; 
$stove=$_POST['stove']; 
$dishwasher=$_POST['dishwasher'];
$microwave=$_POST['microwave']; 
$parking=$_POST['parking'];
$fenced=$_POST['fenced']; 
$pool=$_POST['pool'];
$spa=$_POST['spa']; 
$bills_paid=$_POST['bills_paid'];
$school_district=$_POST['school_district']; 
$school_elem=$_POST['school_elem'];
$school_midd=$_POST['school_midd'];
$school_high=$_POST['school_high'];
$company_name=$_POST['company_name'];
$company_phone=$_POST['company_phone'];
$agent_fname=$_POST['agent_fname'];
$agent_lname=$_POST['agent_lname'];
$agent_phone=$_POST['agent_phone'];
$commission=$_POST['commission'];
$bonus=$_POST['bonus'];
$remarks=$_POST['remarks'];



  $sql = "UPDATE property SET address_no='$address_no',address_suite='$address_suite',address_name='$address_name',sq_ft='$sq_ft',rent_price='$rent_price',bedroom='$bedroom',bath='$bath',living_room='$living_room',dining_room='$dining_room',furnished='$furnished',pets='$pets',pet_deposit='$pet_deposit',lease_term='$lease_term',security_deposit='$security_deposit',key_access='$key_access',resident_phone='$resident_phone',date_available='$date_available',ac='$ac',heat='$heat', laundry='$laundry', fireplace='$fireplace',alarm='$alarm',ceiling_fan='$ceiling_fan',refrigerator='$refrigerator',stove='$stove',dishwasher='$dishwasher',microwave='$microwave',parking='$parking',fenced='$fenced',pool='$pool',spa='$spa',bills_paid='$bills_paid',school_district='$school_district',school_elem='$school_elem',school_midd='$school_midd',school_high='$school_high',company_name='$company_name',company_phone='$company_phone',agent_fname='$agent_fname',agent_lname='$agent_lname',agent_phone='$agent_phone',commission='$commission',bonus='$bonus',remarks='$remarks' WHERE address_no='$address_no'";

  $result = mysql_query($sql) or die(mysql_error()."<br /><br />".$sql);

  echo "Thank you! Information updated.";
   }
}
?>

</body>
</html>

bretticus

If there is an error in the SQL syntax...

$result = mysql_query($sql) or die(mysql_error()."<br /><br />".$sql);

...should throw it. If so, what is the error? Are you saying there is no error? Are you saying the only symptom is that when you look at the records in your table, they appear not to have been updated?

NogDog

You could also add some debugging in case the query is parseable but is logically flawed:

$result = mysql_query($sql) or die(mysql_error()."<br /><br />".$sql); 
if(mysql_affected_rows() == 0)
{
   user_error("DEBUG: No rows updated. Query: $sql", E_USER_WARNING);
}

Also, if you're not seeing any errors at all, make sure your configuration is displaying errors:

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);

agallo

ok so my debugging always involved changing the addrerss_no field, since it was first.

well the problem was I always chaged the address_no field with every debug attempt but in my mysql update statement I used, WHERE address_no='$address_no'. So everytime I changed the address_no field it couldn't reference the correct field to change. tis why no rows were ever effected.

Thanks so much NogDog for the debugging tip! that is what triggered the solution to the problem, because I tried the typical "or die" and that never triggered anything since no rows were affected and the update went through.

Spent an entire day with that one.

Mucho Gracias