help with form

blckspder

Hello,
I have a form that people use to sign up for a news letter all of the field in this form are required.

I use the trim() to get rid of any white space and to make sure that they didnt just enter in a bunch of spaces and so on...

The problem I am having is that even though I have all the fields validated the phone and country fields dont always go into the MySQL database and I dont always get an email telling me that someone has signed up. So I could go days not knowing anyone has signed up and then to come to find out the country and phone number didnt take anyways. I need that information because the company I work for treats all these sign ups as sales leads..

This is one of my earlier scripts so Im sure it needs some type of updating.

here is my code:

<?php
session_start();

include("../forms/open_config.php");

//post form variables and trim any white space off of them.
$Name = $_POST['Name'];
$Name = trim($Name);
$Company = $_POST['Company'];
$Company = trim($Company);
$country = $_POST['country'];
$country = trim($country);
$Phone = $_POST['Phone'];
$Phone = trim($Phone);
$Email = $_POST['Email'];
$Email = trim($Email);
$Date = $_POST['Date'];
$Last = $_POST['Last'];
$Last = trim($Last);
$so_email = "info@sono-tek.com";
$compannounce = $_POST['compannounce'];
$newpro = $_POST['newpro'];

session_register("Name");
session_register("Last");
session_register("Company");
session_register("Phone");
session_register("Email");

if (empty($compannounce) && empty($newpro)) {
	$newpro = '1';
	}
if($compannounce == 1) {
	$compannounceText = "Corporate Announcements";
	}
if($newpro == 1) {
	$newproText = "New Products";
	}

if (isset($_POST['txtNumber'])) {
$number = $_POST['txtNumber'];
	if(empty($Name) || $Name == " ") {
		$nameerror = "You must provide your name";
		} else {
			$nameerror = NULL;
			}
	if(empty($Company) || $Company == " ") {
		$comperror = "You must provide a company name";
		} else {
			$comperror = NULL;
			}
	if(empty($country) || $country == " ") {
			$countryError = "Please enter your country";
		} else {
			$countryError = NULL;
			}
	if(empty($Phone) || $Phone == " " || $Phone == "000-000-0000" ) {
		$phoneerror = "You must provide a phone number";
		} else {
			$phoneerror = NULL;
			}
	if(empty($Last) || $Last == " ") {
		$lasterror = "You must provide your last name";
		} else {
			$lasterror = NULL;
			}
	if (check_email_address($Email) ) {
		$emailformaterror = NULL;
		} else {
			$emailerror = "Please enter a valid email address";
			}
	if(($nameerror == NULL && $comperror == NULL && $phoneerror == NULL && $countryError == NULL) && ($emailerror == NULL && $lasterror == NULL && md5($number) == $_SESSION['image_random_value'])){
		$sql_insert = "INSERT INTO newsletter (name, lastName, company, phone, email, corpAnnounce, newPro, date, country) VALUES ('$Name','$Last','$Company','$Phone','$Email','$compannounce','$newpro','$Date','$country')";

	mysql_query($sql_insert);

	$subject = "Sono-Tek Newsletter Confirmation";

	$confirm_body = '<html><body>Hello&nbsp;' . $Name . ',<br />Thank you for signing up for the Sono-Tek newsletter. You will receive your first news letter very shortly. If you did not sign up for this service please follow the provided link to remove your information from our list. Thank you again.<br />Remove me from the list:<br /><a href="http://www.sono-tek.com/newsletter/remove.php">http://www.sono-tek.com/newsletter/remove.php</a></body></html>';
	//alert notifies sono-tek employee of a sign up
	$alert = '<html><body>' . $Date . '<br />' . $Name . '&nbsp;' . $Last . '&nbsp;from&nbsp;' . $Company . '&nbsp;has signed up for the News Letter<br />Email:&nbsp;' . $Email . '<br />Phone:&nbsp;' . $Phone . '<br />Country:&nbsp;'. $country .'<br />Newsletter Types:'. $compannounceText .'&nbsp;and&nbsp;'. $newproText .'<br />';

	//Headers
	$headers = "MIME-Version: 1.0\r\n";
	$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
	$headers .= "From: Sono-Tek Corporation <$so_email>";

	//email to sono-tek addresses
	//$emailSono = "cycorda@sono-tek.com,abruce@sono-tek.com";
	$emailSono = "websupport@sono-tek.com";

	mail($emailSono,$subject,$alert,$headers);
	mail($Email,$subject,$confirm_body,$headers);
	//mail($so_email,$subject,$alert,$headers);
	header("location:http://www.sono-tek.com/newsletter/letterThanks.php");
	} else {
		$validerror = "Please enter the correct validation number";
		}
}

If anyone can help I would really appreciate it. Thanks.

vaaaska

Are you sure that the emails aren't going to your spam box?

Oftentimes, you have to wiggle the headers around to find a formula that is reliable - as silly as that sounds.

blckspder

Ive had suspicion that our ISP/ hosting might have been blocking them.. but what about the Database? why would some go in while others dont??

vaaaska

You aren't doing anything to protect your data as it goes into the server...this is very easily hackable. I'm quite sure this is the real problem...for instance, have a simple ' in one of the posted fields could mess it all up.

Read this...and get used to always working with it...it will save you big...

http://be2.php.net/manual/en/function.mysql-real-escape-string.php

blckspder

Thanks for your help.. I added the function to my script to see if it works.. Hopefully it will. Thanks for your help and I will post again if I am still having problems.

blckspder

ok I have tried several different things.. and I am still having problems with the notification getting to me and the country entering the database.... If no one can pick up on the error, if there is one in my code. I will have to convince my managers to do a drop down list for the country and I am left to assume that our isp are blocking the email notifications. let me now if you find anything in whats left of my code after I have changed it several times. Thanks

//post form variables and trim any white space off of them.
$Name = $_POST['Name'];
$Name = trim($Name);
$Company = $_POST['Company'];
$Company = trim($Company);
$country = $_POST['country'];
$country = trim($country);
$Phone = $_POST['Phone'];
$Phone = trim($Phone);
$Email = $_POST['Email'];
$Email = trim($Email);
$Date = $_POST['Date'];
$Last = $_POST['Last'];
$Last = trim($Last);
$so_email = "info@sono-tek.com";
$compannounce = $_POST['compannounce'];
$newpro = $_POST['newpro'];

session_register("Name");
session_register("Last");
session_register("Company");
session_register("Phone");
session_register("Email");

if (empty($compannounce) && empty($newpro)) {
	$newpro = '1';
	}
if($compannounce == 1) {
	$compannounceText = "Corporate Announcements";
	}
if($newpro == 1) {
	$newproText = "New Products";
	}

if (isset($_POST['txtNumber'])) {
$number = $_POST['txtNumber'];
	if(empty($Name) || $Name == " ") {
		$nameerror = "You must provide your name";
		} else {
			$nameerror = NULL;
			}
	if(empty($Company) || $Company == " ") {
		$comperror = "You must provide a company name";
		} else {
			$comperror = NULL;
			}
	if(empty($country) || $country == " ") {
			$countryError = "Please enter your country";
		} else {
			$countryError = NULL;
			}
	if(empty($Phone) || $Phone == " " || $Phone == "000-000-0000" ) {
		$phoneerror = "You must provide a phone number";
		} else {
			$phoneerror = NULL;
			}
	if(empty($Last) || $Last == " ") {
		$lasterror = "You must provide your last name";
		} else {
			$lasterror = NULL;
			}
	if (check_email_address($Email) ) {
		$emailformaterror = NULL;
		} else {
			$emailerror = "Please enter a valid email address";
			}
	if(($nameerror == NULL && $comperror == NULL && $phoneerror == NULL && $countryError == NULL) && ($emailerror == NULL && $lasterror == NULL && md5($number) == $_SESSION['image_random_value'])){

	$subject = "Sono-Tek Newsletter Confirmation";

	//$confirm_body = '<html><body>Hello&nbsp;' . $Name . ',<br />Thank you for signing up for the Sono-Tek newsletter. You will receive your first news letter very shortly. If you did not sign up for this service please follow the provided link to remove your information from our list. Thank you again.<br />Remove me from the list:<br /><a href="http://www.sono-tek.com/newsletter/remove.php">http://www.sono-tek.com/newsletter/remove.php</a></body></html>';
	//alert notifies sono-tek employee of a sign up
	$alert = '<html><body>' . $Date . '<br />' . $Name . '&nbsp;' . $Last . '&nbsp;from&nbsp;' . $Company . '&nbsp;has signed up for the News Letter<br />Email:&nbsp;' . $Email . '<br />Phone:&nbsp;' . $Phone . '<br />Country:&nbsp;'. $country .'<br />Newsletter Types:'. $compannounceText .'&nbsp;and&nbsp;'. $newproText .'<br />';

	//Headers
	$headers = "MIME-Version: 1.0\r\n";
	$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
	$headers .= "From: Sono-Tek Corporation <$so_email>";

	//email to sono-tek addresses
	//$emailSono = "cycorda@sono-tek.com,abruce@sono-tek.com";
	$emailSono = "websupport@sono-tek.com";

	mail($emailSono,$subject,$alert,$headers);
	//mail($Email,$subject,$confirm_body,$headers);
	//mail($so_email,$subject,$alert,$headers);

	//escape the variables before entering them
	$Name = mysql_real_escape_string($Name);
	$Company = mysql_real_escape_string($Company);
	$country = mysql_real_escape_string($country);
	$Phone = mysql_real_escape_string($Phone);
	$Email = mysql_real_escape_string($Email);
	$Last = mysql_real_escape_string($Last);

	//insert into the database and then redirect
	$sql_insert = "INSERT INTO newsletter (name, lastName, company, phone, email, corpAnnounce, newPro, date, country) VALUES ('$Name','$Last','$Company','$Phone','$Email','$compannounce','$newpro','$Date','$country')";

	mysql_query($sql_insert);

	header("location:http://www.sono-tek.com/newsletter/letterThanks.php");
	} else {
		$validerror = "Please enter the correct validation number";
		}
}