[RESOLVED] PHP adds blank record to database when you open the page?!

mings

Hi all, I created this page to add records to my database but now every time i go onto the venue_finder.php (the page you add records with) it adds a blank entry to my database... does anyone know a way to stop this? Please bear in mind I really am a n00b at this so clear replies would be SO greatly appreciated!

Thank you in advance!!!

<h1>Venue Finder </h1>
<p>Please fill in the details below to add a venue: </p>
<form action="venue_finder.php" method="post">
Venue:
<input type="text" name="venue">
<br>
Location:<label>
<select name="location">
<option>Somerset</option>
<option>Wiltshire</option>
<option>Dorset</option>
<option>Berkshire</option>
<option>Hampshire</option>
<option>East Sussex</option>
<option>Surrey</option>
<option>Isle of White</option>
</select>
</label>
<br>
Phone:
<input type="text" name="mobile"><br>
Web:
<input type="text" name="web"><br>
<input type="Submit">
</form>

<?
$username="*";
$password="";
$database="***";

$venue=$POST['venue'];
$phone=$POST['phone'];
$mobile=$POST['mobile'];
$web=$POST['web'];

mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

$query = "INSERT INTO venues VALUES ('','$venue','$phone','$mobile','$web')";
mysql_query($query);

mysql_close();
?>

stolzyboy

you have no if/else structure therefore, the sql insert is happening everytime and since there are no values associated from a form being submitted, they are being inserted as empty

a simple check to see if the form was submitted will solve that problem... also, look into sanitizing or cleaning your values so you don't fall victim to sql injections

hth,
stolzyboy

mings

seriously man, thank you so much for the reply! I have been pulling my hair out! 😛

I dont suppose you could go one further and suggest any tutorials or good links please? I'm sure that you could guess i'm a total n00b at this hehe, thank you so much!!!

stolzyboy

there's really gonna be no tutorial for that, just visit www.php.net and search for if/else structures and sanitizing input

below i've given you an example of how you could to it, this way, the form will show up every time, but only run the sql insert when you click the submit button, there may be an error since i can't fully test it, but you should get the idea

<h1>Venue Finder </h1>
<p>Please fill in the details below to add a venue: </p>
<form action="venue_finder.php" method="post">
Venue: 
<input type="text" name="venue">
<br>
Location:<label>
<select name="location">
<option>Somerset</option>
<option>Wiltshire</option>
<option>Dorset</option>
<option>Berkshire</option>
<option>Hampshire</option>
<option>East Sussex</option>
<option>Surrey</option>
<option>Isle of White</option>
</select>
</label>
<br>
Phone: 
<input type="text" name="mobile"><br>
Web: 
<input type="text" name="web"><br>
<input type="Submit" value="Submit" name="btnSubmit">
</form>

<?
if (isset($_POST['btnSubmit']) && $_POST['btnSubmit'] == "Submit")
{
$username="****";
$password="****";
$database="****";

$venue=$_POST['venue'];
$phone=$_POST['phone'];
$mobile=$_POST['mobile'];
$web=$_POST['web'];

mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

$query = "INSERT INTO venues VALUES ('','$venue','$phone','$mobile','$web')";
mysql_query($query);

mysql_close();
}
?>

mings

Thank you so much, you have just made me act like a complete wierdo in front of my friend I'm so happy!!! Thanks mate I really appreciate it! Take care! Also, if you have time, how do i mark this thread as resolved please?! Thanks again 😃

EDIT: Never mind, found it 😃

mings

Hmmmm, ok, its not resolved at all, now the form just does nothing... so I'm assuming that the == operator is not returning TRUE...

Anyone have any ideas on how to fix this... and damn me for marking this thread resolved 😛

mings

Ok resolved after all...

I simply changed the if statement...

if (isset($web)) {

blah blah!!!

}

Not an ideal solution but hey, it works better than before!!!

Thanks for the idea of the IF solution though!!! You are a star 😃

stolzyboy

you probably didn't change your submit button to reflect the changes i made on it so those variables were never set or equal to anything... setting it to $web is probably not an ideal solution since if they left that blank, it wouldn't submit and they wouldn't really know why or why not

you should probably also throw an echo in the if area to show the form was submitted