delet coding

chinna

hi...i try to delete the data by hit the delete button...but no changes..here i submit my coding..

<?php
if (isset($_REQUEST['delete']))
$select ="DELETE from details where amount = $nt[amount]"
?>

...sumone please help me..

chinna

i have try so many ways...but cannot...please help me...

<?php
$sql = "select *from details";
$query = @mysql_query($sql);
$countData = @mysql_num_rows($query);
?>
    <td width="62" bgcolor="#CAF3F7"><div align="center" class="style12"><?php while ($nt=mysql_fetch_array($query))
{
echo "<a href='aftersave.php'>delete</a> <br> ";
}?>
<?php
if (isset($_REQUEST['delete']))
$select ="DELETE from details where amount = $nt[amount]";
$querys = @mysql_query($select);
$countDatas = @mysql_num_rows($querys);
?>

...i try this coding....but nothing happen...i realy dunnu

big_nerd

I would imagine that there is an error in your SQL Programming.

It is best with DELETE, to use something like:

$sql_query = "DELETE from `database` WHERE `database`.id = $id_variable";
$sql_result = mysql_query($sql_query);

if (!isset($sql_result)) {
  echo "Query Failed to Execute";
}

I always use an "ID" field or something that is always unique. When making your database make a user_id section, int, with auto_increment on, and set it as your primary key...

This way when modifying or deleting records...you use the "id" section. Just good practice.

chinna

dear bib.nerd....there is no id in my database...so i have to retrive from my variable..example...i have to delete the data where the amount is same as called out from database...there is no id in my database

big_nerd

chinna,

You may wish to look into an Intro to MySQL Document.

I unfortunately do not have one in my links.. however, when you wish to delete something from a database, you should have one part that is unique, so you know that you are deleting the correct one..

if you look to delete like "DELETE FROM database WHERE (WORD = 'yes') " you can not only get an error (as there may be too many effected rows) or you may delete something you do not want.

If I am misunderstanding.. let me know.

big.nerd

chinna

big nerd..

yes i agree with u....i want to delete the data where amount field is equal to $nt[amount]...i didnt have id...but im using the amount field in my details table to delete the data...im using mysql..so...when i try to put id and do as autoincrement...my query qas failed...so i have no choices....please advice me if i do the wrong way...thank you...

big_nerd

chinna,

Can you show me your database structure?

I don't need to see the data, but if you can show me the SQL dump of your table structure perhaps I can help you better.

big.nerd

chinna

dear big.nerd...do u have msn or yahoo messenger....it can be more easy to communicate...mine is...msn chinna_82@hotmail.com .. yahoo = gsilan_82

chinna

here the solution

<?
include "db1.php";
$t_id=$_REQUEST['t_id'];
$rec_id=$_REQUEST['rec_id'];
$link=$_REQUEST['link'];
$acc_no=$_REQUEST['acc_no'];
$item=$_REQUEST['item'];
$description=$_REQUEST['description'];
$amount==$_REQUEST['amount'];


if($link='delete')
{
$sql_delete="delete  from details where rec_id='$rec_id'";
$result_delete=mysql_query($sql_delete)or die(mysql_error());
header("location:aftersave.php?t_id=$t_id");
}
elseif($link='update')
{
$sql_update="update details set acc_no='$acc_no',
								item='$item',
								description='$description',
								amount='$amount'
								 where rec_id='$rec_id'";
$result_update=mysql_query($sql_update)or die(mysql_error());
header("location:aftersave.php?t_id=$t_id");
}


?>

bradgrafelman

So... does that mean your problem is resolved? If so, don't forget to mark the thread resolved.

EDIT: By the way, did you know your code is most likely vulnerable to SQL injection attacks?

chinna

"EDIT: By the way, did you know your code is most likely vulnerable to SQL injection attacks?"

wht u mean by that? realy no idea

chinna

bradgrafelman wrote:
So... does that mean your problem is resolved? If so, don't forget to mark the thread resolved.

EDIT: By the way, did you know your code is most likely vulnerable to SQL injection attacks?

realy dont know wht u mean by that

big_nerd

chinna,

bradgrafelman's first comment is, under "Thread Tools" at the top, mark it RESOLVED if you have this question answered, so people know they do not need to clarify more.

And, SQL Injection is a security risk (or a flaw in someone's coding, I suppose). Google it and you will find enough information to keep you reading for the next few hours at least. Definately worth while.

bradgrafelman

And for the solution to this problem, you'd use something like [man]mysql_real_escape_string/man.

big_nerd

bradgrafelman,

Good point! I use MS SQL (at work) so I often forget how nice it is to work with MySQL.

chinna

whats the different...i already get the result without using mysql_real_escape_string()....wht i'll get if i put mysql_real_escape_string().?...realy dunnu the different...realy scared to add mysql_real_escape_string()...in my project...maybe it will affect the coding...

big_nerd

chinna,

If you don't put it in there it will affect your coding. If this website is public, someone could use this against you.

It is for security, you do want to do this; It is good practice, and makes sense. Try it on one of your strings to see what happens.

big.nerd

mike0210

<?php

// set server access variables
$host = "localhost";
$user = "root";
$pass = "";
$db = "gb_reservation";

// create mysqli object
// open connection
$mysqli = new mysqli($host, $user, $pass, $db);

// check for connection errors
if (mysqli_connect_errno()) {
die("Unable to connect!");
}

// if id provided, then delete that record
if (isset($GET['id'])) {
// create query to delete record
$query = "DELETE FROM personal_info WHERE id = " . $GET['id'];

// execute query
if ($mysqli->query($query)) {
// print number of affected rows
echo $mysqli->affected_rows . " row(s) affected";
}
else {
// print error message
echo "Error in query: $query. " . $mysqli->error;
}
}
// query to get records
$query = "SELECT * FROM personal_info";

// execute query
if ($result = $mysqli->query($query)) {
// see if any rows were returned
if ($result->num_rows > 0) {
// yes
// print them one after another
echo "<table cellpadding=10 border=1>";

echo '<div align=left><h3>List of name(s)</h3></div>';
echo '<table border=0 align=left width=1300 cellpadding="4">';
echo '<td bgcolor="#FF9900"><strong>ID<td bgcolor="#FF9900"><strong>Last Name<td bgcolor="#FF9900"><strong>First Name<td bgcolor="#FF9900"><strong>Address
<td bgcolor="#FF9900"><strong>Contact Number<td bgcolor="#FF9900"><strong>Email Address<td bgcolor="#FF9900"><strong>Room Type<td bgcolor="#FF9900"><strong>Room Accommodation
<td bgcolor="#FF9900"><strong>Delete';

    while($row = $result->fetch_array()) { 
	$img='<img src="images/delete.gif" />';
        echo "<tr>"; 
        echo '<td bgcolor="#F4F4F4">' . $row[0] . '</td>'; 
        echo '<td bgcolor="#E4E4E4">' . $row[1] . '</td>'; 
        echo '<td bgcolor="#F4F4F4">' . $row[2] . '</td>';
        echo '<td bgcolor="#E4E4E4">' . $row[3] . '</td>';
        echo '<td bgcolor="#F4F4F4">' . $row[4] . '</td>'; 
        echo '<td bgcolor="#E4E4E4">' . $row[5] . '</td>';
        echo '<td bgcolor="#F4F4F4">' . $row[6] . '</td>';
        echo '<td bgcolor="#E4E4E4">' . $row[7] . '</td>';
        echo "<td align=center><a href=" . $_SERVER['delete.php'] . "?id=" . $row[0]. ">$img</a></td>";
        echo "</tr>"; 
    } 
} 
// free result set memory 
$result->close();

}
else {
// print error message
echo "Error in query: $query. " . $mysqli->error;
}
// close connection
$mysqli->close();