Help with mysql basic search

dfpp

Im new to PHP but trying to use this script for sql search and getting:

Parse error: syntax error, unexpected $end in C:\Inetpub\wwwroot\greypage\davetest.php on line 36

using this:

<?php

$phonenumber = $_REQUEST[“phone”];
if ($phonenumber) {
mysql_connect("localhost",”user”,"pass") or die("Unable to Connect to Database");
            @mysql_select_db(“greypages”) or die("Unable to Select Database");
            $query = "SELECT * FROM 'residential' WHERE (Phone LIKE ‘”.$phonenumber.”’)”;
            $result=mysql_query($query);
            $num=mysql_num_rows($result);
            for ($i=0;$i<$num;$i++) {
                        $name=mysql_result($result,$i,”Name”);
                        $address=mysql_result($result,$i,”Street”);
            }
            mysql_close()
}

?>
<html>
<head>
<title>Phone Query</title>
</head>
<body>
<form>

<b>Number to Query:</b> <input type=”text” name=”phone” id=”phone” /><input type=”submit” value=”submit” 

name=”frmSubmit” />

</form>
<br />
<b>Results</b>
<?php
echo (“<b>Name:</b>”.$name.”<br />”);
echo (“<b>Address:</b>”.$address.”<br />”);
?>
</body>
</html>

Thanks for any guidance here!

[Mod Edit] - bpat1434 - Added

tags around code.[/i]

bpat1434

It seems that we've found the answer. By using a colored editor (or rather putting it in

 tags) we can see the error.

You use a regular double quote to start the query string: "
You use an accented double quote to end the query string: ”

These two characters are not the same.  Change the ending quote to be what the beginning is and that should fix that error.

dfpp

Thanks

Now seems to be getting
Parse error: syntax error, unexpected '>'

Something to do with html I guess but not understanding what
with the code now like this:

<?php

$phonenumber = $_REQUEST[“phone”];
if ($phonenumber) {
mysql_connect("localhost","user","pass") or die("Unable to Connect to Database");
            @mysql_select_db("greypages") or die("Unable to Select Database");
            $query = "SELECT * FROM 'residential' WHERE (Phone LIKE '".$phonenumber."')";
            $result=mysql_query($query);
            $num=mysql_num_rows($result);
            for ($i=0;$i<$num;$i++) {
                        $name=mysql_result($result,$i,”Name”);
                        $address=mysql_result($result,$i,”Street”);
            }
            mysql_close()


?>

<html>
<head>
<title>Phone Query</title>
</head>
<body>
<form>

<b>Number to Query:</b> <input type=”text” name=”phone” id=”phone” /><input type=”submit” value=”submit” 

name=”frmSubmit” />

</form>
<br />
<b>Results</b>

<?php
echo (“<b>Name:</b>”.$name.”<br />”);
echo (“<b>Address:</b>”.$address.”<br />”); 
?>
</body>
</html>

bpat1434

You need to terminate the command prior to the erroring line. You don't finish the statement "mysql_close()" with a semicolon.

dfpp

bpat1434 wrote:
You need to terminate the command prior to the erroring line. You don't finish the statement "mysql_close()" with a semicolon.

Cheers have added that in, but still seem to be getting

Parse error: syntax error, unexpected $end in PHP on line 37

with:

<?php

$phonenumber = $_REQUEST[“phone”];
if ($phonenumber) {
mysql_connect("localhost","user","pass") or die("Unable to Connect to Database");
            @mysql_select_db("db") or die("Unable to Select Database");
            $query = "SELECT * FROM 'residential' WHERE (Phone LIKE '".$phonenumber."')";
            $result=mysql_query($query);
            $num=mysql_num_rows($result);
            for ($i=0;$i<$num;$i++) {
                        $name=mysql_result($result,$i,”Name”);
                        $address=mysql_result($result,$i,”Street”);
            }
            mysql_close();


?>

<html>
<head>
<title>Phone Query</title>
</head>
<body>
<form>

<b>Number to Query:</b> <input type=”text” name=”phone” id=”phone” /><input type=”submit” value=”submit” 

name=”frmSubmit” />

</form>
<br />
<b>Results</b>

<?php
echo ("<b>Name:</b>".$name."<br />");
echo ("<b>Address:</b>".$address."<br />");
?>
</body>
</html>

bpat1434

you never close the if() statement curly braces....

bradgrafelman

bpat1434 wrote:
You need to terminate the command prior to the erroring line. You don't finish the statement "mysql_close()" with a semicolon.

Actually, this is technically incorrect.

While good coding practice says to terminate all commands with a semicolon, PHP's final '?>' tag also acts as a semicolon itself. Example, the following code has no syntax errors/warnings/notices:

<?php
echo "Hello world!";
echo "...goodbye, world!"
?>

EDIT: Also, a note about your HTML:

HTML attributes must be delimited by double or single quotes - not 'curly' quotes. So, the following HTML is invalid:

<b>Number to Query:</b> <input type=”text” name=”phone” id=”phone” />

and should instead be:

<b>Number to Query:</b> <input type="text" name="phone" id="phone" />

Notice how the syntax highlighter points out the difference?