i give up need help

dascool

i have been working on this for 6 hrs and i cant figure out. I took out most of the code since if i can figure out one, the rest will fall. The problem is everytime i hit the register button nothing happens

(CODE for register.php)

<?php 
require_once('Functions/regfunction.php');
if(isset($_POST['submit']) && $_POST['submit'] == "Register")
{ 
$feedback = user_register(); 

}
?>
<form action="register.php" method="POST">
<table width="520" cellpadding="5" cellspacing="0">
 <tr valign="bottom">
  <td width="155" valign="bottom" >
   <label for="q1">Display Name <span class="required">*</span></label>
  </td>
  <td valign="bottom">
   <input type="text" size="20" name="DisplayName" value ="<?php echo $_POST['displayname']; ?>">
  </td>
 </tr>
</table>
  <td valign="bottom">
  <input type="submit" name="submit" value="Register">
  </td>
 </tr>
</table>
</form>
</body>

function user_register() 
{
// get use ip to bring the ban hammer if needed
$userip = $_SERVER['REMOTE_ADDR'];
// will include everything from checking email synthax to encrypting passwords, pretty much all in 1 big function
	global $encryptstring;
	//strip invalid characters
$invalid = trim(preg_replace('/&nbsp:|\#|?/!#$%^&*()_+=-',"", strip_tags($_POST['displayname'])));
if ($invalid != $_POST['displayname'])
{
	$error_message = "Invalid Characters in Display name";
	return $error_message;
}
$_POST['displayname'] = $invalid;
$_POST['displayname'] = trim ($_POST['displayname']);
*/
// Can't have less than 5 Characters
if (strlen($_POST['displayname']) < 5)
{
	$feedback = "Display name must be at least 6 characters";
	return $feedback;
}
//Check Length of display name that did not exceed 15 characters
if (strlen($_POST['displayname']) > 15)
{
	$feedback = "Display name must be less than 15 characters";
	return $feedback;
}


*/
//Check if password fields match or not

if ($_POST['password'] != $_POST['passconfirm'])
{
	$feedback = "Sorry,the two passwords do not match";
	return $feedback;

}
//Check the length of password
if (strlen($_POST['pass']) < 5)
{
	$feedback = "The password must be at least 6 characters";
	return $feedback;

}
//Confirm Email fields match or not
if ($_POST['email'] !=  $_POST ['emailconfirm'])
{
	$feedback ="Sorry, the two emails do not match";
	return $feedback;

}
}

so what could be the problem, i do not get any synthax errors or anything at all. Everytime i hit the register button nothing happens so i have no diea. My code is alot longer than what i showed but if i can make something work everything else should fall into place

scrupul0us

have u tried the very basic debugging practices?

e.g. echoing out in areas to see where u make it into the code -or- using die statements to see whats failing?

dascool

scrupul0us wrote:
have u tried the very basic debugging practices?

e.g. echoing out in areas to see where u make it into the code -or- using die statements to see whats failing?

yep and i couldnt figure it out. everything works alone by itself but not in coherency

NogDog

First problem I see is that in the form, the Display Name input field has a name of "DisplayName", but in the validation function you refer to "$_POST['displayname']".

Also, that preg_replace() stuff looks suspicious. I'd suggest simplifying that whole section to:

// trim it
$_POST['DisplayName'] = trim($_POST['DisplayName']);
// deal with magic_quotes if it's turned on:
if(get_magic_quotes_gpc())
{
   $_POST['DisplayName'] = stripslashes($_POST['DisplayName']);
}
// check for invalid characters
if(preg_match('/[^a-zA-Z0-9]/', $_POST['DisplayName']))
{
   return("Invalid characters in display name");
}
// make sure it's at least 6 characters long
if(strlen($_POST['DisplayName']) < 6))
{
   return("Display Name must be at least 6 characters.");
}

dascool

Nope not the problem 🙁 i dont get any thing at all when i press the Register button. Don't know what could be the problem:queasy:

Piranha

With a quick glance I can't see that anything should be visible when you click submit, not unless something is wrong. Anyway you can set error_reporting(E_ALL) to see if there is some supressed errors.

NogDog

<?php
require_once('Functions/regfunction.php');
if(isset($_POST['submit']) && $_POST['submit'] == "Register")
{
$feedback = user_register();

}
?>

Your code doesn't show that you ever actually do anything with the value of $feedback; so all you appear to be doing is setting it to whatever is returned by the the user_register() function. You'll need to add something along the lines of:

if(empty($feedback))
{
   // process the form
}
else
{
   echo "<p class='error'>$feedback</p>\n";
}

dascool

NogDog wrote:
Your code doesn't show that you ever actually do anything with the value of $feedback; so all you appear to be doing is setting it to whatever is returned by the the user_register() function. You'll need to add something along the lines of:
if(empty($feedback))
{
   // process the form
}
else
{
   echo "<p class='error'>$feedback</p>\n";
}

ya that too doesnt work, i have no idea what could be wrong

leatherback

What do you mean 'it doesn't work'. Your function does not produce any output in itself. If you use the code you showed in your first post and nothing goes wrong, you WILL NOT get any output.

You need to echo or print data to get output.
Please be specific about what the exact problem is. 'it doesn't work' is not very helpfull to help you.

dascool

finally it worked after looking at it for a while, another question. WHen i hit submit button it only shows just one of the errors. Say if submit the form empty it only states that Display name is empty. I want it however to state all the errors. So would that pretty much require a for loop?

Weedpacket

Instead of returning $feedback immediately, build it up as you go through the checks, adding each message as needed. After making the checks, see if it's empty. If it is, there were no messages and hence no errors. If it's not, then there were messages and therefore at least one problem, so return it.

dascool

Weedpacket wrote:
Instead of returning $feedback immediately, build it up as you go through the checks, adding each message as needed. After making the checks, see if it's empty. If it is, there were no messages and hence no errors. If it's not, then there were messages and therefore at least one problem, so return it.

sorry for this question but how would i got build it up, would it just require that $feedback = true;

then at the end
if ($feedback = true)
{
echo $feedback
}

dascool

Weedpacket wrote:
Instead of returning $feedback immediately, build it up as you go through the checks, adding each message as needed. After making the checks, see if it's empty. If it is, there were no messages and hence no errors. If it's not, then there were messages and therefore at least one problem, so return it.

i kinda go it to work but i needed to have all the errors as an array otherwise it doesnt work at all.

Weedpacket

if ($feedback = true)
{
echo $feedback
}

That's setting $feedback equal to true. You meant if($feedback!="")