[RESOLVED] unexpected $end

JOrGeX_

Hi, i'm learning PHP and i maked this code:

<html>
<head>
<title>Problema</title>
</head>
<body>

<form method="post" action="pagina2.php">
<strong>Ingrese su Nombre:</strong>
<input type="text" name="nombre">
<br>
<strong>Ingrese su Edad:</strong>
<input type="text" name="edad">
<br>
<strong>Ingrese su Nacionalidad:</strong>
<select name="nacionalidad" id="nacion">
<option>Argentino
<option>Brasileño
</select>
<br>
<input type="submit" value="Enviar Datos">
</form>

</body>
</html>

and this on page 2

<html>
<head>
<title>Problema</title>
</head>
<body>

<?php
echo "El nombre ingresado es:";
echo $_REQUEST['nombre'];
echo "<br>";
echo "La edad es:";
echo $_REQUEST['edad'];
if ($edad<=18)
{
echo "Mayor de edad?: <strong>SI</strong>";
}
else
{
echo "Mayor de edad?: <strong>NO</strong>";
}
echo "<br>";
echo "Nacionalidad:";
if ($_REQUEST['nacionalidad']=="Argentino")
{
echo "AR";
}
else
{
echo "BR";
}

?>
</body>

</html>

But i get unexpected $end on line 35 on "pagina2.php" (page2.php), but is the </html>

Please help me.

[/B]

bradgrafelman

If you would have searched the boards, you would find that this error is commonly caused by a missing '}' (or ')') character. In your case, this else statement:

else 
{ 
echo "Mayor de edad?: <strong>NO</strong>";

is never closed.

This is why you should really start indenting your code, like so:

if ($edad<=18) {
    echo "Mayor de edad?: <strong>SI</strong>";
} else {
    echo "Mayor de edad?: <strong>NO</strong>"; 
    echo "<br>";
    // ...

Also, couple of other things:

Where is $edad ever defined? Or $nacionalidad? If you're trying to retrieve the age or nationality that the user submitted in a form, you should be using the $_POST superglobal array. The only way that using $edad (or $nacionalidad) would work is if the register_globals directive was enabled. If this is true, you should disable this directive - search on Google or this board to learn about the security risks this presents.
This if() statement:
```
if ($nacionalidad=Argentino) 
```
should be comparing $nacionalidad with a string. Strings are delimited by single or double quotes, e.g.
```
if ($nacionalidad='Argentino') 
```
Without these quotes, PHP thinks you're specifying a constant. For more information on what a constant is, see this man page: [man]language.constants[/man]. For more information on what a string is, see this man page: [man]language.types.string[/man].
In the same if() statement as above, you're using the '=' operator, but I suspect you're trying to use a comparison operator, meaning you're trying to check if the value of $nacionalidad is equal to "Argentino". As such, you need to use the '==' comparison operator, instead of the '=' assignment operator. For more information on what a comparison operator is, see this man page: [man]language.operators.comparison[/man]. For more information on what an assignment operator is, see this man page: [man]language.operators.assignment[/man].

EDIT: Me olvidé de decir "¡Bienvenido a PHPBuilder!" :p

JOrGeX_

I fixed some bugs, please read it again to correct me

bradgrafelman

The syntax itself looks fine... are you getting an error message? What's not working?

JOrGeX_

NOW IT WORKS!

THANKS A LOT!!!

THIS IS THE RESUL:

El nombre ingresado es:JOrGeX!
La edad es:16Mayor de edad?: SI
Nacionalidad:AR

U will see me around asking another things soon =P

JOrGeX_

This is the final code of page2 (pagina2.php)

<html>
<head>
<title>Problema</title>
</head>
<body>

<?php
echo "El nombre ingresado es: ";
echo "<strong>";
echo $_REQUEST['nombre'];
echo "</strong>";
echo "<br>";
echo "La edad es: ";
echo "<strong>";
echo $_REQUEST['edad'];
echo "</strong>";
echo "<br>";
if ($edad<=18)
{
echo "Mayor de edad?: <strong>NO</strong>";
}
else
{
echo "Mayor de edad?: <strong>SI</strong>";
}
echo "<br>";
echo "Nacionalidad: ";
echo "<strong>";
if ($_REQUEST['nacionalidad']=="Argentino")
{
echo "<strong>AR</strong>";
}
else
{
echo "<strong>BR</strong>";
}

?>
</body>

</html>

you can see a live demo here: http://www.sqlserverya.com.ar/phpya/usuarios/190.50.189.3/pagina1.php[/B]