Nested url variable in INCLUDE

bigtam

I am very new to this, but why won't this work:

<?php include("page<?php $GET[page]; ?>.htm") ?>

When the page url is "page.php?page=projects"

The include should load (well I am aiming for it to) a page called page_projects.htm

Any help, gratefully received.

Tam

bigtam

<?php
include "page".$GET['page'].".htm";
?>

Tam

HalfaBee

Try

<?php include("page" . $GET[page] . ".htm") ?>

suntra

What you want to do could possibly lead to some security issues ! Please make sure all files that could be accessed this way won't compromise security !

HalfaBee

As long as the .htm pages don't contain php this should be relativly safe.

scrupul0us

this is definitely not safe as it could lead to directory browsing and other unwanted usage

your best bet is to trap the $_GET, check it against a structure; switch or if/elseif, else which will handle the include


$page = $_GET['page'];

if (empty($page))
{
//include('page_home.htm')
}
elseif ($page == 'this')
{
//include('page_this.htm')
}
elseif ($page == 'that')
{
//include('page_that.htm')
}
else
{
//include('page_error.htm')
}

this works well if you KNOW which pages u have... you could store the valid page names in an array actually and just check for in_array instead of writing the elseif everytime